[issue24585] Windows installer does not detect existing installs

[Larry Hastings]

Larry Hastings added the comment:

What happened with this?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24585] Windows installer does not detect existing installs

[Steve Dower]

Steve Dower added the comment:

Good to go!

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24585] Windows installer does not detect existing installs

[Larry Hastings]

Larry Hastings added the comment:

Quoting from PEP 101:

   release blocker - Stops the release dead in its tracks.  You may not
 make any release with any open release blocker bugs.

So, yeah, I want to.

--
priority: release blocker - critical

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24585
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24585] Windows installer does not detect existing installs

[Larry Hastings]

Larry Hastings added the comment:

Did this work as hoped in beta 4?  Can we mark it as fixed now?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24585
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24585] Windows installer does not detect existing installs

[Steve Dower]

Steve Dower added the comment:

We won't really know until we've gotten feedback from people with b4 who 
install rc1 - the upgrade step is the part that needs testing, and that takes 
two releases.

If you want to pull the priority down though, go ahead.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24585
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24585] Windows installer does not detect existing installs

[Steve Dower]

Steve Dower added the comment:

Sorry to do that to you Larry, though I have done extra testing on these 
changes (hence the fake version support) so I'm confident they work, just not 
yet 100% confident the user experience is going to be correct.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24585
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24585] Windows installer does not detect existing installs

[Larry Hastings]

Larry Hastings added the comment:

Since we apparently can't test this without making the release, but it's 
important enough to not defer, I am in the unenviable position of shipping the 
last beta with this bug marked as a release blocker.

Fingers crossed!

--
nosy: +larry

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24585
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24585] Windows installer does not detect existing installs

[Roundup Robot]

Roundup Robot added the comment:

New changeset 8e18d615988e by Steve Dower in branch '3.5':
Issue #24585: Enables build-to-build upgrades that preserve settings.
https://hg.python.org/cpython/rev/8e18d615988e

New changeset 2a8a39640aa2 by Steve Dower in branch 'default':
Issue #24585: Enables build-to-build upgrades that preserve settings.
https://hg.python.org/cpython/rev/2a8a39640aa2

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24585
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24585] Windows installer does not detect existing installs

[Steve Dower]

Steve Dower added the comment:

Doesn't touch anything significant outside the installer, so I just committed 
it. Feel free to read over the change and comment here if you want, but we 
unfortunately won't get complete testing of this until rc1.

I added some helpers for faking out version numbers, so if you want to try 
building the installer you can do:

tools\msi\build.bat -x86
move PCBuild\win32\en-us test350
msbuild tools\msi\bundle\snapshot.wixproj /p:OverrideVersion=3.5.1 /t:Rebuild
move PCBuild\win32\en-us test351

which will give you two installers with different versions (though the actual 
interpreter is unaffected). Or just hold out for the actual releases - I'll be 
testing it in the meantime.

--
stage:  - commit review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24585
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24585] Windows installer does not detect existing installs

[Steve Dower]

New submission from Steve Dower:

If you have Python 3.5.0b2 installed and run the Python 3.5.0b3 installer, it 
will upgrade correctly, but gives no indication that it will remove the old one.

We should default to an upgrade using the same settings as the previous 
installation when one exists. Users can then hit Customize to change settings 
if they want, or uninstall the old version to do a clean install.

--
assignee: steve.dower
components: Installation, Windows
messages: 246426
nosy: paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Windows installer does not detect existing installs
type: behavior
versions: Python 3.5, Python 3.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24585
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24585] Windows installer does not detect existing installs

[Steve Dower]

Steve Dower added the comment:

Making this a release blocker - the installer changes required here are 
probably big enough that I really don't want the last beta going out without 
them (or alternatively, the rc to be the first time they get tried).

--
priority: normal - release blocker

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24585
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24585] Windows installer does not detect existing installs

[Steve Dower]

Steve Dower added the comment:

Looks like there's also a problem with Modify being performed by a different 
user than the one who installed last. Need to come up with a way to properly 
detect installed features, which should fix both cases.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24585
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com