[issue24740] make patchcheck doesn't detect changes if commit is done first

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I am pretty sure I have done the same after making all commits to the local 
branch.  Plus we have the better workflow.  So closing until there is a 
confirmed problem with the new workflow.

--
resolution:  -> out of date
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24740] make patchcheck doesn't detect changes if commit is done first

[Cheryl Sabella]

Cheryl Sabella  added the comment:

I believe this issue has been resolved under the new Github workflow.  I ran 
`make patchcheck` on a commit that had been pushed and it identified the 
changes.

--
nosy: +cheryl.sabella

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24740] make patchcheck doesn't detect changes if commit is done first

[R. David Murray]

R. David Murray added the comment:

You can install the same (patchcheck-equivalent) hooks the repo uses in your 
local repo.  If this is not documented in the devguide it should be.  The hooks 
are publicly available (hg.python.org/hooks).  (It has been so long since I set 
this up for myself that I don't remember the steps precisely, but I'm sure I 
could figure it out by looking at my setup if someone needs the info.)

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24740] make patchcheck doesn't detect changes if commit is done first

[Terry J. Reedy]

Terry J. Reedy added the comment:

Better: a local commit hook that rejects commits that cannot be pushed.  I 
think this has been discussed, but never done, unless something has been added 
to the devguide that I missed.

Better still: the hoped-for new workflow where patches are submitted to an 
automaton that checks, tests, commits, and merges for us.  I believe that this 
is part of both proposals that Brett Cannon will review.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24740] make patchcheck doesn't detect changes if commit is done first

[Robert Collins]

New submission from Robert Collins:

./python ./Tools/scripts/patchcheck.py
Getting the list of files that have been added/changed ... 0 files
Fixing whitespace ... 0 files
Fixing C file whitespace ... 0 files
Fixing docs whitespace ... 0 files
Docs modified ... NO
Misc/ACKS updated ... NO
Misc/NEWS updated ... NO
configure regenerated ... not needed
pyconfig.h.in regenerated ... not needed
robertc@lifeless-z140:~/work/cpython.hg$ hg diff
robertc@lifeless-z140:~/work/cpython.hg$ hg push 
ssh://h...@hg.python.org/cpython
pushing to ssh://h...@hg.python.org/cpython
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 3 changes to 3 files
remote:  - file Lib/distutils/tests/test_core.py is not whitespace-normalized 
in ef5a2ba9df62
remote: * Run Tools/scripts/reindent.py on .py files or 
Tools/scripts/reindent-rst.py on .rst files listed above
remote: * and commit that change before pushing to this repo.
remote: transaction abort!
remote: rollback completed
remote: abort: pretxnchangegroup.checkwhitespace hook failed

The mistake I made was committing then running patchcheck.

I think it would make sense, if there are no changed files, to either 
a) error - it doesn't make sense to run like this, or
b) use the list of files from the most recent commit as the files to check.

I think b) would be easier on developers.

--
messages: 247501
nosy: rbcollins
priority: normal
severity: normal
stage: needs patch
status: open
title: make patchcheck doesn't detect changes if commit is done first
type: enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com