[issue24798] _msvccompiler.py doesn't properly support manifests
Christoph Gohlke added the comment: It seems the switch to '/MT' was consciously intended as Python 3.5 itself is now compiled with '/MT'. For now I have patched _msvccompiler.py to use '/MD' and continue to link libraries built with '/MD'. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24798 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24798] _msvccompiler.py doesn't properly support manifests
Steve Dower added the comment: Those libraries will depend on vcruntime140.dll which is not installed with CPython right now. In order for packages built with future compilers to work we need to statically link that dependency but not ucrt, which there are linker options for. I'm thinking hard to come up with better approaches, but most of them require predicting the future. Create a new issue if you like or I'll make one when I have something to propose. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24798 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24798] _msvccompiler.py doesn't properly support manifests
R. David Murray added the comment: Please open a new issue, referencing this one. Priority should be set to release blocker. (I forget if regular users can do that; if you can't I will.) -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24798 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24798] _msvccompiler.py doesn't properly support manifests
Christoph Gohlke added the comment: This change broke all my builds that link statically against 3rd party libraries built with the `/MD` flag. `/MD` was used at least since Python 2.3 and is the default for static libraries in Visual Studio 2015. Some of the broken builds: lxml, pillow, matplotlib, pygame, pycuda, pymssql, netcdf4, GDAL, psycopg2, pycurl, gmpy, and pyopenssl. All of these packages built OK with Python 3.5.0b4. The build errors are of this kind: `error LNK2001: unresolved external symbol __imp_memchr` `error LNK2001: unresolved external symbol __imp_strstr` The linker throws the following warning: `LINK : warning LNK4098: defaultlib 'MSVCRT' conflicts with use of other libs; use /NODEFAULTLIB:library` -- nosy: +cgohlke ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24798 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24798] _msvccompiler.py doesn't properly support manifests
Steve Dower added the comment: Made a couple more changes (including a fix for vcruntime140.dll embedding) after testing numpy's build, but that worked fine with the final fixes. -- resolution: - fixed stage: - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24798 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24798] _msvccompiler.py doesn't properly support manifests
Roundup Robot added the comment: New changeset 8e966eba2b5e by Steve Dower in branch '3.5': Issue #24798: _msvccompiler.py doesn't properly support manifests https://hg.python.org/cpython/rev/8e966eba2b5e New changeset f61a083b843f by Steve Dower in branch 'default': Issue #24798: _msvccompiler.py doesn't properly support manifests https://hg.python.org/cpython/rev/f61a083b843f -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24798 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24798] _msvccompiler.py doesn't properly support manifests
Changes by Zachary Ware zachary.w...@gmail.com: -- assignee: - steve.dower components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware title: Issue in the MSVC compiler class in distutils on Python 3.5 - _msvccompiler.py doesn't properly support manifests versions: +Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24798 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24798] _msvccompiler.py doesn't properly support manifests
Steve Dower added the comment: I've simplified the manifest handling: * embed by default, since we no longer need to filter CRT SxS info * omit UAC info from DLLs * use full PATH when running tools * some other tidying Not necessarily going to wait for lots of reviews, as I know very few people are interested in distutils, but feel free to chime in if you like. I'll give it a day or so. -- keywords: +patch Added file: http://bugs.python.org/file40130/24798_1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24798 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
