[issue24934] django_v2 benchmark not working in Python 3.6

[Florin Papa]

Florin Papa added the comment:

No problem. Thank you for merging the patch!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Brett Cannon]

Brett Cannon added the comment:

Thanks for the patch, Florin! Only changes I made was to deprecate django_v2 
and to set the minimum Python version to 2.7.

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Roundup Robot]

Roundup Robot added the comment:

New changeset 8a9b86071c15 by Brett Cannon in branch 'default':
Issue #24934: Introduce the django_v2 benchmark using Django 1.9.0.
https://hg.python.org/benchmarks/rev/8a9b86071c15

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Florin Papa]

Florin Papa added the comment:

I have adapted the existent patch to the new benchmarks codebase. Please see 
the new patch (django_v3_2.patch) in the files section. The benchmark expects 
to have django in lib/Django-1.9 folder. The Django-1.9 sources are attached 
separately because of their size.

hg clone https://hg.python.org/benchmarks
cd benchmarks/
copy django_v3_2.patch to the current directory and Django-1.9.tar.gz to the 
lib/ directory
hg import --no-commit django_v3_2.patch
cd lib/
tar -xvf Django-1.9.tar.gz

--
Added file: http://bugs.python.org/file41221/django_v3_2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Florin Papa]

Changes by Florin Papa :


Added file: http://bugs.python.org/file41222/Django-1.9.tar.gz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Florin Papa]

Florin Papa added the comment:

I have attached django_v3_3.patch, as the previous one did not include the 
added file (performance/bm_django_v3.py).

--
Added file: http://bugs.python.org/file41223/django_v3_3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Brett Cannon]

Brett Cannon added the comment:

Django 1.9 is out, so when I have time I will create a django_v3 benchmark.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[R. David Murray]

R. David Murray added the comment:

An additional argument for waiting is issue 25486.

--
type: crash -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Brett Cannon]

Brett Cannon added the comment:

I would still rather wait until Django 1.9.0 is officially released else we are 
benchmarking alpha code which doesn't seem worth it. With Python 3.6.0 not due 
out until about 15 months after 1.9.0 comes out I think going 3 months without 
a Django benchmark for 3.6 is acceptable.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Brett Cannon]

Changes by Brett Cannon :


--
assignee:  -> brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Berker Peksag]

Berker Peksag added the comment:

I just downloaded Django-1.8.zip (florin.papa, 2015-08-27 11:49) and opened 
Django-1.8/django/__init__.py to check the Django version:

VERSION = (1, 9, 0, 'alpha', 0)

I think GitHub lets you download the master branch by default. I'd suggest to 
download the source release of Django 1.8.4 at 
https://pypi.python.org/pypi/Django/1.8.4

--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Florin Papa]

Florin Papa added the comment:

Please download Django from their github website: 
https://github.com/django/django

I checked and their latest stable release - Django 1.8.4 - from 
https://pypi.python.org/pypi/Django still has the getargspec issue.

Apparently the github version is 1.9.0 alpha. I have modified the patch and 
archive accordingly.

--
Added file: http://bugs.python.org/file40314/django_v3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Florin Papa]

Changes by Florin Papa :


Added file: http://bugs.python.org/file40315/Django-1.9.zip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Florin Papa]

Florin Papa added the comment:

The Django 1.8 archive that I attached is not patched, it is downloaded from 
the django github page without modifications. I have tested and Django 1.8 
works with the latest Python version pulled from hg.python.org/cpython.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Brett Cannon]

Brett Cannon added the comment:

Hmm, strange. I downloaded Django 1.8.latest myself and placed it and I still 
got the getargspec() failure using the default branch. I'll try again and 
verify that it wasn't something odd on my end.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Brett Cannon]

Brett Cannon added the comment:

Changeset 2f3b3c6c1190 adds the version range check to django_v2 to block it 
past 3.5.

I didn't add the django_v3 quite yet because I didn't realize that Django 1.8 
won't work without being manually patched by us (I thought that issue was 
limited to our Django 1.5 copy). I did check and the issue is fixed in Django 
1.9 which is due before the end of the year: 
https://code.djangoproject.com/wiki/Version1.9Roadmap .

Since this is for Python 3.6 which is in no way close to coming out I say we 
simply wait until Django 1.9.0 is released and then introduce django_v3 without 
having to keep our own patched version of Django around.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24934
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Florin Papa]

Florin Papa added the comment:

I have modified the Django-1.8.zip archive to extract to Django-1.8 directory.

To apply the patch please follow these steps:

hg clone https://hg.python.org/benchmarks
cd benchmarks/
copy django_v3.patch to the current directory and Django-1.8.zip to the lib/ 
directory
hg import --no-commit django_v3.patch
cd lib/
unzip Django-1.8.zip

--
Added file: http://bugs.python.org/file40272/Django-1.8.zip

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24934
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Antoine Pitrou]

Antoine Pitrou added the comment:

Both the fix and the v3 benchmark sound good to me. Note I haven't tried them.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24934
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Brett Cannon]

Brett Cannon added the comment:

LGTM on a cursory glance. Hopefully someone will have time to try the patch out 
and then commit it if everything works out.

--
stage:  - commit review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24934
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Florin Papa]

Florin Papa added the comment:

I have modified the patch to introduce django_v3 to the benchmark suite and 
deprecate django_v2 for Python 3.6 and up. In order for django_v3 to work, the 
latest django release must be present in lib/Django-1.8.

Django-1.8 is attached as a zip file because the patch would be too large if it 
included all these files. In order for the modifications to work, extract the 
archive to lib/Django-1.8 .

Thank you,
Florin

--
Added file: http://bugs.python.org/file40259/django_v3.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24934
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Florin Papa]

Changes by Florin Papa florin.p...@intel.com:


Added file: http://bugs.python.org/file40260/Django-1.8.zip

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24934
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Brett Cannon]

Brett Cannon added the comment:

The proposed patch directly modifies the copy of Django in the benchmark suite 
which isn't acceptable; we purposefully don't modify the project code we pull 
in for benchmark consistency and ease of maintenance.

It would be better to make sure a newer version of Django is fixed upstream, 
pull in the newer version to the benchmark suite, and then create a django_v3 
benchmark using that newer version while removing the django_v2 benchmark from 
the default set of benchmarks (if not fully remove it).

And can you sign the contributor agreement, Florin?

--
nosy: +brett.cannon, pitrou
stage:  - patch review
type: crash - 

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24934
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Antoine Pitrou]

Antoine Pitrou added the comment:

According to the docs, getargspec() should be replaced with getfullargspec(), 
which returns a compatible named tuple. This would probably also minimize the 
performance impact of the patch (I'm not sure getargspec() is in the critical 
path, but let's be careful).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24934
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24934] django_v2 benchmark not working in Python 3.6

[Florin Papa]

New submission from Florin Papa:

Hi All,

My name is Florin Papa and I work in the Server Languages Optimizations Team at 
Intel Corporation.

I would like to submit a patch that solves compatibility issues of the 
django_v2 benchmark in the Grand Unified Python Benchmark. The django_v2 
benchmark uses inspect.getargspec(), which is deprecated and was removed in 
Python 3.6. Therefore, it crashes with the message ImportError: cannot import 
name 'getargspec' when using the latest version of Python on the default 
branch.

The patch modifies the benchmark to use inspect.signature() when Python version 
is 3.6 or above and keep using inspect.getargspec() otherwise.
 

Regards,
Florin

--
components: Benchmarks
files: django_v2_compat_3_6.patch
keywords: patch
messages: 249119
nosy: florin.papa
priority: normal
severity: normal
status: open
title: django_v2 benchmark not working in Python 3.6
type: crash
versions: Python 3.6
Added file: http://bugs.python.org/file40253/django_v2_compat_3_6.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24934
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com