[issue24950] FAIL: test_expanduser when $HOME=/

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24950] FAIL: test_expanduser when $HOME=/

[Roundup Robot]

Roundup Robot added the comment:

New changeset 194b356c84f5 by Serhiy Storchaka in branch '3.5':
Issue #24950: Fixed expanduser tests when the users home directory in pwd is 
"/".
https://hg.python.org/cpython/rev/194b356c84f5

New changeset b9b99cb85a5f by Serhiy Storchaka in branch 'default':
Issue #24950: Fixed expanduser tests when the users home directory in pwd is 
"/".
https://hg.python.org/cpython/rev/b9b99cb85a5f

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24950] FAIL: test_expanduser when $HOME=/

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Yet one corner case is empty HOME value.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24950] FAIL: test_expanduser when $HOME=/

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24950] FAIL: test_expanduser when $HOME=/

[SilentGhost]

SilentGhost added the comment:

Here is the patch that addresses the issue in both tests. Felix, could you test 
it?

--
keywords: +patch
stage:  -> patch review
Added file: http://bugs.python.org/file41842/issue24950.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24950] FAIL: test_expanduser when $HOME=/

[SilentGhost]

SilentGhost added the comment:

> What if HOME is "//"?

Is this possible? What would be the result of these tests? Would they fail? As 
far as I understand my patch is just fixing problem introduced by fixes from 
issue 17809.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24950] FAIL: test_expanduser when $HOME=/

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

What if HOME is "//"?

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24950] FAIL: test_expanduser when $HOME=/

[SilentGhost]

SilentGhost added the comment:

For posixpath the fix is straightforward: just skip that assert if the home 
ends up being '/' (the '/' is tested above).

For pathlib, I'm not entirely sure what the fix should be.

--
nosy: +SilentGhost, pitrou
versions: +Python 3.6 -Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24950] FAIL: test_expanduser when $HOME=/

[Felix Yan]

Changes by Felix Yan felixonm...@archlinux.org:


--
title: FAIL: test_posixpath when $HOME=/ - FAIL: test_expanduser when $HOME=/

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24950
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24950] FAIL: test_expanduser when $HOME=/

[Felix Yan]

New submission from Felix Yan:

test_expanduser in test.test_posixpath.PosixPathTest fails when the users $HOME 
being exactly /, after the patch in issue17809 was introduced.

test test_posixpath failed -- Traceback (most recent call last):
  File /build/python/src/Python-3.5.0rc2/Lib/test/test_posixpath.py, line 
249, in test_expanduser
self.assertEqual(posixpath.expanduser(~), home.rstrip(/))
AssertionError: '/' != ''
- /
+

Would it be appropriate to apply the rstrip() also to the left part of the 
equation?

--
components: Tests
messages: 249273
nosy: felixonmars
priority: normal
severity: normal
status: open
title: FAIL: test_expanduser when $HOME=/
type: behavior
versions: Python 3.3, Python 3.4, Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24950
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24950] FAIL: test_expanduser when $HOME=/

[Felix Yan]

Felix Yan added the comment:

btw, there seems to be a relevant failure in test_pathlib as well:

test test_pathlib failed -- Traceback (most recent call last):
  File /build/python/src/Python-3.5.0rc2/Lib/test/test_pathlib.py, line 2015, 
in test_expanduser
self.assertEqual(p1.expanduser(), P(userhome) / 'Documents')
AssertionError: PosixPath('/Documents') != PosixPath('Documents')

(not sure if they are really relevant, though)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24950
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com