[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

[Dong-hee Na]

Change by Dong-hee Na :


--
versions: +Python 3.11 -Python 2.7, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

[Hugo Delgado]

Hugo Delgado  added the comment:

Yes, I've created a PR for it.

https://github.com/python/cpython/pull/27751

Happy to adapt it as needed.
Thanks

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

[Hugo Delgado]

Change by Hugo Delgado :


--
pull_requests: +26228
stage: test needed -> patch review
pull_request: https://github.com/python/cpython/pull/27751

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

[Andrei Kulakov]

Andrei Kulakov  added the comment:

Also see https://bugs.python.org/issue42255

Hugo: can you convert the patch to a PR?

--
nosy: +andrei.avk

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

[hudelgado]

hudelgado  added the comment:

I took a look at it and have a some more questions.
The class MacOSX(BaseBrowser) seems to be broken because it uses 'OpenUrl' 
which doesn't work in most recent versions of applescript, also that class 
doesn't seem to be used anywhere, is it ok to remove it, or should left it as 
is?
Although that class isn't used it contained an hack to open local files that 
didn't exist in the class MacOSXOSAScript(BaseBrowser), i've added that hack to 
the MacOSXOSAScript.
Can you validate if everything seems ok with this changes?
I'm happy to adjust things according to what you suggest.

--
Added file: https://bugs.python.org/file49341/24955.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

[Senthil Kumaran]

Senthil Kumaran  added the comment:

Hugo, I'd welcome such a change.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

[hudelgado]

hudelgado  added the comment:

Ok, I'm thinking in also replace the os.popen calls with subprocess.Popen to 
keep consistency with existing tests.
Do you think it's a good approach? Or should be better to just add some tests 
around the current implementation?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

[Senthil Kumaran]

Senthil Kumaran  added the comment:

Hugo, please go ahead and a test for this patch.

--
assignee:  -> orsenthil

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

[Hugo Delgado]

Hugo Delgado  added the comment:

I've bumped into this and won't mind working on it, is it ok for me to try to 
finish it?

--
nosy: +Hugo Delgado

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

[Eitan Adler]

Change by Eitan Adler :


--
nosy: +eitan.adler

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

[Eric Huss]

Changes by Eric Huss :


--
nosy: +ehuss

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

[Doug Hellmann]

Changes by Doug Hellmann :


--
nosy: +doughellmann

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

[Simon Conseil]

Simon Conseil added the comment:

I have looked at the webbrowser tests and it seems not so easy: currently the 
MacOS browser classes are not tested, and they don't the GenericBrowser base 
class. Instead they use custom code with os.popen, so it would require some 
work either replace os.popen with subprocess.Popen, or to mock the os.popen 
calls. I'm not sure I will the time to dig into this.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

[Senthil Kumaran]

Senthil Kumaran added the comment:

Simon, sure. It is just for someone, either commiters or other interested folks 
to add the tests on top of your patch. Agree with you that more change is 
required to add the required tests.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

[Senthil Kumaran]

Senthil Kumaran added the comment:

The patch is correct and will fix the issue. It will require test coverage to 
be complete so that we don't land upon similar issues in future.

--
nosy: +orsenthil
stage:  -> test needed
versions: +Python 3.5, Python 3.6 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

[Erwann Mest]

Erwann Mest added the comment:

+1

I've got like 3 apps which are broken.


- https://github.com/mkdocs/mkdocs/issues/465
- https://bugzilla.mozilla.org/show_bug.cgi?id=1012443

--
nosy: +_kud

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

[Simon Conseil]

New submission from Simon Conseil:

Hi,

There is an issue in the webbrowser module for Mac OS when the BROWSER 
environment variable is set:

Python 2.7.10 (default, Jul 14 2015, 19:46:27)
[GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.39)] on darwin
Type help, copyright, credits or license for more information.
Jedi is not installed, falling back to readline
Python shell history: /Users/simon/.pythonhistory
 import webbrowser
Traceback (most recent call last):
  File stdin, line 1, in module
  File 
/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/webbrowser.py,
 line 669, in module
cmd = _synthesize(cmdline, -1)
  File 
/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/webbrowser.py,
 line 94, in _synthesize
if controller and name.lower() == controller.basename:
AttributeError: 'MacOSXOSAScript' object has no attribute 'basename'

If I unset BROWSER then it works fine. The issue is that the MacOSXOSAScript 
class overrides BaseBrowser's init without redifining the basename attribute. 
So a simple fix is to remove the __init__ from MacOSXOSAScript (and I guess the 
same applies to the MacOSX class). The same issue applies to python 3.4

--
components: Library (Lib), Macintosh
files: webbrowser.patch
keywords: patch
messages: 249316
nosy: ned.deily, ronaldoussoren, sconseil
priority: normal
severity: normal
status: open
title: webbrowser broken on Mac OS X when using the BROWSER variable
versions: Python 2.7, Python 3.4
Added file: http://bugs.python.org/file40290/webbrowser.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24955
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com