[issue25018] test_shutil.test_make_archive() fails on Windows 8.1

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Tests failed on Mac OS X.
http://buildbot.python.org/all/builders/AMD64%20Snow%20Leop%203.5/builds/254/steps/test/logs/stdio
==
FAIL: test_make_tarball (test.test_shutil.TestShutil)
--
Traceback (most recent call last):
  File 
"/Users/buildbot/buildarea/3.5.murray-snowleopard/build/Lib/test/test_shutil.py",
 line 986, in test_make_tarball
self.assertEqual(tarball, base_name + '.tar.gz')
AssertionError: '/private/var/folders/0-/0-cd8XI2HU86vol3rX[38 chars]r.gz' != 
'/var/folders/0-/0-cd8XI2HU86vol3rXsMTU+++T[30 chars]r.gz'
- 
/private/var/folders/0-/0-cd8XI2HU86vol3rXsMTU+++TY/-Tmp-/tmpy8jleen7/archive.tar.gz
? 
+ /var/folders/0-/0-cd8XI2HU86vol3rXsMTU+++TY/-Tmp-/tmpy8jleen7/archive.tar.gz


==
FAIL: test_make_zipfile (test.test_shutil.TestShutil)
--
Traceback (most recent call last):
  File 
"/Users/buildbot/buildarea/3.5.murray-snowleopard/build/Lib/test/test_shutil.py",
 line 1075, in test_make_zipfile
self.assertEqual(res, base_name + '.zip')
AssertionError: '/private/var/folders/0-/0-cd8XI2HU86vol3rX[35 chars].zip' != 
'/var/folders/0-/0-cd8XI2HU86vol3rXsMTU+++T[27 chars].zip'
- 
/private/var/folders/0-/0-cd8XI2HU86vol3rXsMTU+++TY/-Tmp-/tmpgs7euvvg/archive.zip
? 
+ /var/folders/0-/0-cd8XI2HU86vol3rXsMTU+++TY/-Tmp-/tmpgs7euvvg/archive.zip


--

This was fixed in bbf72b164720.

--
nosy: +ned.deily, ronaldoussoren

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25018] test_shutil.test_make_archive() fails on Windows 8.1

[STINNER Victor]

STINNER Victor added the comment:

Strange, the bug is only on one buildbot. It pass on the Windows 8 buildbot:
http://buildbot.python.org/all/builders/AMD64%20Windows8%203.x/builds/1249

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25018] test_shutil.test_make_archive() fails on Windows 8.1

[STINNER Victor]

STINNER Victor added the comment:

The test pass on Windows 7 and Windows 10 buildbots.

--
title: test_shutil.test_make_archive() fails on Windows -> 
test_shutil.test_make_archive() fails on Windows 8.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25018] test_shutil.test_make_archive() fails on Windows 8.1

[Roundup Robot]

Roundup Robot added the comment:

New changeset 7bd6b8076c48 by Serhiy Storchaka in branch '3.4':
Explicitly test archive name in shutil.make_archive() tests to expose failure
https://hg.python.org/cpython/rev/7bd6b8076c48

New changeset beda04bf5991 by Serhiy Storchaka in branch '2.7':
Explicitly test archive name in shutil.make_archive() tests to expose failure
https://hg.python.org/cpython/rev/beda04bf5991

New changeset f842c2b710ed by Serhiy Storchaka in branch '3.5':
Explicitly test archive name in shutil.make_archive() tests to expose failure
https://hg.python.org/cpython/rev/f842c2b710ed

New changeset 738e227d0891 by Serhiy Storchaka in branch 'default':
Explicitly test archive name in shutil.make_archive() tests to expose failure
https://hg.python.org/cpython/rev/738e227d0891

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25018] test_shutil.test_make_archive() fails on Windows 8.1

[Zachary Ware]

Changes by Zachary Ware :


--
nosy: +zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25018] test_shutil.test_make_archive() fails on Windows 8.1

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I hope that I preserved the intention of the test. It tested relative 
make_archive() with base_name. Original test first changed working directory 
and drive (to the same drive as the drive of output file) and then called 
private function _make_tarball(). After my refactoring the code became call 
make_archive() that resolve base_name before changing current directory. The 
peculiarity of the buildbot is that it crates temporary files on different 
drive that current drive, and relative base_name were resolved to wrong 
absolute name.

Now the code changes current directory before calling make_archive() with 
relative base_name argument and the test makes sense on non-Windows. Also added 
similar test for zip format.

--
assignee:  -> serhiy.storchaka
stage:  -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25018] test_shutil.test_make_archive() fails on Windows 8.1

[Roundup Robot]

Roundup Robot added the comment:

New changeset 58937cd19a85 by Serhiy Storchaka in branch '3.4':
Issue #25018: Fixed testing shutil.make_archive() with relative base_name on
https://hg.python.org/cpython/rev/58937cd19a85

New changeset d9c4b35e3fdc by Serhiy Storchaka in branch '2.7':
Issue #25018: Fixed testing shutil.make_archive() with relative base_name on
https://hg.python.org/cpython/rev/d9c4b35e3fdc

New changeset 4312b6549590 by Serhiy Storchaka in branch '3.5':
Issue #25018: Fixed testing shutil.make_archive() with relative base_name on
https://hg.python.org/cpython/rev/4312b6549590

New changeset b076b62731b7 by Serhiy Storchaka in branch 'default':
Issue #25018: Fixed testing shutil.make_archive() with relative base_name on
https://hg.python.org/cpython/rev/b076b62731b7

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25018] test_shutil.test_make_archive() fails on Windows 8.1

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The build bot is green.

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25018] test_shutil.test_make_archive() fails on Windows 8.1

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

This is a consequence of 9774088c8ff7. I don't know why the test fails.

Added explicit checks for archive name.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com