[issue25094] [EASY][Windows] test_tools fails on Windows when passing

[Terry J. Reedy]

Change by Terry J. Reedy :


--
pull_requests:  -24577

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

[miss-islington]

Change by miss-islington :


--
pull_requests: +24577
pull_request: https://github.com/python/cpython/pull/25909

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

[STINNER Victor]

STINNER Victor  added the comment:

The issue should now be fixed in 3.6, 3.7 and master branches. You will have to 
wait for the next release in each branch to get the fix! In the meanwhile, you 
can skip manually the 2to3 by modifying manually the test.

Thanks for everybody who helped to report and identify the origin of the bug!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

[STINNER Victor]

STINNER Victor  added the comment:


New changeset ba1810e1ec8973e48128e17845b981d8894c0550 by Victor Stinner (Miss 
Islington (bot)) in branch '3.7':
bpo-25094: Fix test_tools.test_sundry() on Windows (GH-8406) (GH-8407)
https://github.com/python/cpython/commit/ba1810e1ec8973e48128e17845b981d8894c0550


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

[miss-islington]

miss-islington  added the comment:


New changeset 1724c0c984e6406d80d8ebe3bb7b70f23c8b5f45 by Miss Islington (bot) 
in branch '3.6':
bpo-25094: Fix test_tools.test_sundry() on Windows (GH-8406)
https://github.com/python/cpython/commit/1724c0c984e6406d80d8ebe3bb7b70f23c8b5f45


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

[miss-islington]

Change by miss-islington :


--
pull_requests: +7934

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

[miss-islington]

Change by miss-islington :


--
pull_requests: +7933

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 752d4b7531093c55d6f0a5846748f981d79b29d3 by Victor Stinner in 
branch 'master':
bpo-25094: Fix test_tools.test_sundry() on Windows (GH-8406)
https://github.com/python/cpython/commit/752d4b7531093c55d6f0a5846748f981d79b29d3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

[STINNER Victor]

STINNER Victor  added the comment:

Oh. I identified the root issue: Tools/scripts/2to3 is installed as 
Tools/scripts/2to3.py, a ".py" suffix is added. This script is tested on all 
non-Windows and skipped on Windows when run from source code, but test_sundry() 
imports 2to3.py which causes the test to fail, since the script expects an 
argument on the command line and fails with SystemExit which is not catched by 
test_sundry().

I wrote PR 8406 to skip 2to3.py. My PR also removes imported modules to remove 
side effects of the test.

--

Python 2.7 is not affected: test_tools is skipped on installed Python:

vstinner@WIN C:\>py -2.7 -m test test_tools 
...
test_tools skipped -- test irrelevant for an installed Python
...
Tests result: SUCCESS

--
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

[STINNER Victor]

Change by STINNER Victor :


--
keywords: +patch
pull_requests: +7932
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

[Lorenz Mende]

Lorenz Mende  added the comment:

Approving the behaviour on 3.6.5 and fresh cpython-built @master:

>From the docs: test_sundry "contains extremely basic regression tests... which 
>don't have separate tests of their own".

IMHO 2to3 can be added to the whitelist of test_sundry as it comes with its own 
unit tests. When test_sundry runs import_tool with '2to3', lib2to3 is called 
without args, resulting in an exit 2 which breaks the basic test.

--
nosy: +LorenzMende

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

[Terry J. Reedy]

Terry J. Reedy  added the comment:

For me now, test site fails on installed 3.6.6 and 3.7.0 and passes on 
repository builds.  Serial or parallel, no difference.

When I ran as part of the suite, I got --slaveargs message.

py -3.7 -m test  test_tools

says cannot import test tools.

py -3.7 -m test.test_tools
says the following for each file in the directory
Testing C:\Programs\Python37\Lib\test\
and ends with
ERROR: test_sundry (test.test_tools.test_sundry.TestSundryScripts)
--
Traceback (most recent call last):
  File "C:\Programs\Python37\lib\test\test_tools\test_sundry.py", line 36, in 
test_sundry
import_tool(name)
  File "C:\Programs\Python37\lib\test\test_tools\__init__.py", line 21, in 
import_tool
return importlib.import_module(toolname)
  File "C:\Programs\Python37\lib\importlib\__init__.py", line 127, in 
import_module
return _bootstrap._gcd_import(name[level:], package, level)
  File "", line 1006, in _gcd_import
  File "", line 983, in _find_and_load
  File "", line 967, in _find_and_load_unlocked
  File "", line 677, in _load_unlocked
  File "", line 728, in exec_module
  File "", line 219, in _call_with_frames_removed
  File "C:\Programs\Python37\Tools\scripts\2to3.py", line 5, in 
sys.exit(main("lib2to3.fixes"))
SystemExit: 2

--
versions: +Python 3.6, Python 3.7 -Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

[STINNER Victor]

STINNER Victor  added the comment:

> I had no failures on 3.4.3.

How do you run the test suite? The test fails when you pass option like -j0: 
python -m test -j0 test_tools.

IMHO the fix is trivial: monkey-patch sys.argv using support.swap_attr(sys, 
'argv', ...). (I didn't try the fix).

--
components: +Tests, Windows
keywords: +easy
nosy: +paul.moore, steve.dower, tim.golden, vstinner
title: Test_tools not working on Windows. -> [EASY][Windows] test_tools fails 
on Windows when passing

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com