[issue25099] test_compileall fails when run by unprivileged user on installed Python

[Brett Cannon]

Changes by Brett Cannon :


--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25099] test_compileall fails when run by unprivileged user on installed Python

[Brett Cannon]

Brett Cannon added the comment:

I feel I have already spent way too much time on this issue, but if you want to 
backport even further then feel free to.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25099] test_compileall fails when run by unprivileged user on installed Python

[Roundup Robot]

Roundup Robot added the comment:

New changeset fc0a7aa7ae61 by Brett Cannon in branch '3.4':
Issue #25099: Skip relevant tests in test_compileall when an entry on
https://hg.python.org/cpython/rev/fc0a7aa7ae61

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25099] test_compileall fails when run by unprivileged user on installed Python

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Do you want to backport the fix to 3.4 (and 2.7?)? Issue21264 was reported for 
3.4.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25099] test_compileall fails when run by unprivileged user on installed Python

[Brett Cannon]

Brett Cannon added the comment:

Thanks to Serhiy for all of the reviews!

--
resolution:  -> fixed
stage: commit review -> resolved

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25099] test_compileall fails when run by unprivileged user on installed Python

[Roundup Robot]

Roundup Robot added the comment:

New changeset 34bbd537b3e6 by Brett Cannon in branch '3.5':
Issue #25099: Skip relevant tests in test_compileall when an entry on
https://hg.python.org/cpython/rev/34bbd537b3e6

New changeset 21f3a92e0c6d by Brett Cannon in branch 'default':
Merge for issue #25099
https://hg.python.org/cpython/rev/21f3a92e0c6d

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25099] test_compileall fails when run by unprivileged user on installed Python

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Added new comments.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25099] test_compileall fails when run by unprivileged user on installed Python

[Brett Cannon]

Brett Cannon added the comment:

I have addressed Serhiy's comments again.

--
Added file: http://bugs.python.org/file40736/issue25099.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25099] test_compileall fails when run by unprivileged user on installed Python

[Brett Cannon]

Changes by Brett Cannon :


--
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25099] test_compileall fails when run by unprivileged user on installed Python

[Brett Cannon]

Brett Cannon added the comment:

Here is a new patch that addresses Serhiy's comments.

--
Added file: http://bugs.python.org/file40734/issue25099.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25099] test_compileall fails when run by unprivileged user on installed Python

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Added comments on Rietveld.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25099] test_compileall fails when run by unprivileged user on installed Python

[Brett Cannon]

Brett Cannon added the comment:

Here is a patch that should work. Can someone who has had the problem test it? 
It works in my limited testing but I want to make sure this solves it before I 
commit it.

--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file40580/issue25099.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25099] test_compileall fails when run by unprivileged user on installed Python

[Steve Dower]

Steve Dower added the comment:

IIRC there's an existing issue for this. (Or it may have just been mentioned in 
a "things that don't work when you're not root" list on an issue.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25099] test_compileall fails when run by unprivileged user on installed Python

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Existing issue21264 reports about failure of different test. It may be the same 
issue or different but related issues.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25099] test_compileall fails when run by unprivileged user on installed Python

[Brett Cannon]

Brett Cannon added the comment:

It sounds like some tests just need to have a decorator that blocks execution 
if the relevant __pycache__ isn't writable.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25099] test_compileall fails when run by unprivileged user on installed Python

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +benjamin.peterson, brett.cannon, eric.snow, georg.brandl, ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25099] test_compileall fails when run by unprivileged user on installed Python

[Zachary Ware]

New submission from Zachary Ware:

==
FAIL: test_no_args_respects_force_flag (test.test_compileall.CommandLineTests)
--
Traceback (most recent call last):
  File "C:\Program Files\Python 3.5\lib\test\test_compileall.py", line 229, in 
test_no_args_respects_force_flag
self.assertRunOK('-f', PYTHONPATH=self.directory)
  File "C:\Program Files\Python 3.5\lib\test\test_compileall.py", line 179, in 
assertRunOK
*self._get_run_args(args), **env_vars)
  File "C:\Program Files\Python 3.5\lib\test\support\script_helper.py", line 
135, in assert_python_ok
return _assert_python(True, *args, **env_vars)
  File "C:\Program Files\Python 3.5\lib\test\support\script_helper.py", line 
121, in _assert_python
err))
AssertionError: Process return code is 1
command line: ['C:\\Program Files\\Python 3.5\\python.exe', '-X', 
'faulthandler', '-S', '-m', 'compileall', '-f']

stdout:
---
(... truncated stdout ...)rror: [Errno 13] Permission denied: 'C:\\Program 
Files\\Python 3.5\\lib\\__pycache__\\sre_compile.cpython-35.pyc.978608563184'
Compiling 'C:\\Program Files\\Python 3.5\\lib\\sre_constants.py'...



No such problem on installed 3.4.3.

--
components: Tests, Windows
messages: 250614
nosy: paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
stage: needs patch
status: open
title: test_compileall fails when run by unprivileged user on installed Python
type: behavior
versions: Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com