[issue25171] does not build on OpenBSD with no value defined for PY_GETENTROPY

[STINNER Victor]

STINNER Victor added the comment:

Thanks Remi for your fix, the compilation succeeded on the buildbot. Sorry for 
the regression.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25171] does not build on OpenBSD with no value defined for PY_GETENTROPY

[Remi Pointel]

Remi Pointel added the comment:

Attached is the diff to use defined(PY_GETENTROPY) instead of #define 
PY_GETENTROPY 1.

--
Added file: http://bugs.python.org/file40631/Python_random_c

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25171] does not build on OpenBSD with no value defined for PY_GETENTROPY

[Roundup Robot]

Roundup Robot added the comment:

New changeset e4ac5a899657 by Victor Stinner in branch 'default':
Issue #25171: Fix compilation issue on OpenBSD in random.c
https://hg.python.org/cpython/rev/e4ac5a899657

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25171] does not build on OpenBSD with no value defined for PY_GETENTROPY

[Martin Panter]

Martin Panter added the comment:

Patch looks sensible to me, although I notice the rest of that module tends to 
prefer the #elif defined(PY_GETENTROPY) style. It looks like this might be 
introduced with Issue 25003.

--
nosy: +haypo, martin.panter
stage:  -> patch review
type:  -> compile error

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25171] does not build on OpenBSD with no value defined for PY_GETENTROPY

[Remi Pointel]

New submission from Remi Pointel:

Hi,

I'm trying to build Python on OpenBSD-current, but it does not build because it 
seems that PY_GETENTROPY does not have a value.

$ make
...
gcc -pthread -c -fno-strict-aliasing -Wsign-compare -Wunreachable-code -DNDEBUG 
-g -fwrapv -O3 -Wall -Wstrict-prototypes  -O2 -pipe   
-Werror=declaration-after-statement   -I. -IInclude -I./Include
-DPy_BUILD_CORE -o Python/random.o Python/random.c
Python/random.c:367:20: error: #if with no expression
Python/random.c: In function '_PyOS_URandom':
Python/random.c:370: warning: implicit declaration of function 
'dev_urandom_python'
Python/random.c:414:20: error: #if with no expression
Python/random.c: In function '_PyRandom_Init':
Python/random.c:417: warning: implicit declaration of function 
'dev_urandom_noraise'
Python/random.c:430:20: error: #if with no expression
Python/random.c: In function '_PyRandom_Fini':
Python/random.c:433: warning: implicit declaration of function 
'dev_urandom_close'
*** Error 1 in /home/remi/dev/cpython (Makefile:1534 'Python/random.o')

If I defined the PY_GETENTROPY to the value "1" line 76, it seems to works fine.

Remi.

--
files: Python_random_c
messages: 251040
nosy: rpointel
priority: normal
severity: normal
status: open
title: does not build on OpenBSD with no value defined for PY_GETENTROPY
versions: Python 3.6
Added file: http://bugs.python.org/file40511/Python_random_c

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com