[issue25479] Increase unit test coverage for abc.py

[Irit Katriel]

Irit Katriel  added the comment:

Thank you!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25479] Increase unit test coverage for abc.py

[Irit Katriel]

Irit Katriel  added the comment:


New changeset bd5dfd6c8c133ccda4dddcba3a8c5a9ea1aa1d6b by Irit Katriel in 
branch '3.10':
[3.10] bpo-25479: add unit test for __subclasshook__ in test_abc.py (GH-24034) 
(GH-26065)
https://github.com/python/cpython/commit/bd5dfd6c8c133ccda4dddcba3a8c5a9ea1aa1d6b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25479] Increase unit test coverage for abc.py

[Irit Katriel]

Irit Katriel  added the comment:


New changeset 1be93960612b29686d42c021f842e63e5143a625 by Miss Islington (bot) 
in branch '3.9':
bpo-25479: add unit test for __subclasshook__ in test_abc.py (GH-24034) 
(GH-26063)
https://github.com/python/cpython/commit/1be93960612b29686d42c021f842e63e5143a625


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25479] Increase unit test coverage for abc.py

[Irit Katriel]

Change by Irit Katriel :


--
pull_requests: +24706
pull_request: https://github.com/python/cpython/pull/26065

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25479] Increase unit test coverage for abc.py

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 3.0 -> 4.0
pull_requests: +24704
pull_request: https://github.com/python/cpython/pull/26063

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25479] Increase unit test coverage for abc.py

[Irit Katriel]

Change by Irit Katriel :


--
versions: +Python 3.11, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25479] Increase unit test coverage for abc.py

[Irit Katriel]

Change by Irit Katriel :


--
versions:  -Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25479] Increase unit test coverage for abc.py

[Irit Katriel]

Irit Katriel  added the comment:

This PR probably doesn't improve test coverage because the feature is tested 
indirectly (and directly from test_typing). But I think this test should be 
added nevertheless for completeness and to demonstrate how the feature works. 

That said, this test shows that the documentation of issubclass is not quite 
accurate when it states that "a class is considered a subclass of itself" 
 (https://docs.python.org/3/library/functions.html#issubclass).  

That should probably be a separate bpo.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25479] Increase unit test coverage for abc.py

[karl]

karl  added the comment:

@iritkatriel Github PR done. 
https://github.com/python/cpython/pull/24034

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25479] Increase unit test coverage for abc.py

[karl]

Change by karl :


--
keywords: +patch
nosy: +karlcow
nosy_count: 2.0 -> 3.0
pull_requests: +22875
pull_request: https://github.com/python/cpython/pull/24034

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25479] Increase unit test coverage for abc.py

[Irit Katriel]

Change by Irit Katriel :


--
keywords: +easy -easy (C), patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25479] Increase unit test coverage for abc.py

[Irit Katriel]

Irit Katriel  added the comment:

The patch needs to be converted to a github PR.

--
keywords: +easy (C)
nosy: +iritkatriel
versions: +Python 3.10, Python 3.8, Python 3.9 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25479] Increase unit test coverage for abc.py

[Brett Cannon]

Changes by Brett Cannon :


--
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25479] Increase unit test coverage for abc.py

[Szymon Trapp]

New submission from Szymon Trapp:

Added a new function to unit tests for abc.py to increase the test coverage, 
specifically for the usage of __subclasshook__.

This will cover lines 209-214.

Note: this is my first submission to Python and I'm following the advice to 
start with the unit tests coverage.

--
components: Tests
files: mywork.patch
keywords: patch
messages: 253453
nosy: szymon
priority: normal
severity: normal
status: open
title: Increase unit test coverage for abc.py
type: enhancement
versions: Python 3.6
Added file: http://bugs.python.org/file40860/mywork.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com