[issue25551] Event's test_reset_internal_locks too fragile

[Roundup Robot]

Roundup Robot added the comment:

New changeset 110dfb244b27 by Berker Peksag in branch '3.5':
Issue #25551: Test condition behavior instead of its internals
https://hg.python.org/cpython/rev/110dfb244b27

New changeset 9694185cdd9f by Berker Peksag in branch 'default':
Issue #25551: Test condition behavior instead of its internals
https://hg.python.org/cpython/rev/9694185cdd9f

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25551] Event's test_reset_internal_locks too fragile

[Berker Peksag]

Berker Peksag added the comment:

Thanks for the patch, Nir!

--
nosy: +berker.peksag
resolution:  -> fixed
stage:  -> resolved
status: open -> closed
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25551] Event's test_reset_internal_locks too fragile

[Nir Soffer]

Changes by Nir Soffer :


--
keywords: +patch
Added file: 
http://bugs.python.org/file40941/0001-Issue-254074-Test-condition-behavior-instead-of-inte.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25551] Event's test_reset_internal_locks too fragile

[Nir Soffer]

New submission from Nir Soffer:

test_reset_internal_locks is looking at Event's _cond._lock - this make it 
harder to change internal details of the Condition object and make the test 
fragile.

We should test the condition behavior instead.

--
components: Tests
messages: 254074
nosy: nirs
priority: normal
severity: normal
status: open
title: Event's test_reset_internal_locks too fragile
type: enhancement
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com