[issue25628] Make namedtuple "verbose" and "rename" parameters into keyword only arguments

[Raymond Hettinger]

Changes by Raymond Hettinger :


--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25628] Make namedtuple "verbose" and "rename" parameters into keyword only arguments

[Roundup Robot]

Roundup Robot added the comment:

New changeset f086d6c9d9f6 by Raymond Hettinger in branch 'default':
Issue #25628:  Make namedtuple "rename" and "verbose" parameters keyword-only.
https://hg.python.org/cpython/rev/f086d6c9d9f6

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25628] Make namedtuple "verbose" and "rename" parameters into keyword only arguments

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Ping again.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25628] Make namedtuple "verbose" and "rename" parameters into keyword only arguments

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Ping.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25628] Make namedtuple "verbose" and "rename" parameters into keyword only arguments

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Then namedtuple_keywords.diff LGTM. But please document changes.

--
assignee:  -> rhettinger
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25628] Make namedtuple "verbose" and "rename" parameters into keyword only arguments

[Guido van Rossum]

Guido van Rossum added the comment:

I think such a change can be safely made in a feature release (say 3.6) without 
further deprecation. But not in a bugfix release (say 3.5.2).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25628] Make namedtuple "verbose" and "rename" parameters into keyword only arguments

[Guido van Rossum]

Guido van Rossum added the comment:

And by "safely" I mean that I don't mind if some code breaks when they upgrade 
to a new feature release.

FWIW the code most likely to break is code that wraps these functions with an 
identical interface.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25628] Make namedtuple "verbose" and "rename" parameters into keyword only arguments

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Ping.

If the keyword-only changes can be made without deprecation, I would want to 
make such changes for json functions (issue18726). json.dump() takes 11 
positional parameters!

Guido, what you say about this?

--
nosy: +gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25628] Make namedtuple "verbose" and "rename" parameters into keyword only arguments

[Raymond Hettinger]

Changes by Raymond Hettinger :


--
title: Make namedtuple "verbose" and "renanme" parameters into keyword only 
arguments -> Make namedtuple "verbose" and "rename" parameters into keyword 
only arguments

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25628] Make namedtuple "verbose" and "rename" parameters into keyword only arguments

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I like the idea. But this is backward incompatible change. I would first add a 
warning.

Here is a patch. Yes, the code looks a little cumbersome, but this is only for 
one or two releases.

--
nosy: +serhiy.storchaka
stage:  -> patch review
Added file: http://bugs.python.org/file41051/namedtuple_keywords_deprecate.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25628] Make namedtuple "verbose" and "rename" parameters into keyword only arguments

[Raymond Hettinger]

Raymond Hettinger added the comment:

I don't think a warning is necessary because of what "verbose" does.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25628] Make namedtuple "verbose" and "rename" parameters into keyword only arguments

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Existing scripts can contain passing positional 'rename' argument: 
namedtuple('Point', 'x y', False, True).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25628] Make namedtuple "verbose" and "rename" parameters into keyword only arguments

[Raymond Hettinger]

Raymond Hettinger added the comment:

My judgment call is that the keyword-only change can be made directly, that the 
costs and clutter of deprecation and delay aren't worth in it this case, that 
the nature of the "verbose" and "rename" arguments puts this in the 
rare-to-non-existent category, that any remediation would be trivial (easier 
than shutting-off a warning), and that the user's come out ahead with the 
cleaner cut-over in this case.   There's no value in being pedantic on this 
one, some judgment is required.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25628] Make namedtuple "verbose" and "rename" parameters into keyword only arguments

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

OK, leave it to you. But may be worth to add a versionchanged directive.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com