[issue25690] Replacement for unittest.mock.mock_open

[Niv Ben-David]

Niv Ben-David added the comment:

I copied the code in place of the old mock_open in unittest/mock.py.

Regarding the VFS issue, I think that it really depends on what you're trying 
to test. If you only care about "side effects" on the file system, the VFS way 
it much better and easier. But if you want to test the way files are handled by 
your code (proper handling of errors during open/read/write seems the obvious 
thing here, but I can think of other use cases), then I think MockOpen is the 
better tool.

--
Added file: http://bugs.python.org/file42175/mock_open.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25690] Replacement for unittest.mock.mock_open

[Robert Collins]

Robert Collins added the comment:

Hmm, I haven't looked closely, but some high level thoughts.

I'm worried about making mock too complex here. We already say folk should use 
a VFS for complex file based tests, and there's quite a chunk of code you're 
adding - perhaps better to just use a VFS?

I don't like mock importing mock_open and mock_open importing mock: please keep 
this in a single mock.py at this point.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25690] Replacement for unittest.mock.mock_open

[Niv Ben-David]

Niv Ben-David added the comment:

Regarding the documentation changes, my version simply mocks `open` more 
"closely", so for the most part I can't think of any changes to the 
documentation. I've added a bit about the mock object acting as a map of file 
names to mock objects. Should I add anything else?

Regarding the tests, I've tried changing as little as possible to make sure I 
don't have any backward compatibility issues. However, some changes had to be 
made:
* By default, `open`'s mode is 'r', the new mock_open imitates this behavior, 
and so the test shows. Also, calling `open` as a context manager will call 
`close` in `__exit__`. These are the majority of changes to the testing code.
* test_mock_open_write and test_mock_open_read_with_argument: These 
functionalities' testing is taken care of by the new mock_open tests.
* test_readlines_data: I removed the `create` argument to `patch`. Must've been 
by accident. Fixed this in the new patch.

Sorry about the (very) late response, I've been preoccupied lately.

--
Added file: http://bugs.python.org/file41762/mock_open.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25690] Replacement for unittest.mock.mock_open

[R. David Murray]

R. David Murray added the comment:

Thanks for the submission. I haven't looked at this in detail, but the fact 
that you are changing existing unit tests indicates there is probably a 
backward compatibility problem with your patch.  Also if you are adding 
features I'd expect there to be doc changes, which would make it easier to 
understand what you are proposing.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25690] Replacement for unittest.mock.mock_open

[SilentGhost]

Changes by SilentGhost :


--
components: +Tests
nosy: +ezio.melotti, michael.foord, rbcollins
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25690] Replacement for unittest.mock.mock_open

[Niv Ben-David]

New submission from Niv Ben-David:

The unittest.mock module defines a mock_open utility to mock the builtin open 
function.

During a recent project I found I needed something more. Specifically, mocking 
different files at the same time, better mocking for operations (like seek, 
readlines, etc.) among others.

The project can also be found on http://github.com/nivbend/mock-open

Thanks

--
components: Library (Lib)
files: mock_open.patch
keywords: patch
messages: 255061
nosy: Niv Ben-David
priority: normal
severity: normal
status: open
title: Replacement for unittest.mock.mock_open
type: enhancement
versions: Python 3.6
Added file: http://bugs.python.org/file41113/mock_open.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com