[issue25788] fileinput.hook_encoded has no way to pass arguments to codecs

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Committed with some changes. Thank you for your contribution Joseph.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25788] fileinput.hook_encoded has no way to pass arguments to codecs

[Roundup Robot]

Roundup Robot added the comment:

New changeset 8ab8f5259f09 by Serhiy Storchaka in branch 'default':
Issue #25788: fileinput.hook_encoded() now supports an "errors" argument
https://hg.python.org/cpython/rev/8ab8f5259f09

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25788] fileinput.hook_encoded has no way to pass arguments to codecs

[Joseph Hackman]

Joseph Hackman added the comment:

Updated documentation in fileinput.rst, Doc/whatsnew/3.6.rst, Misc/NEWS and 
Misc/ACKS.

Thank you so much Serhiy for taking the time to review!

--
Added file: http://bugs.python.org/file42631/issue25788-3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25788] fileinput.hook_encoded has no way to pass arguments to codecs

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Oh, I forget. Needed updates of the documentation (including the 
"versionchanged" directive). And would be nice if you add corresponding 
entities in Doc/whatsnew/3.6.rst, Misc/NEWS and Misc/ACKS. The rest of the 
patch LGTM.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25788] fileinput.hook_encoded has no way to pass arguments to codecs

[Joseph Hackman]

Joseph Hackman added the comment:

Uploading a new patch to address the issues in previous patch.

--
Added file: http://bugs.python.org/file42620/issue25788-2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25788] fileinput.hook_encoded has no way to pass arguments to codecs

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Added comments on Rietveld (follow the "review" link beside the patch link).

--
assignee:  -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25788] fileinput.hook_encoded has no way to pass arguments to codecs

[Joseph Hackman]

Joseph Hackman added the comment:

Ping.

Just wondering if anyone on the nosy list would be willing to help review my 
patch. :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25788] fileinput.hook_encoded has no way to pass arguments to codecs

[Berker Peksag]

Changes by Berker Peksag :


--
nosy: +berker.peksag
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25788] fileinput.hook_encoded has no way to pass arguments to codecs

[Joseph Hackman]

Joseph Hackman added the comment:

I haven't seen OP in over 30 days, so am posting my own patch.

I've added an optional argument that defaults to strict and gets passed along.

I've updated the primary test to verify the argument passing, as well as that 
things get handled as specified in the documentation at 
https://docs.python.org/3.5/library/codecs.html

This is off-topic, but is there any way I can submit a patch that allows a 
similar fix for stdin? Presently there is no way at all to pass malformed 
unicode through fileinput using stdin that I can find.

--
keywords: +patch
nosy: +Joseph Hackman
Added file: http://bugs.python.org/file41777/issue25788.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25788] fileinput.hook_encoded has no way to pass arguments to codecs

[Terry J. Reedy]

Terry J. Reedy added the comment:

fileinput is in Python, hence the source is in Lib.  Online version is
https://hg.python.org/cpython/file/tip/Lib/fileinput.py
https://hg.python.org/cpython/file/tip/Lib/test/test_fileinput.py

Patching openhook itself looks trivial.  A test is the hard part. Laura, can 
you provide a test case? -- a short (one line?) file that fails with 
errors=strict and passes with something else?  A new test_errors method should 
be added to class Test_hook_encoded (the last testCase in the file).  I think 
the 'test' method would need revision.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25788] fileinput.hook_encoded has no way to pass arguments to codecs

[Swati Jaiswal]

Swati Jaiswal added the comment:

I want to work on this issue. @lac, can you please help as I searched but 
couldn't find the related files. Where can I find the code for this?

--
nosy: +curioswati

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25788] fileinput.hook_encoded has no way to pass arguments to codecs

[Laura Creighton]

New submission from Laura Creighton:

Right now there is no way, aside from writing your own openhook, to
get around the limitation that openhook=fileinput.hook_encoded("utf")
will open things with the default option for codecs.open()
of errors=strict.  Adding a way to pass the errors argument seems
both easy to do and useful.

--
components: IO
messages: 255818
nosy: lac, serhiy.storchaka
priority: normal
severity: normal
status: open
title: fileinput.hook_encoded has no way to pass arguments to codecs
versions: Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25788] fileinput.hook_encoded has no way to pass arguments to codecs

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

It would be easy to add the errors parameter to fileinput.hook_encoded().

Do you want to provide a patch Laura?

--
components: +Library (Lib)
keywords: +easy
stage:  -> needs patch
type:  -> enhancement
versions:  -Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25788] fileinput.hook_encoded has no way to pass arguments to codecs

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

https://docs.python.org/devguide/#contributing

--
components: +Library (Lib)
type:  -> enhancement
versions:  -Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25788] fileinput.hook_encoded has no way to pass arguments to codecs

[Laura Creighton]

Laura Creighton added the comment:

I haven't made a patch to Python for over 10 years. Before mercurial. :) Where 
do you start in terms of 'how to submit a patch'?

--
components:  -Library (Lib)
type: enhancement -> 
versions: +Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25788] fileinput.hook_encoded has no way to pass arguments to codecs

[R. David Murray]

R. David Murray added the comment:

Mercurial didn't change the patch submission process (we're talking about 
making such changes on python-workflow now...or rather enhancements as the 
current process should continue to work).  The only thing that mercurial 
changed is how you get a copy of the current repo.  After that (which is 
explained in the devguide), just make your changes, do 'hg diff', and attach 
the diff file to the issue as usual.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com