[issue25913] base64.a85decode adobe flag incorrectly utilizes <~ as a marker causing error

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you Soren for your report, thank you Swati for your patch, and thank you 
Martin for your review.

--
assignee:  -> serhiy.storchaka
resolution:  -> fixed
stage: test needed -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25913] base64.a85decode adobe flag incorrectly utilizes <~ as a marker causing error

[Roundup Robot]

Roundup Robot added the comment:

New changeset ce5bf3290621 by Serhiy Storchaka in branch '3.5':
Issue #25913: Leading <~ is optional now in base64.a85decode() with adobe=True.
https://hg.python.org/cpython/rev/ce5bf3290621

New changeset 90d5473b8673 by Serhiy Storchaka in branch 'default':
Issue #25913: Leading <~ is optional now in base64.a85decode() with adobe=True.
https://hg.python.org/cpython/rev/90d5473b8673

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25913] base64.a85decode adobe flag incorrectly utilizes <~ as a marker causing error

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Martin, Antoine, what would you say about this?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25913] base64.a85decode adobe flag incorrectly utilizes <~ as a marker causing error

[Swati Jaiswal]

Swati Jaiswal added the comment:

Is there any requirement for further modification or it can be accepted?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25913] base64.a85decode adobe flag incorrectly utilizes <~ as a marker causing error

[Swati Jaiswal]

Swati Jaiswal added the comment:

Modified according to Serhiy's last comment.

--
Added file: http://bugs.python.org/file41621/iss_25913_3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25913] base64.a85decode adobe flag incorrectly utilizes <~ as a marker causing error

[Terry J. Reedy]

Terry J. Reedy added the comment:

Soren, for me, the page you link to is impossible to read as it blinks every 
second or so, something I have never seen before.  Perhaps it is trying to 
forward to the actual reference. As near as I can tell, it just lists about 3 
other documents and is not a reference in itself, and for me has no sections.  
Can you provide a better link, perhaps one that is more direct?

--
nosy: +terry.reedy
stage:  -> test needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25913] base64.a85decode adobe flag incorrectly utilizes <~ as a marker causing error

[Zachary Ware]

Changes by Zachary Ware :


--
nosy: +curioswati

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25913] base64.a85decode adobe flag incorrectly utilizes <~ as a marker causing error

[Swati Jaiswal]

Changes by Swati Jaiswal :


Added file: http://bugs.python.org/file41393/iss_25913_2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25913] base64.a85decode adobe flag incorrectly utilizes <~ as a marker causing error

[Martin Morrison]

Martin Morrison added the comment:

The proposed patch does stop requiring the leading <~, but still trims the 
first two characters off the data set. This will no doubt fail in cases where 
there is no leading marker.

I think it will need to explicitly handle the case where the leading marker is 
there vs. not.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25913] base64.a85decode adobe flag incorrectly utilizes <~ as a marker causing error

[Swati Jaiswal]

Changes by Swati Jaiswal :


--
keywords: +patch
Added file: http://bugs.python.org/file41377/iss_25913.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25913] base64.a85decode adobe flag incorrectly utilizes <~ as a marker causing error

[Soren Solari]

New submission from Soren Solari:

According to the PDF Spec http://www.adobe.com/devnet/pdf/pdf_reference.html 
section 7.4.3,
The ascii85decode function only utilizes ~> as an EOD 2byte character, there is 
no mention of leading <~.   Therefore using the base64.a85decode(data, 
adobe=True) does not work on valid data coming from a pdf because that data may 
not have a leading <~.

Solution: do not require leading <~ for adobe=True.

--
messages: 256745
nosy: Soren Solari
priority: normal
severity: normal
status: open
title: base64.a85decode adobe flag incorrectly utilizes <~ as a marker causing 
error
type: behavior
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25913] base64.a85decode adobe flag incorrectly utilizes <~ as a marker causing error

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
components: +Library (Lib)
nosy: +isoschiz, pitrou, serhiy.storchaka
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com