[issue26076] redundant checks in tok_get in Parser\tokenizer.c

[Roundup Robot]

Roundup Robot added the comment:

New changeset f0acce8022d1 by Benjamin Peterson in branch 'default':
remove duplicated check for fractions and complex numbers (closes #26076)
https://hg.python.org/cpython/rev/f0acce8022d1

--
nosy: +python-dev
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26076] redundant checks in tok_get in Parser\tokenizer.c

[Martin Panter]

Martin Panter added the comment:

The change looks pretty good to me.

I guess some test cases could be added to Lib/test/test_grammar.py, unless 
there is somewhere else that already tests this sort of stuff.

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26076] redundant checks in tok_get in Parser\tokenizer.c

[SilentGhost]

SilentGhost added the comment:

Could any one of the core developers have a look? Seems like a rather 
straightforward change.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26076] redundant checks in tok_get in Parser\tokenizer.c

[Oren Milman]

Oren Milman added the comment:

Sorry for being so clueless.
The diff is attached.

I manually did some checks to verify that relevant stuff work correctly (the 
imaginary number 0j, and fractions starting with '0.').
I run 'python -m test', and got the following output:
352 tests OK.
1 test altered the execution environment:
test_subprocess
45 tests skipped:
test_bz2 test_crypt test_curses test_dbm_gnu test_dbm_ndbm
test_devpoll test_epoll test_fcntl test_fork1 test_gdb test_grp
test_idle test_ioctl test_kqueue test_lzma test_nis test_openpty
test_ossaudiodev test_pipes test_poll test_posix test_pty test_pwd
test_readline test_resource test_smtpnet test_socketserver
test_spwd test_sqlite test_ssl test_syslog test_tcl
test_threadsignals test_timeout test_tix test_tk test_ttk_guionly
test_ttk_textonly test_urllib2net test_urllibnet test_wait3
test_wait4 test_winsound test_xmlrpc_net test_zipfile64

Then, I removed my patch (and made sure hg diff output nothing), rebuilt 
CPython, run 'python -m test', and got exactly the same output.

--
versions: +Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5
Added file: http://bugs.python.org/file41574/issue26076.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com