[issue26131] Raise ImportWarning when loader.load_module() is used

[STINNER Victor]

STINNER Victor  added the comment:

I wrote https://github.com/benjaminp/six/pull/343 to fix the six module. I 
would appreciate a review.

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26131] Raise ImportWarning when loader.load_module() is used

[Sviatoslav Sydorenko]

Sviatoslav Sydorenko  added the comment:

> What is "VendorImporter"

@brett.cannon `VendorImporter` is something comping from `pkg_resources`. 
Because of an entangled traceback and the fact that it dynamically injects a 
vendored copy of `six`, it's hard to spot. Here's an upstream issue I filed 
about this warning: https://github.com/pypa/setuptools/issues/2481.

--
nosy: +webknjaz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26131] Raise ImportWarning when loader.load_module() is used

[Brandt Bucher]

Brandt Bucher  added the comment:

Yep, looks like that was it. Thanks!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26131] Raise ImportWarning when loader.load_module() is used

[Brett Cannon]

Brett Cannon  added the comment:

What is "VendorImporter" (see the message of the ImportWarning)? That's not in 
the stdlib, so it looks like your system is injecting something via some `.pth` 
file or environment variable that doesn't define exec_module().

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26131] Raise ImportWarning when loader.load_module() is used

[Brandt Bucher]

Brandt Bucher  added the comment:

I'm seeing the following test failure locally on master (doesn't seem to be 
showing up in CI though). I'm not too familiar with this stuff, but it looks 
related to this change:

==
FAIL: test_all (test.test___all__.AllTest) (module='distutils.command')
--
Traceback (most recent call last):
  File "/home/bucher/src/cpython/Lib/test/test___all__.py", line 55, in 
check_all
self.assertEqual(keys, all_set, "in module {}".format(modname))
  File "/home/bucher/src/cpython/Lib/contextlib.py", line 140, in __exit__
next(self.gen)
  File "/home/bucher/src/cpython/Lib/test/support/warnings_helper.py", line 
177, in _filterwarnings
raise AssertionError("unhandled warning %s" % reraise[0])
AssertionError: unhandled warning {message : 
ImportWarning('VendorImporter.exec_module() not found; falling back to 
load_module()'), category : 'ImportWarning', filename : '', lineno : 681, line : None}

--

Should we be ignoring the new warning in this test as well? I'm still not sure 
why I seem to be the only one seeing it.

--
nosy: +brandtbucher

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26131] Raise ImportWarning when loader.load_module() is used

[Brett Cannon]

Change by Brett Cannon :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26131] Raise ImportWarning when loader.load_module() is used

[Brett Cannon]

Brett Cannon  added the comment:


New changeset 2de5097ba4c50eba90df55696a7b2e74c93834d4 by Brett Cannon in 
branch 'master':
bpo-26131: Deprecate usage of load_module() (GH-23469)
https://github.com/python/cpython/commit/2de5097ba4c50eba90df55696a7b2e74c93834d4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26131] Raise ImportWarning when loader.load_module() is used

[Brett Cannon]

Change by Brett Cannon :


--
pull_requests: +22359
stage: commit review -> patch review
pull_request: https://github.com/python/cpython/pull/23469

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26131] Raise ImportWarning when loader.load_module() is used

[Brett Cannon]

Change by Brett Cannon :


--
stage: test needed -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26131] Raise ImportWarning when loader.load_module() is used

[Brett Cannon]

Brett Cannon  added the comment:

A PR is now up. I ended up deprecating the load_module() methods in importlib 
itself and then raise ImportWarning in the import system itself when falling 
back to load_module().

--
stage: patch review -> test needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26131] Raise ImportWarning when loader.load_module() is used

[Brett Cannon]

Change by Brett Cannon :


--
keywords: +patch
pull_requests: +21837
stage: test needed -> patch review
pull_request: https://github.com/python/cpython/pull/22905

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26131] Raise ImportWarning when loader.load_module() is used

[Brett Cannon]

Brett Cannon  added the comment:

If you look at 
https://github.com/python/cpython/blob/master/Lib/importlib/_bootstrap.py and 
https://github.com/python/cpython/blob/master/Lib/importlib/_bootstrap_external.py
 you will notice a bunch of comments near all the calls to load_module(). Those 
are the places that should be somehow triggering a DeprecationWarning.

I think there's a compatibility shim function which would need to raise an 
exception so that anyone who has implemented load_module() as the only way to 
handle loading get a warning (but I think that requires certain loaders to have 
appropriate support which hopefully they have already but someone needs to 
double-check). After that every implementation of load_module() should have a 
warning.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26131] Raise ImportWarning when loader.load_module() is used

[Joannah Nanjekye]

Joannah Nanjekye  added the comment:

Feel free to open a PR.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26131] Raise ImportWarning when loader.load_module() is used

[Michael Anckaert]

Michael Anckaert  added the comment:

Clarification: the imp module shows a DeprecationWarning when imported. Was 
this what was meant?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26131] Raise ImportWarning when loader.load_module() is used

[Michael Anckaert]

Michael Anckaert  added the comment:

I checked out the source (Lib/imp.py:219) and only see the docstring marking 
this method als Deprecated. No exceptions are being raised. 

I would like to work on this issue.

--
nosy: +michaelanckaert

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26131] Raise ImportWarning when loader.load_module() is used

[Brett Cannon]

Brett Cannon  added the comment:

@joannah no clue if this ever happened. Could you check the code if 
DeprecationWarning is being raised yet?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26131] Raise ImportWarning when loader.load_module() is used

[Joannah Nanjekye]

Joannah Nanjekye  added the comment:

@brett Since this was opened like years ago. Before I work on it, I was 
wondering If it is still relevant.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26131] Raise ImportWarning when loader.load_module() is used

[Joannah Nanjekye]

Change by Joannah Nanjekye :


--
nosy: +nanjekyejoannah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26131] Raise ImportWarning when loader.load_module() is used

[Brett Cannon]

New submission from Brett Cannon:

Since loader.load_module() is documented as deprecated, we should consider 
raising an ImportWarning when it is used. That way when Python 2.7 support ends 
we can either remove it or have one more release where the various 
ImportWarnings turn into DeprecationWarnings and we finally clean up the import 
semantics to only be spec-based.

--
components: Interpreter Core
messages: 258333
nosy: brett.cannon, eric.snow, ncoghlan
priority: normal
severity: normal
stage: test needed
status: open
title: Raise ImportWarning when loader.load_module() is used
type: behavior
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com