[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests:  -970

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

[Donald Stufft]

Changes by Donald Stufft :


--
pull_requests: +970

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

[Roundup Robot]

Roundup Robot added the comment:

New changeset 7a996e826f83 by Yury Selivanov in branch '3.6':
Issue #26182: Fix ia refleak in code that raises DeprecationWarning.
https://hg.python.org/cpython/rev/7a996e826f83

New changeset 7b0e79e7f567 by Yury Selivanov in branch 'default':
Merge 3.6 (issue #26182)
https://hg.python.org/cpython/rev/7b0e79e7f567

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

[Brett Cannon]

Brett Cannon added the comment:

Sorry I didn't get around to reviewing; I'm sick.

On Thu, Sep 15, 2016, 09:51 Yury Selivanov  wrote:

>
> Yury Selivanov added the comment:
>
> Merged.
>
> --
> resolution:  -> fixed
> stage: needs patch -> resolved
> status: open -> closed
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

[Yury Selivanov]

Yury Selivanov added the comment:

Merged.

--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

[Roundup Robot]

Roundup Robot added the comment:

New changeset 82e6017dc841 by Yury Selivanov in branch '3.6':
Issue #26182: Raise DeprecationWarning for improper use of async/await keywords
https://hg.python.org/cpython/rev/82e6017dc841

New changeset 3f8b75173543 by Yury Selivanov in branch 'default':
Merge 3.6 (issue #26182)
https://hg.python.org/cpython/rev/3f8b75173543

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

[Yury Selivanov]

Yury Selivanov added the comment:

I'm going to commit the patch now (I'm going on vacation tomorrow, and I want 
to watch the buildbots).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

[Guido van Rossum]

Changes by Guido van Rossum :


--
nosy:  -gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

[Yury Selivanov]

Yury Selivanov added the comment:

I had to rewrite the patch to make sure it reports correct position and covers 
all cases where using async/await should trigger a warning.

Brett, could you please take a look at the patch?

--
Added file: http://bugs.python.org/file44669/issue_26182.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

[Brett Cannon]

Brett Cannon added the comment:

I'm fine with it being in b2 because IMO the warning really should make it in 
3.6 and for stuff like this it's more critical to hit the RC for people's 
testing than the beta to work out semantic changes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

[Ned Deily]

Ned Deily added the comment:

As long as Brett is also OK with it, it can go in for 360b2.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

[Yury Selivanov]

Yury Selivanov added the comment:

Ned, would it be OK to commit this patch after b1?

async/await are scheduled to become real keywords in 3.7.  Right now they are 
only keywords in 'async def' blocks, meaning that it's OK to have a class with 
'async' or 'await' attributes.

So this will be a backwards compatibility breaking change in 3.7.  This patch 
makes Python to emit a warning each time you use async or await as an 
attribute/variable/etc.

--
nosy: +gvanrossum, ned.deily
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

[Guido van Rossum]

Changes by Guido van Rossum :


--
nosy:  -gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

[Brett Cannon]

Brett Cannon added the comment:

Because parsing is done before execution you can't flip on warnings during 
runtime in the file you to be affected.

As for the line number, that's because it's raise in C code that doesn't have a 
trigger in Python code. Try importing the code and you should get the line 
number of the import. Otherwise you will have to check if there is some 
function to specify a syntax warning that lets you set the line number 
explicitly (I don't think there is).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

[Marco Buttu]

Marco Buttu added the comment:

I added the PyErr_WarnEx(PyExc_DeprecationWarning, ...) in Python/ast.c, right 
below the check for None, True and False as names. Running the following test 
the message is properly printed:

def test_async(self):
with self.assertWarnsRegex(DeprecationWarning, "reserved keyword"):
async = 33

However, the test does not pass, because the DeprecationWarning is not 
triggered. I am sorry but as a cpython beginner I can not figure out how to 
solve the problem, so I hope someone else can find the time to do it

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

[Brett Cannon]

Brett Cannon added the comment:

You need to temporarily turn on warnings for it to work. For example:

  with warnings.catch_warnings():
  warnings.simplefilter('always')
  with self.assertWarnsRegex(DeprecationWarning, "reserved keyword"):
exec('async = 33')

Do notice I used exec() as otherwise the warning will be triggered at import 
instead of when the test runs.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

[STINNER Victor]

Changes by STINNER Victor :


--
nosy:  -haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords

[Yury Selivanov]

Yury Selivanov added the comment:

Assigning the issue to myself to make sure it won't be forgotten before it's 
too late.  Anish or Marco, feel free to propose a patch.

--
assignee:  -> yselivanov
stage:  -> needs patch
versions:  -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords

[STINNER Victor]

STINNER Victor added the comment:

Can you please mention the python version in the title?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords in Python 3.6

[Brett Cannon]

Changes by Brett Cannon :


--
title: Deprecation warnings for the future async and await keywords -> 
Deprecation warnings for the future async and await keywords in Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords

[Marco Buttu]

Marco Buttu added the comment:

Thank you Brett, your explanation (msg259409) and the c-api doc are really 
straightforward. I think I can fix it in a few days, just the time to read the 
devguide and be confident about the workflow.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords

[Anish Shah]

Anish Shah added the comment:

I would like to work on this, if it is okay with Marco?
I look at the history of parsetok.c file and I think I can solve this issue. 

Also, I have a doubt - PEP 492 says that "async and await names will be softly 
deprecated in CPython 3.5 and 3.6".
What exactly does "softly deprecate" mean? is it just same as throwing a 
warning?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
nosy:  -pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords

[Brett Cannon]

Brett Cannon added the comment:

I'm not quite sure what you mean by "do not know how to check if the 
deprecation warning are enabled". Do you mean how do you make sure you don't 
emit a DeprecationWarning if someone hasn't turned warnings on? If that's the 
case then if you look at some example code and read 
https://docs.python.org/3/c-api/exceptions.html#issuing-warnings you will 
notice that when you call the warning-related functions, all you have to do is 
check if the return value is < 0, then return like there is an exception 
raised. Otherwise the warnings module handles whether something will be shown.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords

[Brett Cannon]

Brett Cannon added the comment:

I don't know what "softly deprecate" means. Hopefully someone involved with the 
PEP can answer that question.

--
nosy: +gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords

[Yury Selivanov]

Yury Selivanov added the comment:

> I don't know what "softly deprecate" means. Hopefully someone involved with 
> the PEP can answer that question.

I actually thought about emitting DeprecationWarnings in 3.6 for async/await 
NAME tokens.  I think it's a reasonable thing to do to prepare for 3.7, where 
they will become proper keywords.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords

[Marco Buttu]

Marco Buttu added the comment:

The check for the 'with' statement was handled in the parser (parsetok.c), and 
in Python 2.5 the warnings were enabled by default. 
I do not know how to check if the deprecation warning are enabled, otherwise I 
would have tried to fix the problem.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords

[Guido van Rossum]

Changes by Guido van Rossum :


--
nosy:  -gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords

[Brett Cannon]

Brett Cannon added the comment:

If someone wants to try and fix this, I would look at how the warning for the 
'with' statement was handled (it will either be in the compiler while 
generating bytecode or somewhere in the parser, but I'm fairly certain it's the 
compiler).

--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords

[Anish Shah]

Changes by Anish Shah :


--
nosy: +anish.shah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords

[SilentGhost]

Changes by SilentGhost :


--
components: +asyncio
nosy: +giampaolo.rodola, gvanrossum, haypo, pitrou, yselivanov

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26182] Deprecation warnings for the future async and await keywords

[Marco Buttu]

New submission from Marco Buttu:

I saw that async and await will become keywords in Python 3.7 :

https://www.python.org/dev/peps/pep-0492/#deprecation-plans

I enabled the deprecation warnings in Python 3.5.1 and Python 3.6 dev, and I 
noticed that assigning to async or await does not issue any deprecation 
warning: 

$ python -Wd -c "import sys; print(sys.version); async = 33"
3.5.1 (default, Jan 21 2016, 19:59:28)
[GCC 4.8.4]

$ python -Wd -c "import sys; print(sys.version); async = 33"
3.6.0a0 (default:4b434a4770a9, Jan 12 2016, 13:01:29)
[GCC 4.8.4]

--
components: Interpreter Core
messages: 258833
nosy: marco.buttu
priority: normal
severity: normal
status: open
title: Deprecation warnings for the future async and await keywords
type: enhancement
versions: Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com