[issue26243] zlib.compress level as keyword argument

[Łukasz Langa]

Change by Łukasz Langa :


--
pull_requests: +11693, 11694, 11695

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26243] zlib.compress level as keyword argument

[Łukasz Langa]

Change by Łukasz Langa :


--
pull_requests: +11693, 11694

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26243] zlib.compress level as keyword argument

[Łukasz Langa]

Change by Łukasz Langa :


--
pull_requests: +11693

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26243] zlib.compress level as keyword argument

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thanks Berker and Martin.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26243] zlib.compress level as keyword argument

[Roundup Robot]

Roundup Robot added the comment:

New changeset ab2e7e51869d by Serhiy Storchaka in branch 'default':
Issue #26243: Correct a wording in docs.
https://hg.python.org/cpython/rev/ab2e7e51869d

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26243] zlib.compress level as keyword argument

[Roundup Robot]

Roundup Robot added the comment:

New changeset 01f82a7a1250 by Serhiy Storchaka in branch 'default':
Issue #26243: Only the level argument to zlib.compress() is keyword argument
https://hg.python.org/cpython/rev/01f82a7a1250

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26243] zlib.compress level as keyword argument

[Martin Panter]

Martin Panter added the comment:

The patch (with Berker’s fix) looks okay. Personally, I don’t see a big problem 
with the first argument also having a keyword name, but I don’t mind if it 
doesn’t either.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26243] zlib.compress level as keyword argument

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Regenerated for review.

--
Added file: 
http://bugs.python.org/file43334/zlib_compress_positional_only_data.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26243] zlib.compress level as keyword argument

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The original request was for supporting level as keyword argument. Making the 
first argument a keyword argument was unintentional side effect (due a to the 
limitation of argument parsing functions). Now it is possible to support 
positional-only and keyword arguments in one function (see issue26282). 
Proposed patch makes the first argument positional-only again.

--
nosy: +serhiy.storchaka
resolution: fixed -> 
stage: resolved -> patch review
status: closed -> open
Added file: 
http://bugs.python.org/file43320/zlib_compress_positional_only_data.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26243] zlib.compress level as keyword argument

[Roundup Robot]

Roundup Robot added the comment:

New changeset dc758f51b8f5 by Martin Panter in branch 'default':
Issue 26243: Forgot to update zlib doc strings in Argument Clinic
https://hg.python.org/cpython/rev/dc758f51b8f5

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26243] zlib.compress level as keyword argument

[Martin Panter]

Martin Panter added the comment:

I did add a What’s New entry (I hope nobody minds), and updated the doc strings 
in the zlib module. Thanks for the work on this Aviv.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26243] zlib.compress level as keyword argument

[Aviv Palivoda]

Aviv Palivoda added the comment:

Added the "suggested" test

--
Added file: http://bugs.python.org/file41797/zlib-compress-level-keyword3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26243] zlib.compress level as keyword argument

[Berker Peksag]

Berker Peksag added the comment:

There is an outdated patch in issue 16764 for zlib.compress(), 
zlib.decompress(), zlib.flush() and other functions. Perhaps we can close it as 
a duplicate of this one.

--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26243] zlib.compress level as keyword argument

[Aviv Palivoda]

Aviv Palivoda added the comment:

Thanks for the review.
1. Changed "bytes" to "data".
2. Updated Doc as in issue 26244 (will update the patch if there will be 
changes there).
3. Added version changed notice but i don't think there is a need for What's 
new update.

--
Added file: http://bugs.python.org/file41773/zlib-compress-level-keyword2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26243] zlib.compress level as keyword argument

[Martin Panter]

Martin Panter added the comment:

Thanks, it looks good to me. I think “data” is a better name than “bytes”.

About What’s New, I thought the general idea was to document all enhancements, 
though I admit this is about as small as they come. There is precedent with the 
compile() builtin (Issue 1444529, Python 2.6), although there is no indication 
of kwargs in the main documentation for compile(). But on the other hand, 
str.split() didn’t get any What’s New entry (Issue 14081, Python 3.3). See also 
.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26243] zlib.compress level as keyword argument

[Martin Panter]

Martin Panter added the comment:

Seems like a reasonable enhancement. A couple of points:

* Watch out for the parameter names. Should it be “bytes” or “data”?
* Z_DEFAULT_COMPRESSION is -1 not 6 (see Issue 26244)
* Needs a version changed notice, and probably a What’s New update

--
nosy: +martin.panter
stage:  -> patch review
type: behavior -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com