[issue26273] Expose TCP_CONGESTION and TCP_USER_TIMEOUT to the socket module

[Donald Stufft]

Changes by Donald Stufft :


--
pull_requests: +857

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26273] Expose TCP_CONGESTION and TCP_USER_TIMEOUT to the socket module

[STINNER Victor]

STINNER Victor added the comment:

> Patch looks good to me.

Oh, I forgot socket_doc.patch! Thanks Serhiy for the reminder and Martin for 
the review :-) I just pushed the patch.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26273] Expose TCP_CONGESTION and TCP_USER_TIMEOUT to the socket module

[Roundup Robot]

Roundup Robot added the comment:

New changeset ffb2534fcbf1 by Victor Stinner in branch '3.6':
Issue #26273: Document TCP_USER_TIMEOUT and TCP_CONGESTION
https://hg.python.org/cpython/rev/ffb2534fcbf1

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26273] Expose TCP_CONGESTION and TCP_USER_TIMEOUT to the socket module

[Martin Panter]

Martin Panter added the comment:

Patch looks good to me.

BTW in Issue 27409 I proposed a patch listing more of these.

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26273] Expose TCP_CONGESTION and TCP_USER_TIMEOUT to the socket module

[STINNER Victor]

STINNER Victor added the comment:

Serhiy Storchaka: "Shouldn't we add something like versionadded/versionchanged 
or a mentioning in What's New?"

Oh right, we did that for other new constants added to Python 3.6 like 
SO_DOMAIN.

Attached socket_doc.patch documents the additional of the two new constants. It 
seems like "hg transplant" putted the NEWS entry in the wrong section :-/ The 
patch also fixes that.

--
Added file: http://bugs.python.org/file45692/socket_doc.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26273] Expose TCP_CONGESTION and TCP_USER_TIMEOUT to the socket module

[Roundup Robot]

Roundup Robot added the comment:

New changeset 6d69da76be6a by Victor Stinner in branch '3.6':
Add TCP_CONGESTION and TCP_USER_TIMEOUT
https://hg.python.org/cpython/rev/6d69da76be6a

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26273] Expose TCP_CONGESTION and TCP_USER_TIMEOUT to the socket module

[Ned Deily]

Ned Deily added the comment:

OK for 3.6.0rc1 (before it times out)

--
stage: patch review -> commit review
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26273] Expose TCP_CONGESTION and TCP_USER_TIMEOUT to the socket module

[Yury Selivanov]

Yury Selivanov added the comment:

Would be nice to have in 3.6.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26273] Expose TCP_CONGESTION and TCP_USER_TIMEOUT to the socket module

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Shouldn't we add something like versionadded/versionchanged or a mentioning in 
What's New?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26273] Expose TCP_CONGESTION and TCP_USER_TIMEOUT to the socket module

[Omar Sandoval]

Omar Sandoval added the comment:

Glad to see this finally get in :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26273] Expose TCP_CONGESTION and TCP_USER_TIMEOUT to the socket module

[Antoine Pitrou]

Antoine Pitrou added the comment:

Le 29/11/2016 à 16:59, STINNER Victor a écrit :
> 
> TCP_USER_TIMEOUT is super useful!

It is :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26273] Expose TCP_CONGESTION and TCP_USER_TIMEOUT to the socket module

[STINNER Victor]

STINNER Victor added the comment:

Sorry, I missed this issue.

TCP_USER_TIMEOUT is super useful! It helps a lot to detect when a server is 
down, especially when using keep alive: at kernel level (TCP keepalive) or 
application level (ex: RabbitMQ heart beat).

Linux default timeout is more something like 15 minutes. A few years ago, it 
was longer than 2 days :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26273] Expose TCP_CONGESTION and TCP_USER_TIMEOUT to the socket module

[STINNER Victor]

STINNER Victor added the comment:

@Ned Deily: Would you be ok to add these two constants to Python 3.6? I cannot 
image any regression if 674fb9644eaa is backported to Python 3.6.

@Serhiy, Yury: Any opinion on the backport?

--
nosy: +haypo, ned.deily, serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26273] Expose TCP_CONGESTION and TCP_USER_TIMEOUT to the socket module

[Roundup Robot]

Roundup Robot added the comment:

New changeset 674fb9644eaa by Victor Stinner in branch 'default':
Add TCP_CONGESTION and TCP_USER_TIMEOUT
https://hg.python.org/cpython/rev/674fb9644eaa

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26273] Expose TCP_CONGESTION and TCP_USER_TIMEOUT to the socket module

[Antoine Pitrou]

Antoine Pitrou added the comment:

+1 for this.  The patch looks fine, and there's no need to add any 
documentation or tests.

--
nosy: +pitrou
stage:  -> patch review
versions: +Python 3.7 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26273] Expose TCP_CONGESTION and TCP_USER_TIMEOUT to the socket module

[Jelte Fennema]

Jelte Fennema added the comment:

Is there any issue in merging this? TCP_USER_TIMEOUT is quite useful, for 
automatic failover of connections that suddenly died.

--
nosy: +JelteF

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26273] Expose TCP_CONGESTION and TCP_USER_TIMEOUT to the socket module

[Omar Sandoval]

New submission from Omar Sandoval:

The socket module is missing a couple of TCP socket options: TCP_CONGESTION was 
added to Linux in v2.6.13 and TCP_USER_TIMEOUT was added in v2.6.37. These 
should be exposed.

--
components: Library (Lib)
files: socket_tcp_options.patch
keywords: patch
messages: 259460
nosy: Omar Sandoval
priority: normal
severity: normal
status: open
title: Expose TCP_CONGESTION and TCP_USER_TIMEOUT to the socket module
type: enhancement
versions: Python 3.6
Added file: http://bugs.python.org/file41787/socket_tcp_options.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26273] Expose TCP_CONGESTION and TCP_USER_TIMEOUT to the socket module

[Yury Selivanov]

Changes by Yury Selivanov :


--
nosy: +yselivanov

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com