[issue26347] BoundArguments.apply_defaults doesn't handle empty arguments

2016-03-02 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 94879997ea5f by Yury Selivanov in branch '3.5':
inspect: Fix BoundArguments.apply_defaults to handle empty arguments
https://hg.python.org/cpython/rev/94879997ea5f

New changeset 779a0d51f7e2 by Yury Selivanov in branch 'default':
Merge 3.5 (issue #26347)
https://hg.python.org/cpython/rev/779a0d51f7e2

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26347] BoundArguments.apply_defaults doesn't handle empty arguments

2016-02-16 Thread Frederick Wagner

Frederick Wagner added the comment:

All right, looks like I have the asterisk now! Looking forward to officially 
contributing to the Python standard library :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26347] BoundArguments.apply_defaults doesn't handle empty arguments

2016-02-12 Thread Yury Selivanov

Yury Selivanov added the comment:

Hi Frederick, the patch looks good.  Thanks for reporting this!  Could you 
please sign the contributor agreement so that I can commit your patch?

--
assignee:  -> yselivanov
nosy: +yselivanov

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26347] BoundArguments.apply_defaults doesn't handle empty arguments

2016-02-11 Thread Frederick Wagner

New submission from Frederick Wagner:

[First-time contributor, feedback appreciated.]

Found and fixed some unexpected behavior in 
inspect.BoundArguments.apply_defaults. Simplest explanation is the following 
test that I added:

# Make sure a no-args binding still acquires proper defaults.
def foo(a='spam'): pass
sig = inspect.signature(foo)
ba = sig.bind()
ba.apply_defaults()
self.assertEqual(list(ba.arguments.items()), [('a', 'spam')])

I've included the patch file; is there anything else I can do?

--
components: Library (Lib), Tests
files: 0001-Make-apply_defaults-work-for-empty-arguments.patch
keywords: patch
messages: 260157
nosy: Frederick Wagner
priority: normal
severity: normal
status: open
title: BoundArguments.apply_defaults doesn't handle empty arguments
type: behavior
versions: Python 3.5, Python 3.6
Added file: 
http://bugs.python.org/file41906/0001-Make-apply_defaults-work-for-empty-arguments.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26347] BoundArguments.apply_defaults doesn't handle empty arguments

2016-02-11 Thread Martin Panter

Martin Panter added the comment:

Patch looks good to me

--
nosy: +martin.panter
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com