[issue26844] Wrong error message during import

[Roundup Robot]

Roundup Robot added the comment:

New changeset 22eaf6158e7b by Brett Cannon in branch '3.5':
Issue #26844: Fix imp.find_module() to have the exception related to
https://hg.python.org/cpython/rev/22eaf6158e7b

New changeset 46da639f7114 by Brett Cannon in branch 'default':
Merge for #26844
https://hg.python.org/cpython/rev/46da639f7114

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26844] Wrong error message during import

[Brett Cannon]

Brett Cannon added the comment:

Thanks for the patch, Lev!

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26844] Wrong error message during import

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

__qualname__ itself is not much more informative than __name__. You should use 
it together with __module__ to get the full qualified name. But 1) it is never 
used in error messages, 2) the code becomes more verbose, 3) the output becomes 
more verbose, and excessive verbose for builtin types.

__name__ LGTM. It is enough to identify the error.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26844] Wrong error message during import

[Lev Maximov]

Lev Maximov added the comment:

Nevermind. It's not urgent but should definitely be fixed some day.
Yes, __qualname__ might be a good idea.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26844] Wrong error message during import

[Brett Cannon]

Brett Cannon added the comment:

Should we use __qualname__ instead of __name__?

And I haven't forgotten about your patch, Lev. I'm just occupied trying to get 
feature changes into Python 3.6 as that has a sooner deadline than bug fixes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26844] Wrong error message during import

[Brett Cannon]

Changes by Brett Cannon :


--
assignee:  -> brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26844] Wrong error message during import

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

LGTM.

But while we are here, it would be nice to replace type(path) with 
type(path).__name__ (and the same for type(name)).

--
nosy: +eric.snow, ncoghlan, serhiy.storchaka
stage: patch review -> commit review
versions:  -Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26844] Wrong error message during import

[SilentGhost]

Changes by SilentGhost :


--
nosy: +brett.cannon
priority: normal -> low
stage:  -> patch review
versions:  -Python 3.2, Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26844] Wrong error message during import

[Lev Maximov]

New submission from Lev Maximov:

Error message was supposedly copy-pasted without change.
Makes it pretty unintuinive to debug.
Fix attached.

--
components: Library (Lib)
files: error.diff
keywords: patch
messages: 264157
nosy: Lev Maximov
priority: normal
severity: normal
status: open
title: Wrong error message during import
type: enhancement
versions: Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5, Python 3.6
Added file: http://bugs.python.org/file42584/error.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com