[issue27111] redundant variables in long_add and long_sub

[Mark Dickinson]

Changes by Mark Dickinson :


--
assignee:  -> mark.dickinson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27111] redundant variables in long_add and long_sub

[Mark Dickinson]

Mark Dickinson added the comment:

Applied; thanks. (I left the braces in, following PEP 7 ("braces are strongly 
preferred").

--
nosy: +mark.dickinson
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27111] redundant variables in long_add and long_sub

[Roundup Robot]

Roundup Robot added the comment:

New changeset 0e585bce0bb1 by Mark Dickinson in branch 'default':
Issue #27111: Minor simplication to long_add and long_sub fast path code. 
Thanks Oren Milman.
https://hg.python.org/cpython/rev/0e585bce0bb1

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27111] redundant variables in long_add and long_sub

[Oren Milman]

Changes by Oren Milman :


--
versions: +Python 3.7 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27111] redundant variables in long_add and long_sub

[Oren Milman]

Oren Milman added the comment:

done.
By the way, I am logging in to bugs.python.org through accounts.google.com, but 
I couldn't see any way to do the same in www.python.org, so I have a native 
account there (with the same email address). I hope that won't be an issue...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27111] redundant variables in long_add and long_sub

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Oren, could you please sign a Contributor Licensing Agreement?

http://www.python.org/psf/contrib/contrib-form/
http://www.python.org/psf/contrib/

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27111] redundant variables in long_add and long_sub

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +serhiy.storchaka
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27111] redundant variables in long_add and long_sub

[Oren Milman]

Changes by Oren Milman :


Added file: http://bugs.python.org/file42975/CPythonTestOutput.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27111] redundant variables in long_add and long_sub

[Oren Milman]

Changes by Oren Milman :


Added file: http://bugs.python.org/file42974/patchedCPythonTestOutput.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27111] redundant variables in long_add and long_sub

[Oren Milman]

New submission from Oren Milman:

 the proposed changes 
In Objects/longobject.c in long_add and long_sub, the variables 'result' and 
'r' (respectively), are used only once, and don't seem to make the code any 
clearer.

It seems the 'result' and 'r' variables were added in revision 40751. Back 
then, CONVERT_BINOP was used, and required calling Py_DECREF for a and b before 
returning.
Later on, in revision 43313, CONVERT_BINOP was removed, along with the calls to 
Py_DECREF it required, but the 'result' and 'r' variables were left untouched, 
and remained there to this day.


 diff 
The patches diff is attached.


 tests 
I built the patched CPython for x86, and played with it a little. Everything 
seemed to work as usual.

In addition, I ran 'python -m test' (on my 64-bit Windows 10) before and after 
applying the patch, and got quite the same output.
the outputs of both runs are attached.

--
components: Interpreter Core
files: proposedPatches.diff
keywords: patch
messages: 266271
nosy: Oren Milman
priority: normal
severity: normal
status: open
title: redundant variables in long_add and long_sub
versions: Python 3.6
Added file: http://bugs.python.org/file42973/proposedPatches.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com