[issue27286] str object got multiple values for keyword argument

[Nick Coghlan]

Nick Coghlan added the comment:


New changeset 93602e3af70d3b9f98ae2da654b16b3382b68d50 by Nick Coghlan in 
branch '3.5':
[3.5] bpo-29537: Tolerate legacy invalid bytecode (#169)
https://github.com/python/cpython/commit/93602e3af70d3b9f98ae2da654b16b3382b68d50


--
nosy: +ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27286] str object got multiple values for keyword argument

[Nick Coghlan]

Changes by Nick Coghlan :


--
pull_requests: +134

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27286] str object got multiple values for keyword argument

[Iryna]

Changes by Iryna :


--
nosy: +ishcherb

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27286] str object got multiple values for keyword argument

[Martin Panter]

Martin Panter added the comment:

Diff showing what changed relative to the main 3.5 branch when merging in the 
3.5.2 release: .

There are four news entries deleted from the 3.5.2rc1 section. Ideally they 
should have been moved to the 3.5.3rc1 section instead, because they were added 
after 3.5.2rc1 was branched, but before the 3.5.3rc1 heading appeared.

Also, there were some minor corrections of mine and Victor’s that were undone.

And I would suggest to restrict merge commits to changes that are already in at 
least one of the branches being merged. The edit to “byte-like” was not present 
in either of the branches being merged. In Git I think they call these changes 
“evil merges”.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27286] str object got multiple values for keyword argument

[Larry Hastings]

Larry Hastings added the comment:

Sorry about that!  It's almost like manually updating Misc/NEWS is a bad design 
:(

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27286] str object got multiple values for keyword argument

[Mark Dickinson]

Mark Dickinson added the comment:

It's difficult to track down which versions of Python 3.5.x the bytecode change 
is in because the Misc/NEWS entry has vanished, apparently in this merge 
commit: 

https://github.com/python/cpython/commit/aa0f9d8f26bbe63adcbce950aaadc844d996e7ac

--
nosy: +mark.dickinson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27286] str object got multiple values for keyword argument

[Shai Berger]

Shai Berger added the comment:

Following the last comment, and just as clarification for anyone else running 
into this and thinking like me: The bumped code is not included in v3.5.2, and 
v3.5.3 hasn't been released yet. Should it be undone?

No, because the bump which was encountered by John Ehresman on Debian Testing 
has also made it into Ubuntu 16.04LTS. Undoing it, at this point, is liable to 
bring even worse breakage than the original change caused.

http://changelogs.ubuntu.com/changelogs/pool/main/p/python3.5/python3.5_3.5.2-2ubuntu0~16.04.1/changelog

--
nosy: +shai

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27286] str object got multiple values for keyword argument

[Łukasz Langa]

Łukasz Langa added the comment:

The magic number change in a minor release was a mistake. Let's not do that 
with 3.6.x releases. Since Python doesn't check if there's a corresponding .py 
file that can be used to rebuild the .pyc file, we shouldn't reject existing 
.pyc files on the basis that they *might* be broken.

--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27286] str object got multiple values for keyword argument

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Bytecode generated by 3.5.1 is not correct (wrong error message can be not the 
only effect). The only way to resolve this issue is regenerating the bytecode.

3.5.2 was released two weeks after committing this patch. I expected it 
includes this change.

--
nosy: +larry

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27286] str object got multiple values for keyword argument

[John Ehresman]

John Ehresman added the comment:

Should the bytecode magic number be bumped in the 3.5 branch?  This breaks .pyc 
/ .pyo binary compatibility for python 3.5.  As far as I can tell this has 
never been done before in a release after the major.minor.0 final release.

This patch has made its way into debian's python 3.5 and I've gotten a bug 
report because of it for an app distributed without python source.

Looking at the 3.5.2 tarball, it does not look like the change was included in 
3.5.2.  If the magic number is bumped in 3.5, the comment should be changed to 
reflect that it changes in 3.5.3 and not in 3.5.2

--
nosy: +jpe

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27286] str object got multiple values for keyword argument

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27286] str object got multiple values for keyword argument

[Roundup Robot]

Roundup Robot added the comment:

New changeset 34d24c51eab6 by Serhiy Storchaka in branch '3.5':
Issue #27286: Fixed compiling BUILD_MAP_UNPACK_WITH_CALL opcode.  Calling
https://hg.python.org/cpython/rev/34d24c51eab6

New changeset 194549801bd5 by Serhiy Storchaka in branch 'default':
Issue #27286: Fixed compiling BUILD_MAP_UNPACK_WITH_CALL opcode.  Calling
https://hg.python.org/cpython/rev/194549801bd5

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27286] str object got multiple values for keyword argument

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Since currently generated bytecode is not correct, I think we should update the 
magic number for forcing the regenerating pyc-files.

--
Added file: 
http://bugs.python.org/file43332/BUILD_MAP_UNPACK_WITH_CALL-function_pos2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27286] str object got multiple values for keyword argument

[Raymond Hettinger]

Raymond Hettinger added the comment:

This patch looks correct.

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27286] str object got multiple values for keyword argument

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Here is a fix.

--
keywords: +patch
nosy: +serhiy.storchaka
stage:  -> patch review
Added file: 
http://bugs.python.org/file43331/BUILD_MAP_UNPACK_WITH_CALL-function_pos.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27286] str object got multiple values for keyword argument

[Martin Panter]

New submission from Martin Panter:

Playing with the generalized unpacking (PEP 448), I found a funny error 
message, when duplicate dictionary unpackings are included and also duplicate a 
literal keyword argument:

>>> print(end=".\n", **dict(end="dupe"))  # No problem
TypeError: print() got multiple values for keyword argument 'end'
>>> print(**dict(end=".\n"), **dict(end="dupe"))  # No problem
TypeError: print() got multiple values for keyword argument 'end'
>>> print(end=".\n", **dict(end="dupe"), **dict(end="dupe 2"))  # str object?!
TypeError: str object got multiple values for keyword argument 'end'

--
components: Interpreter Core
messages: 268110
nosy: martin.panter
priority: normal
severity: normal
status: open
title: str object got multiple values for keyword argument
type: behavior
versions: Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com