[issue27301] Incorrect return codes in compile.c

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you Benjamin.

2.7 needed to fix just one line.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27301] Incorrect return codes in compile.c

[Roundup Robot]

Roundup Robot added the comment:

New changeset 51fe72949245 by Serhiy Storchaka in branch '3.5':
Issue #27301: Fixed incorrect return codes for errors in compile.c.
https://hg.python.org/cpython/rev/51fe72949245

New changeset c388b0751290 by Serhiy Storchaka in branch '2.7':
Issue #27301: Fixed incorrect return code for error in compile.c.
https://hg.python.org/cpython/rev/c388b0751290

New changeset 2b3cd7e4b2b6 by Serhiy Storchaka in branch 'default':
Issue #27301: Fixed incorrect return codes for errors in compile.c.
https://hg.python.org/cpython/rev/2b3cd7e4b2b6

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27301] Incorrect return codes in compile.c

[Benjamin Peterson]

Benjamin Peterson added the comment:

lgtm

--
nosy: +benjamin.peterson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27301] Incorrect return codes in compile.c

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


Removed file: http://bugs.python.org/file43367/compile_rc-3.6.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27301] Incorrect return codes in compile.c

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


Added file: http://bugs.python.org/file43393/compile_rc-3.5.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27301] Incorrect return codes in compile.c

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


Added file: http://bugs.python.org/file43392/compile_rc-3.6_2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27301] Incorrect return codes in compile.c

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
keywords: +patch
Added file: http://bugs.python.org/file43367/compile_rc-3.6.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27301] Incorrect return codes in compile.c

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

Macros ADDOP, ADDOP_I, ADDOP_O, etc are used in Python/compile.c for emitting 
instructions. They make functions where they are used returning 0 on error. But 
some functions return -1 on error and non-negative integer on success. 0 is 
legitimate value. In case of error in the ADDOP* macro, the error is not 
correctly detected in the outer function.

Here is a patch that fixes this issue in 3.6. 3.5 and 2.7 need different 
patches.

--
assignee: serhiy.storchaka
components: Interpreter Core
messages: 268390
nosy: Demur Rumed, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: Incorrect return codes in compile.c
type: behavior
versions: Python 2.7, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com