[issue27312] test_setupapp (idlelib.idle_test.test_macosx.SetupTest) fails on OS X

[Ned Deily]

Ned Deily added the comment:

test_idle now runs without failing.  Thanks, Terry and Berker.

--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27312] test_setupapp (idlelib.idle_test.test_macosx.SetupTest) fails on OS X

[Roundup Robot]

Roundup Robot added the comment:

New changeset 61bd6974405f by Berker Peksag in branch 'default':
Issue #27312: Fix TypeError in test_setupapp
https://hg.python.org/cpython/rev/61bd6974405f

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27312] test_setupapp (idlelib.idle_test.test_macosx.SetupTest) fails on OS X

[Terry J. Reedy]

Terry J. Reedy added the comment:

My suggested mock was for the wrong function.  Please let me know what happens 
next time you pull and run test_idle whether alone or with the suite.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27312] test_setupapp (idlelib.idle_test.test_macosx.SetupTest) fails on OS X

[Roundup Robot]

Roundup Robot added the comment:

New changeset 90fd1c17214b by Terry Jan Reedy in branch 'default':
Issue #27312: mock out function that fails when called from setupApp during
https://hg.python.org/cpython/rev/90fd1c17214b

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27312] test_setupapp (idlelib.idle_test.test_macosx.SetupTest) fails on OS X

[Terry J. Reedy]

Terry J. Reedy added the comment:

test_setupapp calls setupApp with body 
if isAquaTk():
hideTkConsole(root)
overrideRootMenu(root, flist)
addOpenEventSupport(root, flist)
fixb2context(root)
isAquaTk should be True exactly twice, and it failed both times.  The overall 
code is definitely not re-entrant  On Carbon, 'application' in inserted before 
'file' and becomes menudef[0].  The puzzle to me is the failure on what should 
be the first call.

Until that is figured out, you could try decorating test_setupapp with
@mock.patch(idlelib.macosx.setupApp)
to see what, if anything, fails next.

I have access to a small Macbook Air with 11" diag. screen -- probably too 
small for my eyes for routine use but I should be able to run test_idle 
(especially post push) and do occasional exploratory editing, as needed here.  
I will try to learn enough about how to use it to follow the devguide 
instructions on setting up a repository.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27312] test_setupapp (idlelib.idle_test.test_macosx.SetupTest) fails on OS X

[Ned Deily]

Ned Deily added the comment:

Without looking closely at it, I would speculate that the failures are due to 
trying to test code in overrideRootMenu() that was previously only called once 
during execution and may not be re-enterant:

# Remove the last 3 items of the file menu: a separator, close window and
# quit. Close window will be reinserted just above the save item, where
# it should be according to the HIG. Quit is in the application menu.
del mainmenu.menudefs[0][1][-3:]
mainmenu.menudefs[0][1].insert(6, closeItem)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27312] test_setupapp (idlelib.idle_test.test_macosx.SetupTest) fails on OS X

[Ned Deily]

New submission from Ned Deily:

Running tests of 3.6.0a2 with gui enabled on OS X result in various failures of 
the form:

==
ERROR: test_setupapp (idlelib.idle_test.test_macosx.SetupTest) (tktype='carbon')
Call setupApp with each possible graphics type.
--
Traceback (most recent call last):
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/idlelib/idle_test/test_macosx.py",
 line 93, in test_setupapp
macosx.setupApp(root, flist)
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/idlelib/macosx.py",
 line 245, in setupApp
overrideRootMenu(root, flist)
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/idlelib/macosx.py",
 line 133, in overrideRootMenu
closeItem = mainmenu.menudefs[0][1][-2]
IndexError: list index out of range

==
ERROR: test_setupapp (idlelib.idle_test.test_macosx.SetupTest) (tktype='cocoa')
Call setupApp with each possible graphics type.
--
Traceback (most recent call last):
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/idlelib/idle_test/test_macosx.py",
 line 93, in test_setupapp
macosx.setupApp(root, flist)
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/idlelib/macosx.py",
 line 245, in setupApp
overrideRootMenu(root, flist)
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/idlelib/macosx.py",
 line 133, in overrideRootMenu
closeItem = mainmenu.menudefs[0][1][-2]
IndexError: list index out of range

--
components: IDLE
messages: 268492
nosy: ned.deily, terry.reedy
priority: high
severity: normal
stage: needs patch
status: open
title: test_setupapp (idlelib.idle_test.test_macosx.SetupTest) fails on OS X
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com