[issue27380] IDLE: add base Query dialog with ttk widgets

[Terry J. Reedy]

Change by Terry J. Reedy :


--
components: +IDLE

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27380] IDLE: add base Query dialog with ttk widgets

[Ned Deily]

Ned Deily added the comment:

With 8f37d772f71f, the test no longer fails.  Thanks!

--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27380] IDLE: add base Query dialog with ttk widgets

[Terry J. Reedy]

Terry J. Reedy added the comment:

While still curious if the Mac specific code is correct, I changed test to 
match the code.  Someone please check by running at least test_idle after 
pulling.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27380] IDLE: add base Query dialog with ttk widgets

[Roundup Robot]

Roundup Robot added the comment:

New changeset 8f37d772f71f by Terry Jan Reedy in branch 'default':
Issue #27380: For test_query on Mac, adjust one expected result.
https://hg.python.org/cpython/rev/8f37d772f71f

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27380] IDLE: add base Query dialog with ttk widgets

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
nosy: +markroseman

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27380] IDLE: add base Query dialog with ttk widgets

[Terry J. Reedy]

Terry J. Reedy added the comment:

The Mac failure comes from this piece of code:

if sys.platform == 'darwin':
path = self.result[1]
if path.startswith(('www', 'file:', 'http:', https:')):
pass
else:
# Mac Safari insists on using the URI form for local files
self.result = list(self.result)
self.result[1] = "file://" + path

Before I do anything,
is the comment right about needing to add "file://" for Safari?
is Safari still the default and/or correct way to open a local file?

The code that opens the supplementary help file or url is elsewhere, but it 
could be changed if outdated on the Mac.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27380] IDLE: add base Query dialog with ttk widgets

[Ned Deily]

Ned Deily added the comment:

test_click_help_source fails on OS X:

==
FAIL: test_click_help_source (idlelib.idle_test.test_query.HelpsourceGuiTest)
--
Traceback (most recent call last):
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/idlelib/idle_test/test_query.py",
 line 389, in test_click_help_source
Equal(dialog.result, ('__test__', __file__))
AssertionError: Tuples differ: ('__test__', 
'file:///Library/Frameworks/Python.framewo[58 chars].py') != ('__test__', 
'/Library/Frameworks/Python.framework/Vers[51 chars].py')

First differing element 1:
'file:///Library/Frameworks/Python.framewo[57 chars]y.py'
'/Library/Frameworks/Python.framework/Vers[50 chars]y.py'

  ('__test__',
-  
'file:///Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/idlelib/idle_test/test_query.py')
?   ---

+  
'/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/idlelib/idle_test/test_query.py')

--
nosy: +ned.deily
resolution: fixed -> 
stage: resolved -> needs patch
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27380] IDLE: add base Query dialog with ttk widgets

[Terry J. Reedy]

Terry J. Reedy added the comment:

Patch posted had code that belongs to #27465 and was deleted before pushing.

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27380] IDLE: add base Query dialog with ttk widgets

[Roundup Robot]

Roundup Robot added the comment:

New changeset 66fe8d9eae6c by Terry Jan Reedy in branch 'default':
Issue #27380: IDLE: add query.HelpSource class and tests.
https://hg.python.org/cpython/rev/66fe8d9eae6c

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27380] IDLE: add base Query dialog with ttk widgets

[Terry J. Reedy]

Terry J. Reedy added the comment:

Serhiy, thank you for the review.  I intend to follow PEP 8 as best as possible 
in the code I touch.  I also fixed some of the comments.

I did a bit of refactoring that make it trivial to check for reuse of help 
source names.  See new issue #27465.  All that is needed is for configdialog to 
pass a used_names argument. I already changed the HelpSource htest to do so.

I have tested the configdialog changes by running it with live IDLE.  I intend 
to push after a final check.

--
Added file: http://bugs.python.org/file43658/query-helpsource2.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27380] IDLE: add base Query dialog with ttk widgets

[Terry J. Reedy]

Terry J. Reedy added the comment:

Next patch should finish issue except for a couple of minor questions.

--
stage: test needed -> commit review
Added file: http://bugs.python.org/file43651/query-helpsource.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27380] IDLE: add base Query dialog with ttk widgets

[Terry J. Reedy]

Terry J. Reedy added the comment:

(Misdirected notice copied here)
New changeset 78a3d3700233 by Terry Jan Reedy in branch 'default':
Issue 27437: Add query.ModuleName and use it for file => Load Module.
https://hg.python.org/cpython/rev/78a3d3700233

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27380] IDLE: add base Query dialog with ttk widgets

[Terry J. Reedy]

Terry J. Reedy added the comment:

Added tests for ModuleName.  Will recheck and push.

--
Added file: http://bugs.python.org/file43618/query4.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27380] IDLE: add base Query dialog with ttk widgets

[Terry J. Reedy]

Terry J. Reedy added the comment:

Revised load_module and new query.ModuleName work, including when invoked by 
open_class_browser.  Tests are need for both.  One problem was that using 
withdrawn root rather than a text as parent caused query.Query to not appear, 
so wait_window could not be terminated.

--
stage: needs patch -> test needed
Added file: http://bugs.python.org/file43570/query3.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27380] IDLE: add base Query dialog with ttk widgets

[Terry J. Reedy]

Terry J. Reedy added the comment:

Thanks, I will switch to True and False.

I am aware of the possibility of separately importing the constants, but like 
some others, I prefer the strings.  Compile-time checking is a good point, 
especially with no run tests.  In this case, test_query has 100% coverage of 
query.py.

Minor question: While trying to  use the new widget (instead of tkSimpledialog) 
in (editor.EditorWindow).open_module I had problems which I am trying to pin 
down by taking smaller steps.  As part of this, I tried this minimal code that 
uses Query.

from idlelib import query
from tkinter import Tk
root = Tk()
name = query.Query(root, "Open Module",
 "Enter the name of a Python module\n"
 "to search on sys.path and open:",).result
print(name)

It works fine except that entry.focus_set() is not working for me with this 
call (or else it is not staying set) even though it works fine when 
configdialog calls the SectionName subclass.  I know Windows is more 
troublesome than *nix about focus, but do you have any idea why calling Query 
this way, instead of as in the committed patch, would make a difference?

--
stage: patch review -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27380] IDLE: add base Query dialog with ttk widgets

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

You can use True and False instead of TRUE and FALSE. You can import constants 
with "from tkinter.constants import *". The benefit of using constants instead 
of string literals is early failing in case of typo.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27380] IDLE: add base Query dialog with ttk widgets

[Terry J. Reedy]

Terry J. Reedy added the comment:

Pushed with minor changes.  I decided not to wait until I added more subclasses 
because file renames with post rename changes do not survive shelving.  
Reloading from the diff requires 'rediscovering' the renames.

--
Added file: http://bugs.python.org/file43554/query2.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27380] IDLE: add base Query dialog with ttk widgets

[Roundup Robot]

Roundup Robot added the comment:

New changeset 4796d7fb00c5 by Terry Jan Reedy in branch 'default':
Issue #27380: IDLE: add base Query dialog, with ttk widgets and subclass
https://hg.python.org/cpython/rev/4796d7fb00c5

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27380] IDLE: add base Query dialog with ttk widgets

[Terry J. Reedy]

New submission from Terry J. Reedy:

The custom popup entry dialogs in config_sec and config_help have a common 
structure and overlapping code.  When one hits OK and the entry is not valid, 
both display a specific message and let the user edit the entry (or Cancel).

File => Load Module, on the other hand, uses tkSimpleDialog.askstring.  No 
error checking is done before the box disappears.  If there is an error, even a 
simple misspelling, one must start over.  It is really annoying to use.  I want 
to replace this with a custom popup that would be the same as the one in 
config_sec, except for title, prompt, and validation function.  If the name 
given has multiple conponents, such as idlelib.idelhelp.help_xyz, I would like 
to report which is the first invalid component (going from left to right).

I am therefore adding a new module, query.py, with a new Query class that will 
be the baseclass for three derived classes.

The partial patch renames config_sec.py (formerly configSectionNameDialog.py) 
to query.py.  The corresponding test_config_sec) becomes test_query.  It splits 
class GetCfgSectionNameDialog into a base class Query and a subclass 
SectionName.  Query is responsible for the popup, and used ttk widgets as 
appropriate.  SectionName overrides the entry validation function entry_ok 
(formerly name_ok).  The test functions have been similarly split.

What remains are ModuleName and HelpSource subclasses, corresponding tests, and 
integration with the software that would use them.

--
assignee: terry.reedy
files: query.diff
keywords: patch
messages: 269154
nosy: terry.reedy
priority: normal
severity: normal
stage: patch review
status: open
title: IDLE: add base Query dialog with ttk widgets
type: enhancement
versions: Python 3.6
Added file: http://bugs.python.org/file43526/query.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com