[issue27566] Tools/freeze/winmakemakefile.py clean target should use 'del' instead of 'rm'

[Steve Dower]

Steve Dower added the comment:

Committed the patch as-is. I suspect make will have a way to suppress UI 
anyway, but if not then we can do another patch!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27566] Tools/freeze/winmakemakefile.py clean target should use 'del' instead of 'rm'

[Roundup Robot]

Roundup Robot added the comment:

New changeset e96eb2bd0d5e by Steve Dower in branch '2.7':
Issue #27566: Fix clean target in freeze makefile (patch by Lisa Roach)
https://hg.python.org/cpython/rev/e96eb2bd0d5e

New changeset 3303df95 by Steve Dower in branch '3.5':
Issue #27566: Fix clean target in freeze makefile (patch by Lisa Roach)
https://hg.python.org/cpython/rev/3303df95

New changeset 6a2d95630a7c by Steve Dower in branch 'default':
Issue #27566: Fix clean target in freeze makefile (patch by Lisa Roach)
https://hg.python.org/cpython/rev/6a2d95630a7c

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27566] Tools/freeze/winmakemakefile.py clean target should use 'del' instead of 'rm'

[Zachary Ware]

Zachary Ware added the comment:

It is run by nmake.

This isn't Cygwin-related, it's for 'freezing' a program a la py2exe or 
cx_Freeze; see Tools/freeze/README.  I have yet to try it without py2exe or 
cx_Freeze, but it's theoretically possible :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27566] Tools/freeze/winmakemakefile.py clean target should use 'del' instead of 'rm'

[Steve Dower]

Steve Dower added the comment:

I suspect it will also need the /Q option, at least on the one with the 
wildcard, otherwise there will be a prompt. Though I'm not entirely clear on 
where this is run (nmake?) so maybe it's already suppressed.

The fact that I'm not familiar with this makefile suggests it isn't needed for 
normal Windows builds though, and if this is only meant for Cygwin/MinGW builds 
then I think assuming rf availability is fine.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27566] Tools/freeze/winmakemakefile.py clean target should use 'del' instead of 'rm'

[SilentGhost]

Changes by SilentGhost :


--
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27566] Tools/freeze/winmakemakefile.py clean target should use 'del' instead of 'rm'

[Lisa Roach]

Lisa Roach added the comment:

I think this patch makes the proper fix, changed the lines:

print("\t-rm -f *.obj")
print("\t-rm -f $(target).exe")

to 

print("\t-del /f *.obj")
print("\t-del /f $(target).exe")

--
keywords: +patch
nosy: +lisroach
Added file: http://bugs.python.org/file43999/rm_to_del.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27566] Tools/freeze/winmakemakefile.py clean target should use 'del' instead of 'rm'

[Zachary Ware]

Changes by Zachary Ware :


--
keywords: +easy
stage:  -> needs patch
title: Freeze: winmakemakefile.py: clean: Linux instead of Windows command -> 
Tools/freeze/winmakemakefile.py clean target should use 'del' instead of 'rm'
versions:  -Python 3.2, Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com