[issue27591] multiprocessing: Possible uninitialized pointer use in Windows builds

[Berker Peksag]

Berker Peksag added the comment:

Thanks! I should read PEP 7 again :)

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27591] multiprocessing: Possible uninitialized pointer use in Windows builds

[Roundup Robot]

Roundup Robot added the comment:

New changeset da955567d7c7 by Berker Peksag in branch '3.5':
Issue #27591: Set sigint_event to NULL if _PyOS_IsMainThread() returns false
https://hg.python.org/cpython/rev/da955567d7c7

New changeset d5f796da4013 by Berker Peksag in branch 'default':
Issue #27591: Merge from 3.5
https://hg.python.org/cpython/rev/d5f796da4013

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27591] multiprocessing: Possible uninitialized pointer use in Windows builds

[STINNER Victor]

STINNER Victor added the comment:

issue27591_v2.diff LGTM except of a minor comment (PEP 7!) on the review.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27591] multiprocessing: Possible uninitialized pointer use in Windows builds

[Berker Peksag]

Berker Peksag added the comment:

Here is an updated patch. Thanks, Victor.

--
Added file: http://bugs.python.org/file43837/issue27591_v2.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27591] multiprocessing: Possible uninitialized pointer use in Windows builds

[STINNER Victor]

STINNER Victor added the comment:

I suggested a different way to fix the issue on the review.

Python 2.7 is not affected by the bug, but Python 3.5 and 3.6 are affected.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27591] multiprocessing: Possible uninitialized pointer use in Windows builds

[STINNER Victor]

STINNER Victor added the comment:

It's a little strange that nobody reports a multiprocessing crash on Windows 
before. It looks like ResetEvent() is called with a random number (coming from 
the uninitialized stack memory).

Windows is probably smart and does nothing if the argument is not a known 
handle of an event object.

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27591] multiprocessing: Possible uninitialized pointer use in Windows builds

[Chris Angelico]

Chris Angelico added the comment:

Cool cool! Then someone will need to notify the PVS-Studio people that we've 
fixed the two bugs that are actually our bugs :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27591] multiprocessing: Possible uninitialized pointer use in Windows builds

[Berker Peksag]

Berker Peksag added the comment:

Yes, that's why I assigned it to myself :) Thanks for the patch!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27591] multiprocessing: Possible uninitialized pointer use in Windows builds

[Chris Angelico]

Chris Angelico added the comment:

Berker, I don't push code to CPython (I have the commitbit for PEP editing), so 
do you want to push that?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27591] multiprocessing: Possible uninitialized pointer use in Windows builds

[Berker Peksag]

Berker Peksag added the comment:

LGTM

--
assignee:  -> berker.peksag
components: +Extension Modules
nosy: +berker.peksag
stage:  -> patch review
type:  -> behavior
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27591] multiprocessing: Possible uninitialized pointer use in Windows builds

[Chris Angelico]

New submission from Chris Angelico:

Originally reported (if you can call it "reported") here: 
http://www.viva64.com/en/b/0414/

AFAICT, this is an easy and inconsequential fix.

--
files: uninitialized-pointer.patch
keywords: patch
messages: 270991
nosy: Rosuav
priority: normal
severity: normal
status: open
title: multiprocessing: Possible uninitialized pointer use in Windows builds
versions: Python 3.6
Added file: http://bugs.python.org/file43832/uninitialized-pointer.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com