[issue27748] Simplify test_winsound

[Roundup Robot]

Roundup Robot added the comment:

New changeset fb74947843eb by Zachary Ware in branch '2.7':
Issue #27748: Backed out changeset 6137d0ed0a15
https://hg.python.org/cpython/rev/fb74947843eb

New changeset e85ce70b73b3 by Zachary Ware in branch '3.5':
Issue #27748: Backed out changeset f845e24d794e
https://hg.python.org/cpython/rev/e85ce70b73b3

New changeset 29300ed6dffe by Zachary Ware in branch 'default':
Issue #27748: Merge with 3.5
https://hg.python.org/cpython/rev/29300ed6dffe

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27748] Simplify test_winsound

[Roundup Robot]

Roundup Robot added the comment:

New changeset 6137d0ed0a15 by Zachary Ware in branch '2.7':
Issue #27748: strengthen test_alias_nofallback
https://hg.python.org/cpython/rev/6137d0ed0a15

New changeset f845e24d794e by Zachary Ware in branch '3.5':
Issue #27748: strengthen test_alias_nofallback
https://hg.python.org/cpython/rev/f845e24d794e

New changeset 5e8b865ffedd by Zachary Ware in branch 'default':
Issue #27748: Merge with 3.5
https://hg.python.org/cpython/rev/5e8b865ffedd

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27748] Simplify test_winsound

[Roundup Robot]

Roundup Robot added the comment:

New changeset 4c91651912d1 by Zachary Ware in branch '2.7':
Issue #27748: Simplify test_winsound.
https://hg.python.org/cpython/rev/4c91651912d1

New changeset 82467d0dbaea by Zachary Ware in branch '3.5':
Issue #27748: Simplify test_winsound.
https://hg.python.org/cpython/rev/82467d0dbaea

New changeset 27cbdd8cf67f by Zachary Ware in branch 'default':
Closes #27748: Merge with 3.5
https://hg.python.org/cpython/rev/27cbdd8cf67f

--
nosy: +python-dev
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27748] Simplify test_winsound

[Zachary Ware]

New submission from Zachary Ware:

test_winsound is rather annoying.  It currently attempts to determine whether a 
sound card is present, and whether particular system sounds are available.  
These checks are fragile at best, and I routinely see failures that shouldn't 
be.  In particular, if I have an open RDP session to my ware-win81-release 
buildbot, test_winsound fails because it thinks the sounds should fail to play, 
but instead they succeed.

Rather than attempt to make the checks more robust, I suggest that we instead 
rip out the checks and simply ensure that each call that might succeed either 
returns normally or raises RuntimeError.  After all, we can't actually test 
whether a sound really played or not.

--
assignee: zach.ware
components: Tests, Windows
files: simplify_test_winsound.diff
keywords: patch
messages: 272546
nosy: paul.moore, steve.dower, tim.golden, zach.ware
priority: low
severity: normal
stage: patch review
status: open
title: Simplify test_winsound
type: behavior
versions: Python 2.7, Python 3.5, Python 3.6
Added file: http://bugs.python.org/file44089/simplify_test_winsound.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com