[issue28068] Error in freeze.py due to unguarded sys.abiflags usage under Windows

[Ned Deily]

Ned Deily  added the comment:

This appears to be a duplicate of Issue32217 which was fixed in 3.7.4 and 
3.8.0. If that doesn't solve the problem, please reopen with a current failure.

--
nosy: +ned.deily
resolution:  -> duplicate
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.7, Python 3.8 -Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28068] Error in freeze.py due to unguarded sys.abiflags usage under Windows

[Steve Dower]

Steve Dower added the comment:

That folder won't ever exist on Windows - if anything it should just be 
os.path.join(sys.execprefix, "DLLs"), but I'm not even sure how valuable that 
is.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28068] Error in freeze.py due to unguarded sys.abiflags usage under Windows

[SilentGhost]

Changes by SilentGhost :


Removed file: http://bugs.python.org/file44538/28068.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28068] Error in freeze.py due to unguarded sys.abiflags usage under Windows

[SilentGhost]

SilentGhost added the comment:

Given that it's a Windows issue, I'm sure Windows core developers in the nosy 
list would find a way to verify the fix. For the record, this bug was 
introduced in issue 11824.

--
nosy: +meador.inge

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28068] Error in freeze.py due to unguarded sys.abiflags usage under Windows

[Gevorg Voskanyan]

Gevorg Voskanyan added the comment:

It works OK for me, but as mentioned above `ishome` is True in my setup, so the 
path-related changes in the patch don't affect my setup in any way. I really 
don't know how it would affect setups of other people where `ishome` is False. 
So no, I can't be sure about hidden issues related to potentially incorrect 
paths. Sorry for not being able to help with that aspect here :(

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28068] Error in freeze.py due to unguarded sys.abiflags usage under Windows

[SilentGhost]

SilentGhost added the comment:

Sure, that was just a typo. While "no errors" is good news, does the code is 
actually doing what it's supposed to do? Are you sure there aren't any hidden 
issue related to the potentially incorrect paths?

--
Added file: http://bugs.python.org/file44562/28068_2.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28068] Error in freeze.py due to unguarded sys.abiflags usage under Windows

[Gevorg Voskanyan]

Gevorg Voskanyan added the comment:

Thanks for the patch! It makes the error go away for me, but only because 
`ishome` is True in my case. Were it False, it would fail the same way on the 
line containing sys.abiflags .
I think this line in the patch:
flagged_version = version + sys.abiflags
should be changed to:
flagged_version = version + abiflags
That way I get no errors regardless of the value of `ishome`.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28068] Error in freeze.py due to unguarded sys.abiflags usage under Windows

[SilentGhost]

SilentGhost added the comment:

Here is the patch, I'm not sure if any more changes are needed there, so it 
would be good to test.

--
components: +Windows
keywords: +patch
nosy: +SilentGhost, paul.moore, steve.dower, tim.golden, zach.ware
stage:  -> patch review
type: compile error -> behavior
versions: +Python 3.6
Added file: http://bugs.python.org/file44538/28068.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28068] Error in freeze.py due to unguarded sys.abiflags usage under Windows

[Gevorg Voskanyan]

New submission from Gevorg Voskanyan:

Traceback (most recent call last):
  File ".../freeze.py", line 493, in 
main()
  File ".../freeze.py", line 222, in main
flagged_version = version + sys.abiflags
AttributeError: module 'sys' has no attribute 'abiflags'

--
components: Demos and Tools
messages: 275686
nosy: gevorg
priority: normal
severity: normal
status: open
title: Error in freeze.py due to unguarded sys.abiflags usage under Windows
type: compile error
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com