[issue28086] test.test_getargs2.TupleSubclass test failure

[Donald Stufft]

Changes by Donald Stufft :


--
pull_requests: +957

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28086] test.test_getargs2.TupleSubclass test failure

[Roundup Robot]

Roundup Robot added the comment:

New changeset 5324906ae307 by Serhiy Storchaka in branch '3.6':
Issue #28086: Single var-positional argument of tuple subtype was passed
https://hg.python.org/cpython/rev/5324906ae307

New changeset 858afd17e3ee by Serhiy Storchaka in branch 'default':
Issue #28086: Single var-positional argument of tuple subtype was passed
https://hg.python.org/cpython/rev/858afd17e3ee

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28086] test.test_getargs2.TupleSubclass test failure

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28086] test.test_getargs2.TupleSubclass test failure

[Raymond Hettinger]

Raymond Hettinger added the comment:

> The simplest way is just change PyTuple_Check to 
> PyTuple_CheckExact in ceval.c.

+1

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28086] test.test_getargs2.TupleSubclass test failure

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The simplest way is just change PyTuple_Check to PyTuple_CheckExact in ceval.c. 
Maybe this is suboptimal for tuple subclasses (namedtuple?), but I think this 
is very rare case.

--
keywords: +patch
stage: needs patch -> patch review
versions: +Python 3.7
Added file: http://bugs.python.org/file44785/issue28086.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28086] test.test_getargs2.TupleSubclass test failure

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

This bug is not so critical. This bug exists in 3.5 and 2.7. Tests was added in 
issue18531, but at that moment the bug already was fixed in 3.6 (maybe 
accidentally).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28086] test.test_getargs2.TupleSubclass test failure

[Gregory P. Smith]

Gregory P. Smith added the comment:

I'm marking this as a deferred blocker as i believe we want this resolved 
before we exit the betas.

--
nosy: +gregory.p.smith
priority: normal -> deferred blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28086] test.test_getargs2.TupleSubclass test failure

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you for making buildbots green Steve.

The intent of 51b635e81958 was avoiding needless copying. But this caused to 
leaking tuple subtype in case of single var-positional argument without other 
positional arguments. The intent of tests was checking that tuple subtype is 
not leaked to called function. There is a bug, but I need to find the place 
where tuple subtype should be converted to tuple without needless hitting 
performance.

--
assignee:  -> serhiy.storchaka
components: +Interpreter Core
stage: commit review -> needs patch
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28086] test.test_getargs2.TupleSubclass test failure

[Ned Deily]

Ned Deily added the comment:

Serhiy, what do you think?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28086] test.test_getargs2.TupleSubclass test failure

[Steve Dower]

Changes by Steve Dower :


--
stage: needs patch -> commit review
type: compile error -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28086] test.test_getargs2.TupleSubclass test failure

[Steve Dower]

Steve Dower added the comment:

I added a fix in 7793d34609cb assuming that the intent is to allow subclasses 
of tuple to be passed directly as *args rather than creating a new tuple. The 
original changeset seems to suggest this is the intent.

--
nosy: +ned.deily, steve.dower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28086] test.test_getargs2.TupleSubclass test failure

[Steve Kowalik]

Steve Kowalik added the comment:

I've bisected this via the git mirror, and converting it to the hg changeset 
gives changeset 103659:51b635e81958 as what introduced this failure.

--
nosy: +stevenk

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28086] test.test_getargs2.TupleSubclass test failure

[Barry A. Warsaw]

Changes by Barry A. Warsaw :


--
nosy: +barry

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28086] test.test_getargs2.TupleSubclass test failure

[Robert Collins]

New submission from Robert Collins:

The test.test_getargs2.TupleSubclass test is failing in master. I suspect its a 
fastcall fallout.

--
messages: 275879
nosy: rbcollins, serhiy.storchaka
priority: normal
severity: normal
stage: needs patch
status: open
title: test.test_getargs2.TupleSubclass test failure
type: compile error

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com