[issue28283] test_sock_connect_sock_write_race() of test.test_asyncio.test_selector_events fails randomly on FreeBSD

[Roundup Robot]

Roundup Robot added the comment:

New changeset f7688db81753 by Berker Peksag in branch '3.5':
Issue #28283: Remove flaky test test_sock_connect_sock_write_race again
https://hg.python.org/cpython/rev/f7688db81753

New changeset 0fe04467c4b5 by Berker Peksag in branch '3.6':
Issue #28283: Merge from 3.5
https://hg.python.org/cpython/rev/0fe04467c4b5

New changeset 4ba2f6bce7f4 by Berker Peksag in branch 'default':
Issue #28283: Merge from 3.6
https://hg.python.org/cpython/rev/4ba2f6bce7f4

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28283] test_sock_connect_sock_write_race() of test.test_asyncio.test_selector_events fails randomly on FreeBSD

[Berker Peksag]

Berker Peksag added the comment:

Just saw 
http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.x%203.5/builds/1136/steps/test/logs/stdio
 and went ahead to remove the test.

--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28283] test_sock_connect_sock_write_race() of test.test_asyncio.test_selector_events fails randomly on FreeBSD

[Roundup Robot]

Roundup Robot added the comment:

New changeset cf93671100bf by Berker Peksag in branch '3.5':
Issue #28283: Remove flaky test test_sock_connect_sock_write_race
https://hg.python.org/cpython/rev/cf93671100bf

New changeset b9f18dcbfc4b by Berker Peksag in branch '3.6':
Issue #28283: Merge from 3.5
https://hg.python.org/cpython/rev/b9f18dcbfc4b

New changeset 27fc857ea8af by Berker Peksag in branch 'default':
Issue #28283: Merge from 3.6
https://hg.python.org/cpython/rev/27fc857ea8af

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28283] test_sock_connect_sock_write_race() of test.test_asyncio.test_selector_events fails randomly on FreeBSD

[Yury Selivanov]

Yury Selivanov added the comment:

> I dislike the idea of a test for a race condition which skips itself if it
fails to reproduce the race condition :-/ I like the idea of removing he
unit test.

OK, let's remove the test. I can do that myself in a couple of days.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28283] test_sock_connect_sock_write_race() of test.test_asyncio.test_selector_events fails randomly on FreeBSD

[STINNER Victor]

STINNER Victor added the comment:

I dislike the idea of a test for a race condition which skips itself if it
fails to reproduce the race condition :-/ I like the idea of removing he
unit test.

But I don't have a strong opinion on this issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28283] test_sock_connect_sock_write_race() of test.test_asyncio.test_selector_events fails randomly on FreeBSD

[Yury Selivanov]

Yury Selivanov added the comment:

Berker, I think it's an OK workaround. The test is kind of unstable, to the 
point of me thinking to just remove it (keeping the rest of the patch applied). 
Feel free to apply it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28283] test_sock_connect_sock_write_race() of test.test_asyncio.test_selector_events fails randomly on FreeBSD

[Berker Peksag]

Berker Peksag added the comment:

> If nobody fixes the unit test, I will revert the change.

I attached a patch that skips the test in case of a timeout in issue 28176. Did 
you had a chance to take a look at it?

--
nosy: +berker.peksag
stage:  -> needs patch
type:  -> behavior
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28283] test_sock_connect_sock_write_race() of test.test_asyncio.test_selector_events fails randomly on FreeBSD

[STINNER Victor]

STINNER Victor added the comment:

Yury: Since you pushed the change adding the test, can you please take a look?

If nobody fixes the unit test, I will revert the change.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28283] test_sock_connect_sock_write_race() of test.test_asyncio.test_selector_events fails randomly on FreeBSD

[STINNER Victor]

New submission from STINNER Victor:

The issue #28176 introduced a new unit test which fails randomly on FreeBSD 
buildbots. Recent example:

http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.x%20Shared%203.x/builds/5162/steps/test/logs/stdio

==
ERROR: test_sock_connect_sock_write_race 
(test.test_asyncio.test_selector_events.SelectorLoopFunctionalTests)
--
Traceback (most recent call last):
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd10/build/Lib/test/test_asyncio/test_selector_events.py",
 line 1868, in test_sock_connect_sock_write_race
timeout=TIMEOUT))
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd10/build/Lib/asyncio/base_events.py",
 line 457, in run_until_complete
return future.result()
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd10/build/Lib/asyncio/futures.py", 
line 292, in result
raise self._exception
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd10/build/Lib/asyncio/tasks.py", 
line 239, in _step
result = coro.send(None)
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd10/build/Lib/asyncio/tasks.py", 
line 397, in wait_for
raise futures.TimeoutError()
concurrent.futures._base.TimeoutError

--
components: Tests, asyncio
keywords: buildbot
messages: 277492
nosy: gvanrossum, haypo, koobs, yselivanov
priority: normal
severity: normal
status: open
title: test_sock_connect_sock_write_race() of 
test.test_asyncio.test_selector_events fails randomly on FreeBSD
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com