[issue28455] argparse: convert_arg_line_to_args does not actually expect self argument

[siccegge]

siccegge added the comment:

Looks quite helpfull indeed to me! Thanks!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28455] argparse: convert_arg_line_to_args does not actually expect self argument

[Berker Peksag]

Berker Peksag added the comment:

Thanks! I removed the import statement and simplified the last sentence a bit.

--
nosy: +berker.peksag
resolution:  -> fixed
stage:  -> resolved
status: open -> closed
versions: +Python 3.5, Python 3.6, Python 3.7 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28455] argparse: convert_arg_line_to_args does not actually expect self argument

[Roundup Robot]

Roundup Robot added the comment:

New changeset 4f8f7403881f by Berker Peksag in branch '3.5':
Issue #28455: Clarify example of overriding the convert_arg_line_to_args method
https://hg.python.org/cpython/rev/4f8f7403881f

New changeset 0b29adb5c804 by Berker Peksag in branch '3.6':
Issue #28455: Merge from 3.5
https://hg.python.org/cpython/rev/0b29adb5c804

New changeset a293e5db9083 by Berker Peksag in branch 'default':
Issue #28455: Merge from 3.6
https://hg.python.org/cpython/rev/a293e5db9083

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28455] argparse: convert_arg_line_to_args does not actually expect self argument

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Hello,

I updated the documentation with an example of how to override ArgumentParser 
class. Hope this is a clearer than before.

Please review.

Thanks :)

--
keywords: +patch
nosy: +Mariatta
Added file: http://bugs.python.org/file45121/issue28455.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28455] argparse: convert_arg_line_to_args does not actually expect self argument

[R. David Murray]

R. David Murray added the comment:

The documentation assumes you know how python class methods work, but I agree 
that the wording is not entirely obvious even then and could be improved.  In 
particular it should make clear that the example shows how to define the 
function for subclassing or assignment to the class object.  If you assign it 
to the instance, as in your example, then indeed self does not get passed and 
you want a true single argument function.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28455] argparse: convert_arg_line_to_args does not actually expect self argument

[siccegge]

New submission from siccegge:

Hi!

Both the 3.4 version and the current version of python documentation wrt the 
argparse module imply convert_arg_line_to_args replacements needs to accept two 
arguments while it acutally only works with one. (Not completely sure about 
details but documentation really could be clearer!)

https://docs.python.org/3.4/library/argparse.html#argparse.ArgumentParser.convert_arg_line_to_args

Example from documentation

def convert_arg_line_to_args(self, arg_line):
return arg_line.split()

If codeparser = argparse.ArgumentParser actually does

def convert_arg_line_to_args(self, arg_line):
return arg_line.split()
parser = argparse.ArgumentParser()
parser.convert_arg_line_to_args = convert_arg_line_to_args

The code fails

  File "/usr/lib/python3.5/argparse.py", line 1735, in parse_args
args, argv = self.parse_known_args(args, namespace)
  File "/usr/lib/python3.5/argparse.py", line 1767, in parse_known_args
namespace, args = self._parse_known_args(args, namespace)
  File "/usr/lib/python3.5/argparse.py", line 1779, in _parse_known_args
arg_strings = self._read_args_from_files(arg_strings)
  File "/usr/lib/python3.5/argparse.py", line 2037, in _read_args_from_files
for arg in self.convert_arg_line_to_args(arg_line):
  TypeError: convert_arg_line_to_args() missing 1 required positional argument: 
'arg_line'

--
assignee: docs@python
components: Documentation
messages: 278771
nosy: docs@python, siccegge
priority: normal
severity: normal
status: open
title: argparse: convert_arg_line_to_args does not actually expect self argument
type: behavior
versions: Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com