[issue28480] Compile error on Modules/socketmodule.c

[Donald Stufft]

Changes by Donald Stufft :


--
pull_requests: +921

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28480] Compile error on Modules/socketmodule.c

[Martin Panter]

Martin Panter added the comment:

I also committed a similar but independent fix in Python 2.7 building 
Modules/_sqlite/connection.c, caused by revision 649937bb8f1c, and adjusted 
some tests to work when multithreading is disabled.

For the record, I also opened Issue 28482, Issue 28484 and Issue 28485 about 
other test suite failures identified when multithreading is disabled.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28480] Compile error on Modules/socketmodule.c

[Roundup Robot]

Roundup Robot added the comment:

New changeset 9316b4ebf3fa by Martin Panter in branch '3.6':
Issue #28480: Avoid label at end of compound statement --without-threads
https://hg.python.org/cpython/rev/9316b4ebf3fa

New changeset 7cb86d404866 by Martin Panter in branch '3.6':
Issue #28480: Adjust or skip tests if multithreading is disabled
https://hg.python.org/cpython/rev/7cb86d404866

New changeset 948cf38793ce by Martin Panter in branch 'default':
Issue #28480: Merge multithreading fixes from 3.6
https://hg.python.org/cpython/rev/948cf38793ce

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28480] Compile error on Modules/socketmodule.c

[Roundup Robot]

Roundup Robot added the comment:

New changeset 17629dee23ca by Martin Panter in branch '2.7':
Issue #28480: Avoid label at end of compound statement --without-threads
https://hg.python.org/cpython/rev/17629dee23ca

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28480] Compile error on Modules/socketmodule.c

[Masayuki Yamamoto]

Masayuki Yamamoto added the comment:

Oh, that's enough to work, Martin.
I confirmed too.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28480] Compile error on Modules/socketmodule.c

[Martin Panter]

Martin Panter added the comment:

Thanks for the report and patch. I think an empty statement might be better 
than the dummy assignment. Let me know if the following would work and I will 
commit it:

   done:
+;  /* necessary for --without-threads flag */
 Py_END_ALLOW_THREADS

--
nosy: +martin.panter
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28480] Compile error on Modules/socketmodule.c

[Masayuki Yamamoto]

New submission from Masayuki Yamamoto:

_socket module has failed to compile with --without-threads flag since 
554fb699af8c, because Py_END_ALLOW_THREADS macro exists behind the done label ( 
Modules/socketmodule.c:666 ).

If --without-threads flag goes on, Py_END_ALLOW_THREADS macro replaces to just 
right curly bracket. Therefore, between label and end of block have no 
statements. There needs meaningless statement (e.g. result = result;) to avoid 
compile error.
I wrote a one line patch as a test.

--
components: Build, Extension Modules
files: socketmodule-behind-label.patch
keywords: patch
messages: 279000
nosy: masamoto
priority: normal
severity: normal
status: open
title: Compile error on Modules/socketmodule.c
type: compile error
versions: Python 3.6, Python 3.7
Added file: http://bugs.python.org/file45146/socketmodule-behind-label.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com