[issue28724] Add method send_io, recv_io to the socket module.

[Inada Naoki]

Change by Inada Naoki :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9 -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28724] Add method send_io, recv_io to the socket module.

[miss-islington]

miss-islington  added the comment:


New changeset 87a392db40d52cba18ffc67730856e11cb8cf945 by Miss Islington (bot) 
in branch '3.9':
bpo-28724: Doc: Move socket.send_fds and socket.recv_fds docs to right section 
(GH-22608)
https://github.com/python/cpython/commit/87a392db40d52cba18ffc67730856e11cb8cf945


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28724] Add method send_io, recv_io to the socket module.

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 8.0 -> 9.0
pull_requests: +24235
pull_request: https://github.com/python/cpython/pull/25517

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28724] Add method send_io, recv_io to the socket module.

[Inada Naoki]

Inada Naoki  added the comment:


New changeset 660592f67c0d825b06eb4a38ccc04b34a1f01f00 by Saiyang Gou in branch 
'master':
bpo-28724: Doc: Move socket.send_fds and socket.recv_fds docs to right section 
(GH-22608)
https://github.com/python/cpython/commit/660592f67c0d825b06eb4a38ccc04b34a1f01f00


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28724] Add method send_io, recv_io to the socket module.

[Saiyang Gou]

Change by Saiyang Gou :


--
nosy: +gousaiyang
nosy_count: 7.0 -> 8.0
pull_requests: +24232
pull_request: https://github.com/python/cpython/pull/22608

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28724] Add method send_io, recv_io to the socket module.

[Shantanu]

Shantanu  added the comment:

I was looking at adding stubs for these to typeshed. Is it intentional that we 
ignore the flags and address arguments in the implementation?

--
nosy: +hauntsaninja

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28724] Add method send_io, recv_io to the socket module.

[STINNER Victor]

STINNER Victor  added the comment:

Thanks Shinya Okano for the original patch.

Well done Joannah! Thanks for your tenacity :-) This PR has 100 comments and 27 
commits which shows the complexity of the feature.

Honestly, I'm not 100% happy with current documentation, but I chose to merge 
the PR anyway. Please leave this issue open until the documentation is 
completed to mention corner cases like partial send (similar to sock.send vs 
sock.sendall).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28724] Add method send_io, recv_io to the socket module.

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 8d120f75fb8c8731464b5f7531d74cdbb897d924 by Victor Stinner 
(Joannah Nanjekye) in branch 'master':
bpo-28724: Add methods send_fds and recv_fds to the socket module (GH-12889)
https://github.com/python/cpython/commit/8d120f75fb8c8731464b5f7531d74cdbb897d924


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28724] Add method send_io, recv_io to the socket module.

[STINNER Victor]

STINNER Victor  added the comment:

See also bpo-37385: "test_multiprocessing fails on AMD64 FreeBSD CURRENT Shared 
2.7".

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28724] Add method send_io, recv_io to the socket module.

[Joannah Nanjekye]

Change by Joannah Nanjekye :


--
nosy: +nanjekyejoannah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28724] Add method send_io, recv_io to the socket module.

[Joannah Nanjekye]

Change by Joannah Nanjekye :


--
pull_requests: +12815
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28724] Add method send_io, recv_io to the socket module.

[Christian Heimes]

Christian Heimes added the comment:

Take your time, feature freeze for 3.7 is in about 18 months from now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28724] Add method send_io, recv_io to the socket module.

[Shinya Okano]

Shinya Okano added the comment:

Thanks for reviews and comments. I will work on the weekend.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28724] Add method send_io, recv_io to the socket module.

[Christian Heimes]

Christian Heimes added the comment:

Good idea! Initially I planned to add the functions and some other helpers 
around AF_UNIX to Python 3.6. You can directly copy the example functions from 
the documentation.

https://docs.python.org/3/library/socket.html#socket.socket.sendmsg
https://docs.python.org/3/library/socket.html#socket.socket.recvmsg

Please keep the names send_fds() and recv_fds(), and pass the message like in 
the examples. Some protocols use the payload to signal the count of fds. Your 
patch is also lacking unit tests and documentation update.

--
nosy: +christian.heimes
stage:  -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28724] Add method send_io, recv_io to the socket module.

[Julien Palard]

Julien Palard added the comment:

Unless somebody don't think so, I think this should go as a pypi module before 
going to the socket module, so this issue should probably be closed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28724] Add method send_io, recv_io to the socket module.

[INADA Naoki]

INADA Naoki added the comment:

FYI, multiprocessing.reduction module has send_fds and recv_fds.

--
nosy: +inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28724] Add method send_io, recv_io to the socket module.

[Julien Palard]

Julien Palard added the comment:

Hi, thanks for your contribution!

Documentation give examples implementation of your methods:

 - https://docs.python.org/3/library/socket.html#socket.socket.sendmsg 
 - https://docs.python.org/3/library/socket.html#socket.socket.recvmsg

and from here, some remarks:

 - Why allowing people to mix fds and file objects? I'm not a fan of this: I 
prefer the clarity of allowing only file descriptors. Have you seen such 
methods (allowing both fd and file obj) in the stdlib?
 - The documented implementation for recv_io checks for integer truncation, 
there may be a good reason, should'n you do the same?
 - The documented implementation allows to pass a message, shouldn't you at 
least allow for an optional message to be passed?

Adding those methods may make sense if people are copying send_fds/recv_fds in 
their code, but I found only two copy/paste in github, so I think the best is 
to put your code as a module on pypi and see, from here, if it gets popular?

You should also write a few tests, and comply to the PEP8 (your two methods 
should probably be separated by a newline).

Bests

--
nosy: +mdk

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28724] Add method send_io, recv_io to the socket module.

[Shinya Okano]

New submission from Shinya Okano:

This patch makes it easy to pass file descriptor in using AF_UNIX.

Ruby language libraries have such methods.

see slso:
 - https://docs.ruby-lang.org/en/2.3.0/UNIXSocket.html#method-i-send_io

--
components: Library (Lib)
files: socket_send_io_recv_io.patch
keywords: patch
messages: 281041
nosy: tokibito
priority: normal
severity: normal
status: open
title: Add method send_io, recv_io to the socket module.
type: enhancement
versions: Python 3.7
Added file: http://bugs.python.org/file45519/socket_send_io_recv_io.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com