[issue28773] typing.FrozenSet missing in documentation.

[Ned Deily]

Ned Deily added the comment:

> Is that the right procedure still?

Yes, thanks!

--
stage: commit review -> resolved

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28773] typing.FrozenSet missing in documentation.

[Guido van Rossum]

Guido van Rossum added the comment:

Thanks! I pushed this into 3.5, then merged into 3.6 and default. Is that the 
right procedure still?

--
resolution:  -> fixed
stage: patch review -> commit review
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28773] typing.FrozenSet missing in documentation.

[Roundup Robot]

Roundup Robot added the comment:

New changeset 7059e68db068 by Guido van Rossum in branch '3.6':
Issue #28773: Add typing.FrozenSet docs. (Manuel Krebber) (3.5->3.6)
https://hg.python.org/cpython/rev/7059e68db068

New changeset 00bfe5bd3553 by Guido van Rossum in branch 'default':
Issue #28773: Add typing.FrozenSet docs. (Manuel Krebber) (3.6->3.7)
https://hg.python.org/cpython/rev/00bfe5bd3553

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28773] typing.FrozenSet missing in documentation.

[Roundup Robot]

Roundup Robot added the comment:

New changeset 5d83b6a9b568 by Guido van Rossum in branch '3.5':
Issue #28773: Add typing.FrozenSet docs. (Manuel Krebber)
https://hg.python.org/cpython/rev/5d83b6a9b568

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28773] typing.FrozenSet missing in documentation.

[Ned Deily]

Ned Deily added the comment:

Guido, doc fixes are welcome!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28773] typing.FrozenSet missing in documentation.

[Guido van Rossum]

Guido van Rossum added the comment:

Ned: does the ban on non-critical commits to the 3.6 branch also apply to doc 
patches?

--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28773] typing.FrozenSet missing in documentation.

[Ivan Levkivskyi]

Ivan Levkivskyi added the comment:

Thank you Manuel!
LGTM.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28773] typing.FrozenSet missing in documentation.

[Manuel Krebber]

Manuel Krebber added the comment:

I updated the patch to add reflect the covariance.

--
Added file: http://bugs.python.org/file45606/frozenset-doc.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28773] typing.FrozenSet missing in documentation.

[Ivan Levkivskyi]

Ivan Levkivskyi added the comment:

The patch looks good, I left just one small comment in Rietveld.

--
nosy: +levkivskyi

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28773] typing.FrozenSet missing in documentation.

[Berker Peksag]

Berker Peksag added the comment:

Thanks for the patch, Manuel. Looks like FrozenSet is in PEP 484 and has been 
added to typing.__all__ in https://github.com/python/typing/pull/261 (already 
synced with the stdlib version of typing module)

The patch looks good to me. Adding Guido to nosy list for a commit review.

--
assignee:  -> docs@python
components: +Documentation -Library (Lib)
nosy: +berker.peksag, docs@python, gvanrossum
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28773] typing.FrozenSet missing in documentation.

[Manuel Krebber]

New submission from Manuel Krebber:

The typing.FrozenSet is missing in the typing module documentation. I have 
attached a patch that adds it similar to the typing.Set which is already in the 
documentation.

--
components: Library (Lib)
files: frozenset-doc.patch
keywords: patch
messages: 281476
nosy: Wheerd
priority: normal
severity: normal
status: open
title: typing.FrozenSet missing in documentation.
type: enhancement
versions: Python 3.5, Python 3.6, Python 3.7
Added file: http://bugs.python.org/file45601/frozenset-doc.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com