[issue28985] sqlite3 authorizer codes constants not up to date

2017-03-31 Thread Donald Stufft 

Changes by Donald Stufft :


--
pull_requests: +870

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28985] sqlite3 authorizer codes constants not up to date

2017-01-01 Thread Berker Peksag 

Berker Peksag added the comment:

Thanks, Dingyuan!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28985] sqlite3 authorizer codes constants not up to date

2017-01-01 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset b9c4139a1309 by Berker Peksag in branch 'default':
Issue #28985: Update authorizer constants in sqlite3 module
https://hg.python.org/cpython/rev/b9c4139a1309

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28985] sqlite3 authorizer codes constants not up to date

2016-12-15 Thread Berker Peksag 

Berker Peksag added the comment:

Looks good to me. Thanks for the patch, Dingyuan.

Since this is an enhancement request, we can only commit your patch to the 
default branch so I updated the versions field accordingly.

--
nosy: +berker.peksag
stage:  -> patch review
versions:  -Python 2.7, Python 3.3, Python 3.4, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28985] sqlite3 authorizer codes constants not up to date

2016-12-15 Thread Dingyuan Wang 

New submission from Dingyuan Wang:

We have the sqlite3.set_authorizer function, where the first argument to its 
callback is one of the Authorizer Action Codes that the SQLite documentations 
defines[1]. However, the constants in the sqlite3 module is not up to date. The 
code in _sqlite/module.c haven't been updated since June, 2006.

According to the SQLite Changelog[2] and digging through the history,

* 2006-08-12 (3.3.7) added SQLITE_CREATE_VTABLE, SQLITE_DROP_VTABLE
* 2006-10-09 (3.3.8) added SQLITE_FUNCTION
* 2009-01-12 (3.6.8) added SQLITE_SAVEPOINT
* 2014-02-03 (3.8.3) added SQLITE_RECURSIVE

The constants above should be present in the module. The documentation[3] says, 
"All necessary constants are available in the sqlite3 module."

[1] https://sqlite.org/c3ref/c_alter_table.html
[2] https://sqlite.org/changes.html
[3] 
https://docs.python.org/3/library/sqlite3.html#sqlite3.Connection.set_authorizer

--
components: Library (Lib)
files: sqlite3.patch
keywords: patch
messages: 283363
nosy: gumblex
priority: normal
severity: normal
status: open
title: sqlite3 authorizer codes constants not up to date
type: enhancement
versions: Python 2.7, Python 3.3, Python 3.4, Python 3.5, Python 3.6, Python 3.7
Added file: http://bugs.python.org/file45921/sqlite3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com