[issue29124] Freeze fails to compile on windows

[Eryk Sun]

Change by Eryk Sun :


--
versions: +Python 3.10, Python 3.8, Python 3.9 -Python 3.5, Python 3.6, Python 
3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29124] Freeze fails to compile on windows

[Steve Dower]

Steve Dower added the comment:

Ah, I was thinking of platform.machine().

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29124] Freeze fails to compile on windows

[Eryk Sun]

Eryk Sun added the comment:

Using platform.architecture [1] is fine here. `bits` defaults to the size of a 
pointer in the current process, i.e. `struct.calcsize('P') * 8`. 

On Windows, it's useless for anything except the default parameters. It doesn't 
call GetBinaryType [2] to distinguish 32-bit and 64-bit executables, so from a 
64-bit process it will incorrectly return that a 32-bit executable is 64-bit.

[1]: https://docs.python.org/3/library/platform.html#platform.architecture
[2]: https://msdn.microsoft.com/en-us/library/aa364819

--
nosy: +eryksun

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29124] Freeze fails to compile on windows

[Steve Dower]

Steve Dower added the comment:

Is platform.architecture() the right way to determine what platform you're 
targeting? This will tell you the current OS, but typically you want to know 
the architecture of the Python process (since you often run 32-bit processes on 
64-bit Windows). If you just want the Python process, checking 
"sys.winver.endswith('-32')" is the easiest way in 3.5 and later to see whether 
it's 32-bit Python.

Otherwise those changes look okay to me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29124] Freeze fails to compile on windows

[Liran Ringel]

New submission from Liran Ringel:

The patch fixes 3 bugs:
1. Include Python.h in frozen_dllmain.c - needed for Py_ARRAY_LENGTH symbol
2. DL_IMPORT is used in checkextensions_win32.py, but it's deprecated and not 
defined anymore. Replaced it with __declspec(dllimport)
3. Fix python lib path in winmakemakefile.py

There is one more thing left to do to make it work, but it already has an open 
issue:
http://bugs.python.org/issue28068

--
components: Demos and Tools, Windows
files: fix-freeze-on-windows.patch
keywords: patch
messages: 284405
nosy: Liran Ringel, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Freeze fails to compile on windows
type: compile error
versions: Python 3.5, Python 3.6, Python 3.7
Added file: http://bugs.python.org/file46104/fix-freeze-on-windows.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com