[issue29180] skip tests that raise PermissionError in test_os (non-root user on Android)

[Xavier de Gaye]

Change by Xavier de Gaye :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29180] skip tests that raise PermissionError in test_os (non-root user on Android)

[Xavier de Gaye]

Xavier de Gaye  added the comment:


New changeset 6a55d09573e5c35c9e4a24a6f811120b41a2a994 by xdegaye in branch 
'master':
bpo-29180: Skip test_os tests on PermissionError raised by Android (GH-4374)
https://github.com/python/cpython/commit/6a55d09573e5c35c9e4a24a6f811120b41a2a994


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29180] skip tests that raise PermissionError in test_os (non-root user on Android)

[Xavier de Gaye]

Change by Xavier de Gaye :


--
pull_requests: +4323

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29180] skip tests that raise PermissionError in test_os (non-root user on Android)

[Xavier de Gaye]

Change by Xavier de Gaye :


--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29180] skip tests that raise PermissionError in test_os (non-root user on Android)

[Xavier de Gaye]

Changes by Xavier de Gaye :


--
assignee: xdegaye -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29180] skip tests that raise PermissionError in test_os (non-root user on Android)

[Xavier de Gaye]

Xavier de Gaye added the comment:

New patch following Serhiy's suggestion in msg285008.

--
Added file: http://bugs.python.org/file46232/issue29180_01.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29180] skip tests that raise PermissionError in test_os (non-root user on Android)

[Xavier de Gaye]

Xavier de Gaye added the comment:

> If test_os is the only user of the helper, I'd say let's keep it in 
> Lib/test/test_os.py for now.

I agree with that concern.

support.os_link() is also used by a patch in issue 29181, and I am planning to 
modify the changes made by issue 28759 to also use it so that tests calling 
os.link() are skipped based on the fact that they raise PermissionError instead 
of based on the fact that they are being run by an Android non-root user as is 
currently the case.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29180] skip tests that raise PermissionError in test_os (non-root user on Android)

[Berker Peksag]

Berker Peksag added the comment:

Are you planning to use test.support.os_link() to fix other tests in near 
future? If test_os is the only user of the helper, I'd say let's keep it in 
Lib/test/test_os.py for now. test.support is already big enough and it would be 
better not to put every snippet in it :)

If there are other tests that can benefit from using it, the patch looks good 
to me.

--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29180] skip tests that raise PermissionError in test_os (non-root user on Android)

[Xavier de Gaye]

Xavier de Gaye added the comment:

Patch attached.

--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file46200/test_os.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29180] skip tests that raise PermissionError in test_os (non-root user on Android)

[Xavier de Gaye]

New submission from Xavier de Gaye:

==  
 [1633/2616]
ERROR: test_link (test.test_os.LinkTests)
--
Traceback (most recent call last):
  File "/sdcard/org.bitbucket.pyona/lib/python3.7/test/test_os.py", line 1703, 
in test_link
self._test_link(self.file1, self.file2)
  File "/sdcard/org.bitbucket.pyona/lib/python3.7/test/test_os.py", line 1698, 
in _test_link
os.link(file1, file2)
PermissionError: [Errno 13] Permission denied: '@test_2295_tmp' -> 
'@test_2295_tmp2'

==
ERROR: test_link_bytes (test.test_os.LinkTests)
--
Traceback (most recent call last):
  File "/sdcard/org.bitbucket.pyona/lib/python3.7/test/test_os.py", line 1707, 
in test_link_bytes
bytes(self.file2, sys.getfilesystemencoding()))
  File "/sdcard/org.bitbucket.pyona/lib/python3.7/test/test_os.py", line 1698, 
in _test_link
os.link(file1, file2)
PermissionError: [Errno 13] Permission denied: b'@test_2295_tmp' -> 
b'@test_2295_tmp2'

==
ERROR: test_unicode_name (test.test_os.LinkTests)
--
Traceback (most recent call last):
  File "/sdcard/org.bitbucket.pyona/lib/python3.7/test/test_os.py", line 1717, 
in test_unicode_name
self._test_link(self.file1, self.file2)
  File "/sdcard/org.bitbucket.pyona/lib/python3.7/test/test_os.py", line 1698, 
in _test_link
os.link(file1, file2)
PermissionError: [Errno 13] Permission denied: '@test_2295_tmpñ' -> 
'@test_2295_tmpñ2'

==
ERROR: test_stty_match (test.test_os.TermsizeTests)
Check if stty returns the same results
--
Traceback (most recent call last):
  File "/sdcard/org.bitbucket.pyona/lib/python3.7/test/test_os.py", line 2795, 
in test_stty_match
size = subprocess.check_output(['stty', 'size']).decode().split()
  File "/sdcard/org.bitbucket.pyona/lib/python3.7/subprocess.py", line 336, in 
check_output
**kwargs).stdout
  File "/sdcard/org.bitbucket.pyona/lib/python3.7/subprocess.py", line 403, in 
run
with Popen(*popenargs, **kwargs) as process:
  File "/sdcard/org.bitbucket.pyona/lib/python3.7/subprocess.py", line 707, in 
__init__
restore_signals, start_new_session)
  File "/sdcard/org.bitbucket.pyona/lib/python3.7/subprocess.py", line 1323, in 
_execute_child
raise child_exception_type(errno_num, err_msg)
PermissionError: [Errno 13] Permission denied

==
ERROR: test_attributes (test.test_os.TestScandir)
--
Traceback (most recent call last):
  File "/sdcard/org.bitbucket.pyona/lib/python3.7/test/test_os.py", line 3150, 
in test_attributes
os.link(filename, os.path.join(self.path, "link_file.txt"))
PermissionError: [Errno 13] Permission denied: 
'/data/local/tmp/test_python_2295/@test_2295_tmp/file
.txt' -> '/data/local/tmp/test_python_2295/@test_2295_tmp/link_file.txt'

--
Ran 238 tests in 4.675s

FAILED (errors=5, skipped=40)
test test_os failed

--
assignee: xdegaye
components: Tests
messages: 284824
nosy: xdegaye
priority: normal
severity: normal
stage: needs patch
status: open
title: skip tests that raise PermissionError in test_os (non-root user on 
Android)
type: behavior
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com