[issue29463] Add `docstring` field to AST nodes

2018-05-29 Thread Serhiy Storchaka 


Serhiy Storchaka  added the comment:


New changeset 73cbe7a01a22d02dbe1ec841e8779c775cad3d08 by Serhiy Storchaka in 
branch 'master':
bpo-32911: Revert bpo-29463. (GH-7121) (GH-7197)
https://github.com/python/cpython/commit/73cbe7a01a22d02dbe1ec841e8779c775cad3d08


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29463] Add `docstring` field to AST nodes

2018-05-29 Thread Serhiy Storchaka 


Change by Serhiy Storchaka :


--
pull_requests: +6832

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29463] Add `docstring` field to AST nodes

2018-05-29 Thread Serhiy Storchaka 


Serhiy Storchaka  added the comment:


New changeset 2641ee5040abb090e66e4ff80c33b76729b36e75 by Serhiy Storchaka in 
branch '3.7':
bpo-32911: Revert bpo-29463. (GH-7121)
https://github.com/python/cpython/commit/2641ee5040abb090e66e4ff80c33b76729b36e75


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29463] Add `docstring` field to AST nodes

2017-05-29 Thread Serhiy Storchaka 

Changes by Serhiy Storchaka :


--
pull_requests:  -842

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29463] Add `docstring` field to AST nodes

2017-05-29 Thread Serhiy Storchaka 

Changes by Serhiy Storchaka :


--
pull_requests:  -584

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29463] Add `docstring` field to AST nodes

2017-03-31 Thread Donald Stufft 

Changes by Donald Stufft :


--
pull_requests: +842

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29463] Add `docstring` field to AST nodes

2017-03-24 Thread STINNER Victor 

STINNER Victor added the comment:


New changeset cb41b2766de646435743b6af7dd152751b54e73f by Victor Stinner (INADA 
Naoki) in branch 'master':
bpo-29463: Add docstring field to some AST nodes. (#46)
https://github.com/python/cpython/commit/cb41b2766de646435743b6af7dd152751b54e73f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29463] Add `docstring` field to AST nodes

2017-03-24 Thread INADA Naoki 

INADA Naoki added the comment:


New changeset 4c78c527d215c37472145152cb0e95f196cdddc9 by INADA Naoki in branch 
'master':
bpo-29622: Make AST constructor to accept less than enough number of positional 
arguments (GH-249)
https://github.com/python/cpython/commit/4c78c527d215c37472145152cb0e95f196cdddc9


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29463] Add `docstring` field to AST nodes

2017-03-17 Thread Larry Hastings 

Changes by Larry Hastings :


--
pull_requests: +584

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29463] Add `docstring` field to AST nodes

2017-02-23 Thread Matthias Bussonnier 

Changes by Matthias Bussonnier :


--
pull_requests: +238

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29463] Add `docstring` field to AST nodes

2017-02-22 Thread INADA Naoki 

INADA Naoki added the comment:

s/ #29522 / #29622 /

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29463] Add `docstring` field to AST nodes

2017-02-22 Thread INADA Naoki 

INADA Naoki added the comment:

OK, let's continue on #29522, and close this issue.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29463] Add `docstring` field to AST nodes

2017-02-22 Thread Matthias Bussonnier 

Matthias Bussonnier added the comment:

thank you for your work on the AST, I know many developers are looking forward 
to improvement and stabilisation with the hope of having it stable (and 
documented) in the stdlib at some point. 

The recent change in PR 46 now change (at least) the constructor of 
`ast.Module` to take a second mandatory parameter (the docstring). 

I know the ast is autogenerated and "use at your own risk". But IPython for 
example, use `mod = ast.Module([nodes])`, with the second mandatory parameter 
added to Module that make it incompatible with current Python 3.7. 
Well it's long until it's released, and we can patch things, but I'm sure we 
are not the only one in this case, and we'd like older version of IPython to 
still be compatible with Python 3.7, so if  `Module()`'s second parameter (the 
docstring) could be optional, that would be great. 

I would be happy if it raise a deprecation warning that it will be required in 
the future.

I'm of course speaking about `Module` because that's the first error I 
encountered, but I'm guessing it applies to other changed AST nodes. 

Thanks.

--
nosy: +mbussonn

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29463] Add `docstring` field to AST nodes

2017-02-22 Thread STINNER Victor 

STINNER Victor added the comment:

This issue broke the ast API. Copy of the following comment on the PR:
https://github.com/python/cpython/pull/46#issuecomment-281721296
---
Carreau: Thanks for this ! Improvement to the AST are welcome !

Would it have been possible to make the docstring optional ? (It's already 
breaking things, like IPython).

Should I comment on upstream bpo ?
---

I created the issue #29622 to fix this.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29463] Add `docstring` field to AST nodes

2017-02-12 Thread INADA Naoki 

Changes by INADA Naoki :


--
pull_requests: +46

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29463] Add `docstring` field to AST nodes

2017-02-12 Thread INADA Naoki 

INADA Naoki added the comment:

Thanks.  I don't familiar with language frontend.
I'll check NEWS entry.

--
title: Add `docstring` attribute to AST nodes -> Add `docstring` field to AST 
nodes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com