[issue29887] test_normalization doesn't work

2020-09-19 Thread Benjamin Peterson 


Change by Benjamin Peterson :


--
resolution:  -> fixed
stage: backport needed -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2020-09-19 Thread Irit Katriel 


Irit Katriel  added the comment:

Looks like this is complete and can be closed.

--
nosy: +iritkatriel

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-06-22 Thread Benjamin Peterson 

Changes by Benjamin Peterson :


--
pull_requests: +2389

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-06-20 Thread STINNER Victor 

STINNER Victor added the comment:


New changeset 070ba85a8f45819d9197bce4541cd594d79d247c by Victor Stinner 
(Mariatta) in branch '3.5':
[3.5] bpo-29887: Test normalization now fails if download fails (GH-905) (#2272)
https://github.com/python/cpython/commit/070ba85a8f45819d9197bce4541cd594d79d247c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-06-19 Thread STINNER Victor 

STINNER Victor added the comment:


New changeset acdf159b245aaac28f54dd10606911386ab39058 by Victor Stinner in 
branch '3.6':
bpo-29887: test_normalization handles PermissionError (#1196) (#2275)
https://github.com/python/cpython/commit/acdf159b245aaac28f54dd10606911386ab39058


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-06-19 Thread STINNER Victor 

Changes by STINNER Victor :


--
pull_requests: +2324

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-06-19 Thread STINNER Victor 

STINNER Victor added the comment:


New changeset 51f40a81a4acbc85cb1034750fb16cb1854b2315 by Victor Stinner 
(Mariatta) in branch '3.6':
[3.6] bpo-29887: Test normalization now fails if download fails (GH-905) (#2271)
https://github.com/python/cpython/commit/51f40a81a4acbc85cb1034750fb16cb1854b2315


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-06-18 Thread Mariatta Wijaya 

Changes by Mariatta Wijaya :


--
pull_requests: +2321

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-06-18 Thread Mariatta Wijaya 

Changes by Mariatta Wijaya :


--
pull_requests: +2322

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-04-25 Thread Mariatta Wijaya 

Changes by Mariatta Wijaya :


--
stage:  -> backport needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-04-19 Thread STINNER Victor 

STINNER Victor added the comment:

Cool! "x86 Gentoo Installed with X 3.x" succeeded.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-04-19 Thread STINNER Victor 

STINNER Victor added the comment:


New changeset d13d54748d3a7db023d9db37223ea7d40bb8f8e3 by Victor Stinner in 
branch 'master':
bpo-29887: test_normalization handles PermissionError (#1196)
https://github.com/python/cpython/commit/d13d54748d3a7db023d9db37223ea7d40bb8f8e3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-04-19 Thread STINNER Victor 

STINNER Victor added the comment:

> The test should try to write the file in a temporary file, or simply skip the 
> test.

I proposed https://github.com/python/cpython/pull/1196 to skip the test in that 
case.

Creating a temporary file is more complex since the API doesn't work as a 
context manager, and it's unclear who would be responsible to remove the 
temporary file.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-04-19 Thread STINNER Victor 

Changes by STINNER Victor :


--
pull_requests: +1321

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-03-30 Thread STINNER Victor 

STINNER Victor added the comment:

Oh, Zachary reported me the following failure which is legitimate. The code 
doesn't handle correctly read-only library directory.

The test should try to write the file in a temporary file, or simply skip the 
test.

http://buildbot.python.org/all/builders/x86%20Gentoo%20Installed%20with%20X%203.x/builds/500/steps/test/logs/stdio

==
FAIL: test_main (test.test_normalization.NormalizationTest)
--
Traceback (most recent call last):
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.installed/build/target/lib/python3.7/test/test_normalization.py",
 line 42, in test_main
check=check_version)
PermissionError: [Errno 13] Permission denied: 
'/buildbot/buildarea/3.x.ware-gentoo-x86.installed/build/target/lib/python3.7/test/data/NormalizationTest.txt'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File 
"/buildbot/buildarea/3.x.ware-gentoo-x86.installed/build/target/lib/python3.7/test/test_normalization.py",
 line 44, in test_main
self.fail(f"Could not retrieve {TESTDATAURL}")
AssertionError: Could not retrieve 
http://www.pythontest.net/unicode/9.0.0/NormalizationTest.txt

--
Ran 2 tests in 0.149s

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-03-30 Thread STINNER Victor 

STINNER Victor added the comment:


New changeset 722a3af092b94983aa26f5e591fb1b45e2c2a0ff by Victor Stinner in 
branch 'master':
bpo-29887: Test normalization now fails if download fails (#905)
https://github.com/python/cpython/commit/722a3af092b94983aa26f5e591fb1b45e2c2a0ff


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-03-30 Thread STINNER Victor 

STINNER Victor added the comment:

Benjamin: "We should change the tests to fail if they get a 404."

Good idea. Currently, the test is explicitly skipped on this case. Since "-u 
urlfetch" option must be explicitly passed on the command line, it makes sense 
to fail on that case.

I proposed https://github.com/python/cpython/pull/905 change for that. Not sure 
if it's worth to backport such change to older Python versions?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-03-30 Thread STINNER Victor 

Changes by STINNER Victor :


--
pull_requests: +805

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-03-30 Thread Benjamin Peterson 

Benjamin Peterson added the comment:

We should change the tests to fail if they get a 404.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-03-27 Thread Brett Cannon 

Brett Cannon added the comment:

Benjamin did the update to 9.0.0.

We should probably update Tools/unicode/makeunicodedata.py to print out in the 
end that the appropriate file needs to be added to pythontest.net **before** 
merging an update to unicodedata.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-03-27 Thread STINNER Victor 

STINNER Victor added the comment:

http://www.pythontest.net/unicode/7.0.0/NormalizationTest.txt exists, but not 
http://www.pythontest.net/unicode/8.0.0/NormalizationTest.txt nor 
http://www.pythontest.net/unicode/9.0.0/NormalizationTest.txt

Maybe the dev who upgrade Unicode to 8.0 and then 9.0 forgot to upload required 
files to the pythontest website?

I confirm that 8.0 and 9.0 lacks from 
https://github.com/python/pythontestdotnet/tree/master/www/unicode

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-03-24 Thread Terry J. Reedy 

Terry J. Reedy added the comment:

Fetching the file requires '-u urlfetch' or '-u all'.  For me, the test 'works' 
by skipping test_main.  Loading www.pythontest.net refers one to 
https://github.com/python/pythontestdotnet/.  Pinging contributors there.

--
nosy: +benjamin.peterson, berker.peksag, brett.cannon, terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29887] test_normalization doesn't work

2017-03-23 Thread Serhiy Storchaka 

New submission from Serhiy Storchaka:

It needs to fetch http://www.pythontest.net/unicode/9.0.0/NormalizationTest.txt 
(8.0.0 in 3.5) but get the 404 error.

--
components: Tests
messages: 290053
nosy: serhiy.storchaka
priority: normal
severity: normal
status: open
title: test_normalization doesn't work
type: behavior
versions: Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com