[issue29912] Overlapping tests between list_tests and seq_tests

2017-03-27 Thread Brett Cannon 

Changes by Brett Cannon :


--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29912] Overlapping tests between list_tests and seq_tests

2017-03-27 Thread Brett Cannon 

Brett Cannon added the comment:


New changeset d702c50049207d825c1d5925fbc7306514fa9a0a by Brett Cannon (Jim 
Fasarakis-Hilliard) in branch 'master':
bpo-29912: Remove redundant tests in list_tests that are found in seq_tests 
(GH-847)
https://github.com/python/cpython/commit/d702c50049207d825c1d5925fbc7306514fa9a0a


--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29912] Overlapping tests between list_tests and seq_tests

2017-03-27 Thread Jim Fasarakis-Hilliard 

Changes by Jim Fasarakis-Hilliard :


--
pull_requests: +745

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29912] Overlapping tests between list_tests and seq_tests

2017-03-27 Thread Jim Fasarakis-Hilliard 

Jim Fasarakis-Hilliard added the comment:

Correction: test_index *partially* duplicates the base class method. It too can 
be modified to use super like test_imul.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29912] Overlapping tests between list_tests and seq_tests

2017-03-26 Thread Jim Fasarakis-Hilliard 

New submission from Jim Fasarakis-Hilliard:

Seems the CommonTests class defined in list_tests duplicates the testing 
performed by seq_tests.CommonTests in the following functions:

test_index, test_count

Additionally, a part of test_imul from list_tests.CommonTests can be moved to 
seq_tests.CommonTests. (specifically, up until `self.assertEqual(u, 
self.type2test([]))`).

Am I missing some non-obvious thing here or can I safely remove the two test 
functions in list_tests.CommonTests and move (while also adding a super call) 
part of test_imul from list_tests.CommonTests to test_imul in 
seq_tests.CommonTests?

Some links:

[1a] seq_tests test_index: 
https://github.com/python/cpython/blob/1e73dbbc29c96d0739ffef92db36f63aa1aa30da/Lib/test/seq_tests.py#L363
[1b] list_tests test_index:
https://github.com/python/cpython/blob/1e73dbbc29c96d0739ffef92db36f63aa1aa30da/Lib/test/list_tests.py#L376

[2a] seq_tests test_count:
https://github.com/python/cpython/blob/1e73dbbc29c96d0739ffef92db36f63aa1aa30da/Lib/test/seq_tests.py#L344
[2b] list_tests test_count:
https://github.com/python/cpython/blob/1e73dbbc29c96d0739ffef92db36f63aa1aa30da/Lib/test/list_tests.py#L357

[3a] seq_tests test_imul:
https://github.com/python/cpython/blob/1e73dbbc29c96d0739ffef92db36f63aa1aa30da/Lib/test/seq_tests.py#L300
[3b] list_tests test_imul:
https://github.com/python/cpython/blob/1e73dbbc29c96d0739ffef92db36f63aa1aa30da/Lib/test/list_tests.py#L550

--
components: Tests
messages: 290550
nosy: Jim Fasarakis-Hilliard
priority: normal
severity: normal
status: open
title: Overlapping tests between list_tests and seq_tests
type: behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com