[issue30167] site.main() does not work on Python 3.6 and superior if PYTHONSTARTUP is set

[INADA Naoki]

Change by INADA Naoki :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30167] site.main() does not work on Python 3.6 and superior if PYTHONSTARTUP is set

[INADA Naoki]

INADA Naoki  added the comment:


New changeset 82daa60defbd6497efdaa6c1132ecc8563122ed5 by INADA Naoki in branch 
'master':
bpo-30167: Remove __cached__ from __main__ when removing __file__ (GH-7415)
https://github.com/python/cpython/commit/82daa60defbd6497efdaa6c1132ecc8563122ed5


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30167] site.main() does not work on Python 3.6 and superior if PYTHONSTARTUP is set

[INADA Naoki]

INADA Naoki  added the comment:


New changeset d4c76d960b8b286b75c933780416ace9cda682fd by INADA Naoki in branch 
'master':
bpo-30167: Add test for module.__cached__ is None (GH-7617)
https://github.com/python/cpython/commit/d4c76d960b8b286b75c933780416ace9cda682fd


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30167] site.main() does not work on Python 3.6 and superior if PYTHONSTARTUP is set

[INADA Naoki]

Change by INADA Naoki :


--
pull_requests: +7238
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30167] site.main() does not work on Python 3.6 and superior if PYTHONSTARTUP is set

[Ned Deily]

Ned Deily  added the comment:

As I noted in the discussion on PR 6731, I think there should be a test for 
this so we don't break it again.  But, since it seems that the problem has 
affected a number of users and projects and since the fix is easy and easily 
testable manually, I decided to merge the PR for 3.7.0rc1 and 3.6.6rc1.  I am 
leaving the issue open for someone to supply a PR with a test case and for 
discussion of PR 7415.  Thank you all!

--
stage: patch review -> needs patch
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30167] site.main() does not work on Python 3.6 and superior if PYTHONSTARTUP is set

[Ned Deily]

Ned Deily  added the comment:


New changeset 3e121581d008a780b8a9f1bcda5966cf0c06f6d5 by Ned Deily (Miss 
Islington (bot)) in branch '3.6':
bpo-30167: Prevent site.main() exception if PYTHONSTARTUP is set. (GH-6731) 
(GH-7607)
https://github.com/python/cpython/commit/3e121581d008a780b8a9f1bcda5966cf0c06f6d5


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30167] site.main() does not work on Python 3.6 and superior if PYTHONSTARTUP is set

[Ned Deily]

Ned Deily  added the comment:


New changeset ec4343c3b4c0e0a7500122fac616e6488c0ab842 by Ned Deily (Miss 
Islington (bot)) in branch '3.7':
bpo-30167: Prevent site.main() exception if PYTHONSTARTUP is set. (GH-6731) 
(GH-7606)
https://github.com/python/cpython/commit/ec4343c3b4c0e0a7500122fac616e6488c0ab842


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30167] site.main() does not work on Python 3.6 and superior if PYTHONSTARTUP is set

[miss-islington]

Change by miss-islington :


--
pull_requests: +7230

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30167] site.main() does not work on Python 3.6 and superior if PYTHONSTARTUP is set

[miss-islington]

Change by miss-islington :


--
pull_requests: +7229

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30167] site.main() does not work on Python 3.6 and superior if PYTHONSTARTUP is set

[Ned Deily]

Ned Deily  added the comment:


New changeset 2487f30d5529948ace26559e274d7cac6abcd1a8 by Ned Deily (Steve 
Weber) in branch 'master':
bpo-30167: Prevent site.main() exception if PYTHONSTARTUP is set. (GH-6731)
https://github.com/python/cpython/commit/2487f30d5529948ace26559e274d7cac6abcd1a8


--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30167] site.main() does not work on Python 3.6 and superior if PYTHONSTARTUP is set

[INADA Naoki]

Change by INADA Naoki :


--
pull_requests: +7039

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30167] site.main() does not work on Python 3.6 and superior if PYTHONSTARTUP is set

[INADA Naoki]

INADA Naoki  added the comment:

https://github.com/python/cpython/blob/f822549653d8d09b5b7dcddfdf12679a787c/Python/pythonrun.c#L391-L399

__file__ and __cached__ are added here.  And,

https://github.com/python/cpython/blob/f822549653d8d09b5b7dcddfdf12679a787c/Python/pythonrun.c#L441-L442

Only __file__ is removed here.  I feel __cached__ should be removed too.


On the other hand, if None is valid value for __cached__, site.abs_paths() 
should ignore it.

https://www.python.org/dev/peps/pep-3147/#file

> It is recommended that when nothing sensible can be calculated, 
> implementations should set the __cached__ attribute to None.

It seems it's valid, and recommended for some cases.  So PR-6731 looks OK.

--
nosy: +inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30167] site.main() does not work on Python 3.6 and superior if PYTHONSTARTUP is set

[steverweber]

Change by steverweber :


--
keywords: +patch
pull_requests: +6432
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30167] site.main() does not work on Python 3.6 and superior if PYTHONSTARTUP is set

[steverweber]

steverweber  added the comment:

ref to other projects that hit this issue.

https://gitlab.idiap.ch/bob/bob.buildout/issues/15
https://github.com/saltstack/salt/issues/45080
https://groups.google.com/forum/#!msg/comp.lang.python/tpfiHAJhl9Y/hZj1f50vBQAJ

--
nosy: +steverweber

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30167] site.main() does not work on Python 3.6 and superior if PYTHONSTARTUP is set

[André Anjos]

Changes by André Anjos :


--
title: site.main() does not work on Python 3.6 and superior with PYTHONSTARTUP 
is set -> site.main() does not work on Python 3.6 and superior if PYTHONSTARTUP 
is set

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com