[issue30411] git doesn't support "-C" args under 1.8.5 occurs in configure.ac

2018-08-20 Thread Xiang Zhang 


Change by Xiang Zhang :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30411] git doesn't support "-C" args under 1.8.5 occurs in configure.ac

2018-08-20 Thread Xiang Zhang 


Xiang Zhang  added the comment:


New changeset 95f9e14e33b713f35f5368acf7be56750bbdb5a8 by Xiang Zhang in branch 
'2.7':
[2.7] bpo-30411: Use --git-dir instead of -C to make git work under version 
below 1.8.5. (GH-8744) (GH-8838)
https://github.com/python/cpython/commit/95f9e14e33b713f35f5368acf7be56750bbdb5a8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30411] git doesn't support "-C" args under 1.8.5 occurs in configure.ac

2018-08-20 Thread miss-islington 


miss-islington  added the comment:


New changeset 2011dd77b6bd6f02f54ceef9a80a22bd373b66e2 by Miss Islington (bot) 
in branch '3.7':
bpo-30411: Use --git-dir instead of -C to make git work under version below 
1.8.5. (GH-8744)
https://github.com/python/cpython/commit/2011dd77b6bd6f02f54ceef9a80a22bd373b66e2


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30411] git doesn't support "-C" args under 1.8.5 occurs in configure.ac

2018-08-20 Thread Xiang Zhang 


Change by Xiang Zhang :


--
pull_requests: +8313

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30411] git doesn't support "-C" args under 1.8.5 occurs in configure.ac

2018-08-20 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +8312

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30411] git doesn't support "-C" args under 1.8.5 occurs in configure.ac

2018-08-20 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +8311

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30411] git doesn't support "-C" args under 1.8.5 occurs in configure.ac

2018-08-20 Thread Xiang Zhang 


Xiang Zhang  added the comment:


New changeset 4c8555773a801f957297132a92c0acb382d640e4 by Xiang Zhang in branch 
'master':
bpo-30411: Use --git-dir instead of -C to make git work under version below 
1.8.5. (GH-8744)
https://github.com/python/cpython/commit/4c8555773a801f957297132a92c0acb382d640e4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30411] git doesn't support "-C" args under 1.8.5 occurs in configure.ac

2018-08-12 Thread Xiang Zhang 


Change by Xiang Zhang :


--
keywords: +patch
pull_requests: +8227
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30411] git doesn't support "-C" args under 1.8.5 occurs in configure.ac

2018-06-22 Thread Ned Deily 


Ned Deily  added the comment:

Thanks for the PR.  I agree with Xiang Zhang that using --git-dir appears to be 
a better solution.  See other review comments on the PR.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30411] git doesn't support "-C" args under 1.8.5 occurs in configure.ac

2018-06-20 Thread Xiang Zhang 


Xiang Zhang  added the comment:

Encounter the same problem on centos7 and git version is 1.8.3. Instead of 
checking the version to use -C option, maybe we could just use --git-dir for 
the same purpose?

--- a/configure
+++ b/configure
@@ -2749,9 +2749,9 @@ HAS_GIT=no-repository
 fi
 if test $HAS_GIT = found
 then
-GITVERSION="git -C \$(srcdir) rev-parse --short HEAD"
-GITTAG="git -C \$(srcdir) describe --all --always --dirty"
-GITBRANCH="git -C \$(srcdir) name-rev --name-only HEAD"
+GITVERSION="git --git-dir \$(srcdir)/.git rev-parse --short HEAD"
+GITTAG="git --git-dir \$(srcdir)/.git describe --all --always --dirty"
+GITBRANCH="git --git-dir \$(srcdir)/.git name-rev --name-only HEAD"
 else
 GITVERSION=""
 GITTAG=""
diff --git a/configure.ac b/configure.ac
index b13728e..278ed9f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -39,9 +39,9 @@ HAS_GIT=no-repository
 fi
 if test $HAS_GIT = found
 then
-GITVERSION="git -C \$(srcdir) rev-parse --short HEAD"
-GITTAG="git -C \$(srcdir) describe --all --always --dirty"
-GITBRANCH="git -C \$(srcdir) name-rev --name-only HEAD"
+GITVERSION="git --git-dir \$(srcdir)/.git rev-parse --short HEAD"
+GITTAG="git --git-dir \$(srcdir)/.git describe --all --always --dirty"
+GITBRANCH="git --git-dir \$(srcdir)/.git name-rev --name-only HEAD"
 else
 GITVERSION=""
 GITTAG=""

This could give me the right sys._git info.

--
components: +Build
nosy: +ned.deily, xiang.zhang
versions: +Python 2.7, Python 3.6, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30411] git doesn't support "-C" args under 1.8.5 occurs in configure.ac

2018-05-16 Thread Eitan Adler 

Change by Eitan Adler :


--
nosy: +eitan.adler

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30411] git doesn't support "-C" args under 1.8.5 occurs in configure.ac

2017-05-20 Thread Roundup Robot 

Changes by Roundup Robot :


--
pull_requests: +1775

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30411] git doesn't support "-C" args under 1.8.5 occurs in configure.ac

2017-05-20 Thread Roundup Robot 

Changes by Roundup Robot :


--
pull_requests: +1774

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30411] git doesn't support "-C" args under 1.8.5 occurs in configure.ac

2017-05-20 Thread Yuan Liu 

New submission from Yuan Liu:

git doesn't support "-C" args under 1.8.5 occurs in configure.ac

as I noticed from git release notes in 1.8.5: 

 * Just like "make -C ", "git -C  ..." tells Git
   to go there before doing anything else.

So we should have some conditional statements in configure.ac around git 
checkpoint, otherwise we got error message which is :

Unknown option: -C
usage: git [--version] [--help] [-c name=value]
   [--exec-path[=]] [--html-path] [--man-path] [--info-path]
   [-p|--paginate|--no-pager] [--no-replace-objects] [--bare]
   [--git-dir=] [--work-tree=] [--namespace=]
[]

--
messages: 294021
nosy: Yuan Liu
priority: normal
severity: normal
status: open
title: git doesn't support "-C" args under 1.8.5 occurs in configure.ac
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com