[issue30722] Tools/demo/redemo.py broken

[Berker Peksag]

Change by Berker Peksag :


--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30722] Tools/demo/redemo.py broken

[Berker Peksag]

Berker Peksag  added the comment:


New changeset 9d85856044a2c7d681ea38b5ff99af375b228a0f by Berker Peksag in 
branch '3.6':
bpo-30722: Fix NEWS entry (GH-8501)
https://github.com/python/cpython/commit/9d85856044a2c7d681ea38b5ff99af375b228a0f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30722] Tools/demo/redemo.py broken

[Berker Peksag]

Berker Peksag  added the comment:


New changeset 7cbde0e09daba4259565738e48f141851287fe29 by Berker Peksag (Miss 
Islington (bot)) in branch '3.7':
bpo-30722: Fix NEWS entries (GH-8501)
https://github.com/python/cpython/commit/7cbde0e09daba4259565738e48f141851287fe29


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30722] Tools/demo/redemo.py broken

[Berker Peksag]

Change by Berker Peksag :


--
pull_requests: +8023

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30722] Tools/demo/redemo.py broken

[miss-islington]

Change by miss-islington :


--
pull_requests: +8022

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30722] Tools/demo/redemo.py broken

[Berker Peksag]

Berker Peksag  added the comment:


New changeset 612dbefe9dfce0f67bce358613e472e913be8a57 by Berker Peksag in 
branch 'master':
bpo-30722: Fix NEWS entries (GH-8501)
https://github.com/python/cpython/commit/612dbefe9dfce0f67bce358613e472e913be8a57


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30722] Tools/demo/redemo.py broken

[Berker Peksag]

Change by Berker Peksag :


--
pull_requests: +8019
stage: resolved -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30722] Tools/demo/redemo.py broken

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

The news message is verbose but looks misleading to me. There is nothing 
invalid with usages like getattr(re, 'DOTALL'). It is the same as re.DOTALL, 
and using enums haven't changed this.

--
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30722] Tools/demo/redemo.py broken

[Berker Peksag]

Berker Peksag  added the comment:

Thank you, Christoph. I wasn't aware of Tools/demo/redemo.py and I must say it 
was fun to play with while reviewing PR 2311.

--
components: +Demos and Tools -Regular Expressions
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30722] Tools/demo/redemo.py broken

[Berker Peksag]

Berker Peksag  added the comment:


New changeset a5f9d24c171c7e3a3715161fd16b747c7dcaf76f by Berker Peksag (Miss 
Islington (bot)) in branch '3.6':
bpo-30722: Make redemo work with Python 3.6+ (GH-2311)
https://github.com/python/cpython/commit/a5f9d24c171c7e3a3715161fd16b747c7dcaf76f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30722] Tools/demo/redemo.py broken

[Roundup Robot]

Change by Roundup Robot :


--
keywords: +patch
pull_requests: +4060
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30722] Tools/demo/redemo.py broken

[Berker Peksag]

Berker Peksag  added the comment:


New changeset 62adc55aff0b78447568f73bd1abc610d2784bf8 by Berker Peksag 
(Christoph Sarnowski) in branch 'master':
bpo-30722: Make redemo work with Python 3.6+ (GH-2311)
https://github.com/python/cpython/commit/62adc55aff0b78447568f73bd1abc610d2784bf8


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30722] Tools/demo/redemo.py broken

[Roundup Robot]

Changes by Roundup Robot :


--
pull_requests: +2356

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30722] Tools/demo/redemo.py broken

[Christoph Sarnowski]

Christoph Sarnowski added the comment:

By the way, I confused the flags, in my error-reproduction steps, instead of 
the re.MULTILINE flag, it is the re.DOTALL flag that should lead to all lines 
being matched by ".*".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30722] Tools/demo/redemo.py broken

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I think ideally it would be nice to provide a switch between Unicode and bytes 
and disable the LOCALE flag in the Unicode mode. But this is too complex task. 
I think it is better to remove LOCALE.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30722] Tools/demo/redemo.py broken

[Christoph Sarnowski]

Christoph Sarnowski added the comment:

Hi, sorry for forgetting steps to reproduce the bug.

Easiest way to see it is to start redemo.py from a console (important on 
windows), so you can see stdout/stderr.
Then just a click on any of those flag checkboxes leads to an exception 
backtrace printed on the console.

And to demonstrate that the flag checkbox does not work, enter ".*" (without 
quotes) as the pattern, and any multiline string as the string to search, and 
activate the checkbox "MULTILINE".
Correct behaviour: no exception, all lines of the string get highlighted as the 
first match
Erroneous (actual) behaviour: An exception traceback gets printed: 
'_tkinter.TclError: expected integer but got "RegexFlag.MULTILINE"'
and only the first line is highlighted as first match, demonstrating that the 
MULTILINE flag is in fact not active.


When it comes to a pull request, I could do that for the change that I 
proposed. But regarding the "LOCALE" flag, the better solution (in my opinion) 
would be to make it work instead of just removing it, but that is a more 
elaborate change that I am not able to spend time on.

What would you suggest?
a) I provide a pull request, leaving "LOCALE" flag behaviour broken
b) I provide a pull request, removing "LOCALE" flag (to be introduced again 
when someone is willing to fix it)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30722] Tools/demo/redemo.py broken

[Louie Lu]

Louie Lu added the comment:

Also, would you like to contribute with PR on GitHub?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30722] Tools/demo/redemo.py broken

[Louie Lu]

Louie Lu added the comment:

Hi Christoph, chould you provide a small example that breaks the regex demo? 
thanks!

--
nosy: +louielu

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30722] Tools/demo/redemo.py broken

[Christoph Sarnowski]

New submission from Christoph Sarnowski:

In Python 3.6, the flags in the "re" module became members of an enum.IntFlag, 
whereas before they were just ints.

This breaks the regex demo in Tools/demo/redemo.py.

To fix this, in line 86 of redemo.py, 

getattr(re, name)

has to be replaced by 

getattr(re, name).value

Also, the checkbox for "LOCALE" can be removed (or fixed), as re.LOCALE is 
invalid for str patterns.

--
components: Regular Expressions
messages: 296530
nosy: Christoph Sarnowski2, ezio.melotti, mrabarnett
priority: normal
severity: normal
status: open
title: Tools/demo/redemo.py broken
type: behavior
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com