[issue3101] global function _add_one_to_C

[Travis Oliphant]

Travis Oliphant [EMAIL PROTECTED] added the comment:

I've added comments in the code to document these functions.  I have no
opinion where they live except they should probably be available to
extensions modules. 

These routines increment an N-length counter representing a position in
an N-dimensional array with wrap-around when the counter reaches the
size of the dimension.  Thus, for a (2,3) array we have:

F-version

0,0
1,0
2,0
0,1
1,1
2,1

C-version
0,0
0,1
0,2
1,0
1,1
1,2

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3101
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3101] global function _add_one_to_C

[Antoine Pitrou]

Changes by Antoine Pitrou [EMAIL PROTECTED]:


--
nosy: +pitrou

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3101
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3101] global function _add_one_to_C

[Antoine Pitrou]

Antoine Pitrou [EMAIL PROTECTED] added the comment:

A sensible solution would be to put all the memoryview / buffer API
stuff in the same standalone file (e.g. memoryobject.c), rather than
having half of it dumped in abstract.c.

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3101
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3101] global function _add_one_to_C

[Ricardo Quesada]

Ricardo Quesada [EMAIL PROTECTED] added the comment:

This seems to be fixed in r62348
http://svn.python.org/view?rev=62348view=rev

--
nosy: +riq

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3101
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3101] global function _add_one_to_C

[Martin v. Löwis]

Martin v. Löwis [EMAIL PROTECTED] added the comment:

Ok, so it's fixed for the trunk, but not Py3k. The trunk fix doesn't
port to 3k, since the functions are called inside memoryobject.c (so
making them static would break that module).

--
versions:  -Python 2.6

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3101
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3101] global function _add_one_to_C

[Martin v. Löwis]

New submission from Martin v. Löwis [EMAIL PROTECTED]:

abstract.c defines two functions _add_one_to_C and _add_one_to_F. These
apparently must be global, as memoryobject.c references them. Therefore,
they should get a Py or _Py prefix.

A short comment for what these functions actually do would also be
appreciated.

--
assignee: teoliphant
messages: 68133
nosy: loewis, teoliphant
severity: normal
status: open
title: global function _add_one_to_C
versions: Python 2.6, Python 3.0

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3101
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com