[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

[miss-islington]

miss-islington  added the comment:


New changeset 2a37f013ec81099a6156160ce66803b2609bb7f4 by Miss Islington (bot) 
in branch '3.7':
bpo-35308: Fix regression where BROWSER env var is not respected. (GH-10693)
https://github.com/python/cpython/commit/2a37f013ec81099a6156160ce66803b2609bb7f4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

[miss-islington]

Change by miss-islington :


--
pull_requests: +9978

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 8c281ed403fd915284d5bba2405d7c47f8195066 by Serhiy Storchaka 
(Zhiming Wang) in branch 'master':
bpo-35308: Fix regression where BROWSER env var is not respected. (GH-10693)
https://github.com/python/cpython/commit/8c281ed403fd915284d5bba2405d7c47f8195066


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 2.7, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

[miss-islington]

miss-islington  added the comment:


New changeset a410f9f614b62cd7df220186d081ffd73786be91 by Miss Islington (bot) 
in branch '3.7':
bpo-31014: Fix the webbrowser module. (GH-7267)
https://github.com/python/cpython/commit/a410f9f614b62cd7df220186d081ffd73786be91


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

[miss-islington]

Change by miss-islington :


--
pull_requests: +7738

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 25b804a9c21c735ce322877f105ebab2539ccfc1 by Serhiy Storchaka in 
branch 'master':
bpo-31014: Fix the webbrowser module. (GH-7267)
https://github.com/python/cpython/commit/25b804a9c21c735ce322877f105ebab2539ccfc1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

PR 7267 is based on PR 2689, but adds two tests that cover both cases of using 
webbrowser._synthesize().

--
versions: +Python 2.7, Python 3.6, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +6895

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

[Nick Coghlan]

Change by Nick Coghlan :


--
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

[STINNER Victor]

STINNER Victor  added the comment:

I'm surprised that test_webbrowser pass on my Fedora 28, but it fails for Greg 
Walters:
https://bugs.python.org/issue33693#msg318163

Some tests are skipped depending on the OS? Maybe we should mock more things, 
or something else, to get a better code coverage.

I ran PR 2689 new test without the fix on webbrowser.py: the test doesn't fail. 
So this PR is not enough to detect bpo-33693.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

[STINNER Victor]

STINNER Victor  added the comment:

bpo-33693 has been marked as a duplicate of this issue. It seems to be a 
regression caused by bpo-24241.

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

This would be not easy. Since the BROWSER environment variable should be 
patched before the first use the webbrowser module, the test should import 
webbrowser in a separate process (you can use the 
test.support.script_helper.assert_python_ok() helper).

_synthesize() is used in two places with different arguments: in 
register_standard_browsers() and in get().

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

[John Still]

John Still added the comment:

Ok I understand what you mean.

I think the only conditions for test failure are (A) $BROWSER is set and (B) 
$BROWSER is set to an actual executable that should be caught by 
``register_standard_browsers`` prior to execution reaching the last if clause 
of ``register_standard_browsers`` (``if 'BROWSER' in os.environ:``) - those two 
conditions should be sufficient for execution to reach the offending line of 
code.

I'll see if I can cook up a test for that.  I think the right way to do this is 
to monkeypatch ``os.environ`` and ``shutil.which``, am I right?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

These tests are not failing on our buildbots and developer's computers. Seems 
they are failing only in special environment. This path of execution is not 
tested in more common environments, therefore possible regression couldn't be 
caught until somebody run tests in similar special environment. New test should 
test this path of execution in common environments.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

[John Still]

John Still added the comment:

What would a new test be testing? I only found this behaviour because two 
existing tests were failing (with the PR they pass, of course). I'm happy to 
write a test, I'm just not sure what the test should be testing that the 
existing tests don't already test.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Is it possible to write a test?

--
nosy: +daves, ncoghlan, serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

[John Still]

New submission from John Still:

The function `register` of the `webbrowser` module was updated a little while 
back to use the newish keyword-only argument syntax; however, the function 
`_synthesize` (also in `webbrowser`) is still using the outdated positional 
arguments only calling convention; leading a pair of tests in 
`Lib/tests/test_webbrowser.py` to fail.  I've issued a PR that fixes the 
function call to use the more modern calling convention.

--
components: Library (Lib)
messages: 298976
nosy: jmsdvl
priority: normal
pull_requests: 2890
severity: normal
status: open
title: webbrowser._synthesize uses outdated calling signature for 
webbrowser.register
type: behavior
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com