[issue31151] socketserver.ForkingMixIn.server_close() leaks zombie processes

[STINNER Victor]

STINNER Victor  added the comment:

The bug has been fixed in Python 3.7.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31151] socketserver.ForkingMixIn.server_close() leaks zombie processes

[STINNER Victor]

STINNER Victor  added the comment:

I created bpo-33540: "socketserver: Add an opt-in option to get Python 3.6 
behaviour on server_close()". I set the release blocker priority on this new 
issue.

--
priority: deferred blocker -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31151] socketserver.ForkingMixIn.server_close() leaks zombie processes

[STINNER Victor]

STINNER Victor  added the comment:


New changeset db8189bb8db609ca3993dec31fb95fdbe134469a by Victor Stinner in 
branch 'master':
bpo-31233, bpo-31151: Document socketserver changes (#5417)
https://github.com/python/cpython/commit/db8189bb8db609ca3993dec31fb95fdbe134469a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31151] socketserver.ForkingMixIn.server_close() leaks zombie processes

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +5252
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31151] socketserver.ForkingMixIn.server_close() leaks zombie processes

[STINNER Victor]

STINNER Victor  added the comment:

> What's the status of this?  Feature freeze is here!

This issue is very to https://bugs.python.org/issue31233#msg311021 as it's 
status:
* The commit aa8ec34ad52bb3b274ce91169e1bc4a598655049 is backward incompatible 
and it's not documented
* There is no option to opt-in for the previous behaviour (exit without waiting 
for child processes)

For beta1, IMHO it's ok to keep the current status. But I would like to see 
this issue fixed before 3.7 final. Either revert my change, or do something 
else.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31151] socketserver.ForkingMixIn.server_close() leaks zombie processes

[Ned Deily]

Ned Deily  added the comment:

What's the status of this?  Feature freeze is here!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31151] socketserver.ForkingMixIn.server_close() leaks zombie processes

[STINNER Victor]

STINNER Victor added the comment:

I proposed the bpo-31593 to fix the issue differently in Python 3.6 (and maybe 
also Python 2.7).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31151] socketserver.ForkingMixIn.server_close() leaks zombie processes

[Ned Deily]

Changes by Ned Deily :


--
priority: release blocker -> deferred blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31151] socketserver.ForkingMixIn.server_close() leaks zombie processes

[STINNER Victor]

STINNER Victor added the comment:

I tag this issue as release blocker as a remainder that we have to agree how to 
handle threads/processes before Python 3.7 feature freeze.

See also bpo-31233: socketserver.ThreadingMixIn leaks running threads after 
server_close().

--
nosy: +ned.deily
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31151] socketserver.ForkingMixIn.server_close() leaks zombie processes

[STINNER Victor]

STINNER Victor added the comment:

I created a thread on the python-dev mailing list to discuss this issue:
https://mail.python.org/pipermail/python-dev/2017-August/148826.html

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31151] socketserver.ForkingMixIn.server_close() leaks zombie processes

[STINNER Victor]

Changes by STINNER Victor :


--
title: test_socketserver: Warning -- reap_children() reaped child process -> 
socketserver.ForkingMixIn.server_close() leaks zombie processes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com